SeaBIOS

seabios@seabios.org

4 participants
3801 discussions

[RFC PATCH v4] fw/pci: Add support for mapping Intel IGD via QEMU
by Alex Williamson 11 May '16

11 May '16

QEMU provides two fw_cfg files to support IGD. The first holds the OpRegion data which holds the Video BIOS Table (VBT). This needs to be copied into reserved memory and the address stored in the ASL Storage register of the device at 0xFC offset in PCI config space. The OpRegion is generally 8KB. This file is named "etc/igd-opregion". The second file tells us the required size of the stolen memory space for the device. This is a dummy file, it has no backing so we only allocate the space without copying anything into it. This space requires 1MB alignment and is generally either 1MB or 2MB, depending on the hardware config. If the user has opted in QEMU to expose additional stolen memory beyond the GTT (GGMS), the GMS may add an additional 32MB to 512MB. The base address of the reserved memory allocated for this is written back to the Base Data of Stolen Memory register (BDSM) at PCI config offset 0x5C on the device. This file is named "etc/igd-bdsm". Signed-off-by: Alex Williamson <alex.williamson(a)redhat.com> --- v4: Back to a single patch thanks to Kevin's suggestion to use memalign_tmphigh() for larger allocations. Now creating reserved space for stolen memory and writing the value to the BDSM register is queued off the existence of a fw_cfg file, just like the OpRegion. The only difference is that we don't copy the contents, just use the meta data. src/fw/pciinit.c | 47 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+) diff --git a/src/fw/pciinit.c b/src/fw/pciinit.c index 0ed5dfb..dc2e433 100644 --- a/src/fw/pciinit.c +++ b/src/fw/pciinit.c @@ -269,6 +269,49 @@ static void ich9_smbus_setup(struct pci_device *dev, void *arg) pci_config_writeb(bdf, ICH9_SMB_HOSTC, ICH9_SMB_HOSTC_HST_EN); } +static void intel_igd_setup(struct pci_device *dev, void *arg) +{ + struct romfile_s *opregion = romfile_find("etc/igd-opregion"); + struct romfile_s *bdsm = romfile_find("etc/igd-bdsm"); + void *addr; + u16 bdf = dev->bdf; + + if (opregion && opregion->size) { + addr = memalign_high(PAGE_SIZE, opregion->size); + if (!addr) { + warn_noalloc(); + return; + } + + if (opregion->copy(opregion, addr, opregion->size) < 0) { + free(addr); + return; + } + + pci_config_writel(bdf, 0xFC, cpu_to_le32((u32)addr)); + + dprintf(1, "Intel IGD OpRegion enabled at 0x%08x, size %dKB, dev " + "%02x:%02x.%x\n", (u32)addr, opregion->size >> 10, + pci_bdf_to_bus(bdf), pci_bdf_to_dev(bdf), pci_bdf_to_fn(bdf)); + } + + if (bdsm && bdsm->size) { + addr = memalign_tmphigh(1024 * 1024, bdsm->size); + if (!addr) { + warn_noalloc(); + return; + } + + e820_add((u32)addr, bdsm->size, E820_RESERVED); + + pci_config_writel(bdf, 0x5C, cpu_to_le32((u32)addr)); + + dprintf(1, "Intel IGD BDSM enabled at 0x%08x, size %dMB, dev " + "%02x:%02x.%x\n", (u32)addr, bdsm->size >> 20, + pci_bdf_to_bus(bdf), pci_bdf_to_dev(bdf), pci_bdf_to_fn(bdf)); + } +} + static const struct pci_device_id pci_device_tbl[] = { /* PIIX3/PIIX4 PCI to ISA bridge */ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82371SB_0, @@ -302,6 +345,10 @@ static const struct pci_device_id pci_device_tbl[] = { PCI_DEVICE_CLASS(PCI_VENDOR_ID_APPLE, 0x0017, 0xff00, apple_macio_setup), PCI_DEVICE_CLASS(PCI_VENDOR_ID_APPLE, 0x0022, 0xff00, apple_macio_setup), + /* Intel IGD OpRegion setup */ + PCI_DEVICE_CLASS(PCI_VENDOR_ID_INTEL, PCI_ANY_ID, PCI_CLASS_DISPLAY_VGA, + intel_igd_setup), + PCI_DEVICE_END, };

4 6

[PATCH RFC 0/2] support booting more than 255 CPUs with QEMU
by Igor Mammedov 10 May '16

10 May '16

According to SDM, if CPUs have APIC ID more than 254 firmware should pass control to OS in x2APIC mode. This series adds x2APIC bootstrap initialization. QEMU side of x2APIC support: https://lists.gnu.org/archive/html/qemu-devel/2016-05/msg01094.html Igor Mammedov (2): paravirt: disable MPTable in case of more than 255 CPUs support booting with more than 255 CPUs src/fw/mptable.c | 4 ++++ src/fw/smp.c | 48 +++++++++++++++++++++++++++++++++++++++--------- src/x86.h | 1 + 3 files changed, 44 insertions(+), 9 deletions(-) -- 1.8.3.1

2 7

Re: [SeaBIOS] seabios does not support booting from usb-uas with nec-usb-xhci
by Gerd Hoffmann 09 May '16

09 May '16

On Fr, 2016-05-06 at 17:00 +0800, Tom Yan wrote: > Strangely, seabios supports booting from usb-uas with usb-ehci: > > https://drive.google.com/open?id=0B50PCxfm5KU1dUFTUG9HU0pEcXc > > and usb-bot with nec-usb-xhci: > > https://drive.google.com/open?id=0B50PCxfm5KU1QnVzdTBIdEFzZW8 > > but not usb-uas with nec-usb-xhci: > > https://drive.google.com/open?id=0B50PCxfm5KU1Z0t1akNXaVZZLTQ > > This makes me wonder if it is just a missing feature of a bug. missing support for usb3 streams in seabios. cheers, Gerd

2 1

Re: [SeaBIOS] seabios does not support booting from usb-uas with nec-usb-xhci
by Tom Yan 06 May '16

06 May '16

Sorry, I forgot to mention that I am using qemu 2.5.1 and seabios 1.9.2. On 6 May 2016 at 17:04, Tom Yan <tom.ty89(a)gmail.com> wrote: > On 6 May 2016 at 17:00, Tom Yan <tom.ty89(a)gmail.com> wrote: >> >> This makes me wonder if it is just a missing feature of a bug. >> > > I meant "or" instead of "of".

1 0

Re: [SeaBIOS] seabios does not support booting from usb-uas with nec-usb-xhci
by Tom Yan 06 May '16

06 May '16

On 6 May 2016 at 17:00, Tom Yan <tom.ty89(a)gmail.com> wrote: > > This makes me wonder if it is just a missing feature of a bug. > I meant "or" instead of "of".

1 0

seabios does not support booting from usb-uas with nec-usb-xhci
by Tom Yan 06 May '16

06 May '16

Strangely, seabios supports booting from usb-uas with usb-ehci: https://drive.google.com/open?id=0B50PCxfm5KU1dUFTUG9HU0pEcXc and usb-bot with nec-usb-xhci: https://drive.google.com/open?id=0B50PCxfm5KU1QnVzdTBIdEFzZW8 but not usb-uas with nec-usb-xhci: https://drive.google.com/open?id=0B50PCxfm5KU1Z0t1akNXaVZZLTQ This makes me wonder if it is just a missing feature of a bug. Btw, not sure if it's relevant, booting usb-uas is not at all supported in ovmf: https://github.com/tianocore/edk2/issues/85

1 0

Re: [SeaBIOS] [Qemu-devel] how to enable nvme device in Qemu?
by Stefan Hajnoczi 26 Apr '16

26 Apr '16

On Tue, Apr 19, 2016 at 08:37:42AM +0000, Qingtao Sun wrote: > I want to boot OS from NVMe device in qemu-2.5.1. But I didn't find the bootable NVMe device in guest BIOS. How to enable this feature? I don't see an NVMe driver so I guess SeaBIOS does not support boot from NVMe: https://code.coreboot.org/p/seabios/source/tree/master/src/hw I have CCed the SeaBIOS mailing list in case they have any advice. Stefan

1 0

Tagging 1.9.2?
by Roger Pau Monné 22 Apr '16

22 Apr '16

Hello, The Xen project is about to release a newer version of Xen (4.7), and we would like to have commit 3910de in our tree (SeaBIOS version bundled with Xen is currently 1.9.1). Is there any chance 1.9.2 could be tagged from the current stable-1.9 branch, or should we cherry-pick the change? Thanks, Roger.

3 3

[PATCH 1/2] virtio: Use threads when scanning for virtio devices
by Kevin O'Connor 19 Apr '16

19 Apr '16

Signed-off-by: Kevin O'Connor <kevin(a)koconnor.net> --- src/hw/virtio-blk.c | 6 ++++-- src/hw/virtio-scsi.c | 6 ++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/hw/virtio-blk.c b/src/hw/virtio-blk.c index 2dfd0c3..dca7855 100644 --- a/src/hw/virtio-blk.c +++ b/src/hw/virtio-blk.c @@ -15,6 +15,7 @@ #include "pcidevice.h" // foreachpci #include "pci_ids.h" // PCI_DEVICE_ID_VIRTIO_BLK #include "pci_regs.h" // PCI_VENDOR_ID +#include "stacks.h" // run_thread #include "std/disk.h" // DISK_RET_SUCCESS #include "string.h" // memset #include "util.h" // usleep @@ -93,8 +94,9 @@ virtio_blk_process_op(struct disk_op_s *op) } static void -init_virtio_blk(struct pci_device *pci) +init_virtio_blk(void *data) { + struct pci_device *pci = data; u8 status = VIRTIO_CONFIG_S_ACKNOWLEDGE | VIRTIO_CONFIG_S_DRIVER; dprintf(1, "found virtio-blk at %pP\n", pci); struct virtiodrive_s *vdrive = malloc_fseg(sizeof(*vdrive)); @@ -203,6 +205,6 @@ virtio_blk_setup(void) (pci->device != PCI_DEVICE_ID_VIRTIO_BLK_09 && pci->device != PCI_DEVICE_ID_VIRTIO_BLK_10)) continue; - init_virtio_blk(pci); + run_thread(init_virtio_blk, pci); } } diff --git a/src/hw/virtio-scsi.c b/src/hw/virtio-scsi.c index 322d469..5fb9409 100644 --- a/src/hw/virtio-scsi.c +++ b/src/hw/virtio-scsi.c @@ -16,6 +16,7 @@ #include "pcidevice.h" // foreachpci #include "pci_ids.h" // PCI_DEVICE_ID_VIRTIO_BLK #include "pci_regs.h" // PCI_VENDOR_ID +#include "stacks.h" // run_thread #include "std/disk.h" // DISK_RET_SUCCESS #include "string.h" // memset #include "util.h" // usleep @@ -132,8 +133,9 @@ virtio_scsi_scan_target(struct pci_device *pci, struct vp_device *vp, } static void -init_virtio_scsi(struct pci_device *pci) +init_virtio_scsi(void *data) { + struct pci_device *pci = data; dprintf(1, "found virtio-scsi at %pP\n", pci); struct vring_virtqueue *vq = NULL; struct vp_device *vp = malloc_high(sizeof(*vp)); @@ -199,6 +201,6 @@ virtio_scsi_setup(void) (pci->device != PCI_DEVICE_ID_VIRTIO_SCSI_09 && pci->device != PCI_DEVICE_ID_VIRTIO_SCSI_10)) continue; - init_virtio_scsi(pci); + run_thread(init_virtio_scsi, pci); } } -- 2.5.5

1 2

[PATCH 1/2] optionroms: Drop support for CONFIG_OPTIONROMS_DEPLOYED
by Kevin O'Connor 19 Apr '16

19 Apr '16

No modern software uses this option and it complicates the code. Signed-off-by: Kevin O'Connor <kevin(a)koconnor.net> --- src/Kconfig | 8 -------- src/fw/shadow.c | 15 +------------- src/optionroms.c | 61 ++++++++++++++++++++------------------------------------ 3 files changed, 23 insertions(+), 61 deletions(-) diff --git a/src/Kconfig b/src/Kconfig index de39b38..e767be1 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -395,14 +395,6 @@ menu "BIOS interfaces" default y help Support finding and running option roms during POST. - config OPTIONROMS_DEPLOYED - depends on OPTIONROMS && QEMU - bool "Option roms are already at 0xc0000-0xf0000" - default n - help - Select this if option ROMs are already copied to - 0xc0000-0xf0000. This must only be selected when using - Bochs or QEMU versions older than 0.12. config PMM depends on OPTIONROMS bool "PMM interface" diff --git a/src/fw/shadow.c b/src/fw/shadow.c index bdb5c5b..f766bb5 100644 --- a/src/fw/shadow.c +++ b/src/fw/shadow.c @@ -26,24 +26,11 @@ static void __make_bios_writable_intel(u16 bdf, u32 pam0) { // Make ram from 0xc0000-0xf0000 writable - int clear = 0; int i; for (i=0; i<6; i++) { u32 pam = pam0 + 1 + i; - int reg = pci_config_readb(bdf, pam); - if (CONFIG_OPTIONROMS_DEPLOYED && (reg & 0x11) != 0x11) { - // Need to copy optionroms to work around qemu implementation - void *mem = (void*)(BUILD_ROM_START + i * 32*1024); - memcpy((void*)BUILD_BIOS_TMP_ADDR, mem, 32*1024); - pci_config_writeb(bdf, pam, 0x33); - memcpy(mem, (void*)BUILD_BIOS_TMP_ADDR, 32*1024); - clear = 1; - } else { - pci_config_writeb(bdf, pam, 0x33); - } + pci_config_writeb(bdf, pam, 0x33); } - if (clear) - memset((void*)BUILD_BIOS_TMP_ADDR, 0, 32*1024); // Make ram from 0xf0000-0x100000 writable int reg = pci_config_readb(bdf, pam0); diff --git a/src/optionroms.c b/src/optionroms.c index 9897753..65f7fe0 100644 --- a/src/optionroms.c +++ b/src/optionroms.c @@ -347,28 +347,16 @@ optionrom_setup(void) memset(sources, 0, sizeof(sources)); u32 post_vga = rom_get_last(); - if (CONFIG_OPTIONROMS_DEPLOYED) { - // Option roms are already deployed on the system. - u32 pos = post_vga; - while (pos < rom_get_max()) { - int ret = init_optionrom((void*)pos, 0, 0); - if (ret) - pos += OPTION_ROM_ALIGN; - else - pos = rom_get_last(); - } - } else { - // Find and deploy PCI roms. - struct pci_device *pci; - foreachpci(pci) { - if (pci->class == PCI_CLASS_DISPLAY_VGA || pci->have_driver) - continue; - init_pcirom(pci, 0, sources); - } - - // Find and deploy CBFS roms not associated with a device. - run_file_roms("genroms/", 0, sources); + // Find and deploy PCI roms. + struct pci_device *pci; + foreachpci(pci) { + if (pci->class == PCI_CLASS_DISPLAY_VGA || pci->have_driver) + continue; + init_pcirom(pci, 0, sources); } + + // Find and deploy CBFS roms not associated with a device. + run_file_roms("genroms/", 0, sources); rom_reserve(0); // All option roms found and deployed - now build BEV/BCV vectors. @@ -427,26 +415,21 @@ vgarom_setup(void) RunPCIroms = romfile_loadint("etc/pci-optionrom-exec", 2); ScreenAndDebug = romfile_loadint("etc/screen-and-debug", 1); - if (CONFIG_OPTIONROMS_DEPLOYED) { - // Option roms are already deployed on the system. - init_optionrom((void*)BUILD_ROM_START, 0, 1); - } else { - // Clear option rom memory - memset((void*)BUILD_ROM_START, 0, rom_get_max() - BUILD_ROM_START); - - // Find and deploy PCI VGA rom. - struct pci_device *pci; - foreachpci(pci) { - if (!is_pci_vga(pci)) - continue; - vgahook_setup(pci); - init_pcirom(pci, 1, NULL); - break; - } + // Clear option rom memory + memset((void*)BUILD_ROM_START, 0, rom_get_max() - BUILD_ROM_START); - // Find and deploy CBFS vga-style roms not associated with a device. - run_file_roms("vgaroms/", 1, NULL); + // Find and deploy PCI VGA rom. + struct pci_device *pci; + foreachpci(pci) { + if (!is_pci_vga(pci)) + continue; + vgahook_setup(pci); + init_pcirom(pci, 1, NULL); + break; } + + // Find and deploy CBFS vga-style roms not associated with a device. + run_file_roms("vgaroms/", 1, NULL); rom_reserve(0); if (rom_get_last() == BUILD_ROM_START) -- 2.5.5

1 2

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SeaBIOS