SeaBIOS November 2015

seabios@seabios.org

19 participants
48 discussions

[PATCH 1/3] sdcard: Only enable error_irq_enable for bits defined in SDHCI v1 spec
by Kevin O'Connor 19 Nov '15

19 Nov '15

The SDHCI v1 spec only defines the first 9 error_irq_enable bits and reserves other bits in the field. Don't enable the 10th bit (which was defined in the v2 spec) as it's not needed anyway. Signed-off-by: Kevin O'Connor <kevin(a)koconnor.net> --- src/hw/sdcard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hw/sdcard.c b/src/hw/sdcard.c index be726d2..0617d24 100644 --- a/src/hw/sdcard.c +++ b/src/hw/sdcard.c @@ -493,7 +493,7 @@ sdcard_controller_setup(struct sdhci_s *regs, int prio) writew(&regs->irq_enable, 0x01ff); writew(&regs->irq_status, readw(&regs->irq_status)); writew(&regs->error_signal, 0); - writew(&regs->error_irq_enable, 0x03ff); + writew(&regs->error_irq_enable, 0x01ff); writew(&regs->error_irq_status, readw(&regs->error_irq_status)); writeb(&regs->timeout_control, 0x0e); // Set to max timeout int volt = sdcard_set_power(regs); -- 2.4.3

1 3

Build failed in Jenkins: seabios #198
by Jenkins Build Host 19 Nov '15

19 Nov '15

See <http://jenkins.xeni.kraxel.org:8080/job/seabios/198/changes> Changes: [kevin] usb: Allow configuration of sigatt time (in etc/usb-time-sigatt) [kevin] xhci: Check for device disconnects during USB2 reset polling [kevin] sdcard: Only enable error_irq_enable for bits defined in SDHCI v1 spec [kevin] sdcard: fix typo causing 32bit write to 16bit block_size field [kevin] sdcard: Enable extra debugging on sdcard_waitw() timeout [kevin] acpi_extract: Move main code to new function main() [kevin] acpi_extract: Make the generated .hex files more human readable [kevin] acpi_extract: Don't generate unused (and empty) q35-acpi-dsdt.hex file [kevin] acpi: Don't build SSDT files on every build; store them in git [kevin] acpi: Remove build check for iasl [kevin] tpm: Temporarily deactivate the TPM in case of failure [kevin] tpm: Refactor function building TPM commands [kevin] tpm: Refactor the parameters being passed to tpm_extend_acpi_log [kevin] tpm: Refactor hash_log_event BIOS interface function [kevin] tpm: Refactor hash_log_extend_event [kevin] tpm: fix compiler warning with older gcc versions ------------------------------------------ [...truncated 70 lines...] + cd <http://jenkins.xeni.kraxel.org:8080/job/seabios/ws/rpmbuild/rpm/BUILD> + rm -rf seabios.git + /usr/bin/xz -dc <http://jenkins.xeni.kraxel.org:8080/job/seabios/ws/rpmbuild/seabios.git-gdc…> + /usr/bin/tar -xf - + STATUS=0 + '[' 0 -ne 0 ']' + cd seabios.git + /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w . + exit 0 Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.PsDRHn + umask 022 + cd <http://jenkins.xeni.kraxel.org:8080/job/seabios/ws/rpmbuild/rpm/BUILD> + cd seabios.git + extra=-16.b198.gdc8eb67-git-snapshot-by-kraxel.org + echo 1.9.0 + mkdir rpm.bin + mkdir rpm.doc + do_build <http://jenkins.xeni.kraxel.org:8080/job/seabios/ws/rpmbuild/config.bios.qemu> out/bios.bin + local cfg=<http://jenkins.xeni.kraxel.org:8080/job/seabios/ws/rpmbuild/config.bios.qemu> + local target=out/bios.bin + make distclean scripts/kconfig/conf --olddefconfig <http://jenkins.xeni.kraxel.org:8080/job/seabios/ws/rpmbuild/rpm/BUILD/seabi…> # # configuration written to <http://jenkins.xeni.kraxel.org:8080/job/seabios/ws/rpmbuild/rpm/BUILD/seabi…> # + rm -rf out + cp <http://jenkins.xeni.kraxel.org:8080/job/seabios/ws/rpmbuild/config.bios.qemu> .config + yes '' + make oldconfig scripts/kconfig/conf --oldconfig <http://jenkins.xeni.kraxel.org:8080/job/seabios/ws/rpmbuild/rpm/BUILD/seabi…> * * Restart config... * * * General Features * Build Target 1. Build for coreboot (COREBOOT) (NEW) > 2. Build for QEMU/Xen/KVM/Bochs (QEMU) 3. Build as Compatibility Support Module for EFI BIOS (CSM) (NEW) choice[1-3]: Support Xen HVM (XEN) [N/y/?] n Parallelize hardware init (THREADS) [Y/n/?] (NEW) Copy init code to high memory (RELOCATE_INIT) [Y/n/?] (NEW) Bootmenu (BOOTMENU) [Y/n/?] (NEW) Graphical boot splash screen (BOOTSPLASH) [Y/n/?] (NEW) Boot ordering (BOOTORDER) [Y/n/?] (NEW) Use internal stack for 16bit interrupt entry points (ENTRY_EXTRASTACK) [Y/n/?] (NEW) Allocate memory that needs to be in first Meg above 0xc0000 (MALLOC_UPPERMEMORY) [Y/n/?] (NEW) ROM size (in KB) (ROM_SIZE) [128] 128 * * Hardware support * ATA controllers (ATA) [Y/n/?] (NEW) ATA DMA (ATA_DMA) [N/y/?] (NEW) ATA 32bit PIO (ATA_PIO32) [N/y/?] (NEW) AHCI controllers (AHCI) [Y/n/?] (NEW) SD controllers (SDCARD) [N/y/?] n virtio-blk controllers (VIRTIO_BLK) [Y/n/?] (NEW) virtio-scsi controllers (VIRTIO_SCSI) [Y/n/?] (NEW) PVSCSI controllers (PVSCSI) [Y/n/?] (NEW) AMD PCscsi controllers (ESP_SCSI) [Y/n/?] (NEW) lsi53c895a scsi controllers (LSI_SCSI) [Y/n/?] (NEW) LSI MegaRAID SAS controllers (MEGASAS) [Y/n/?] (NEW) Floppy controller (FLOPPY) [Y/n/?] (NEW) Floppy images from CBFS or fw_cfg (FLASH_FLOPPY) [Y/n/?] (NEW) PS/2 port (PS2PORT) [Y/n/?] (NEW) USB (USB) [Y/n/?] (NEW) USB UHCI controllers (USB_UHCI) [Y/n/?] (NEW) USB OHCI controllers (USB_OHCI) [N/y/?] n USB EHCI controllers (USB_EHCI) [Y/n/?] (NEW) USB XHCI controllers (USB_XHCI) [N/y/?] n USB drives (USB_MSC) [Y/n/?] (NEW) UAS drives (USB_UAS) [N/y/?] n USB hubs (USB_HUB) [Y/n/?] (NEW) USB keyboards (USB_KEYBOARD) [Y/n/?] (NEW) USB mice (USB_MOUSE) [Y/n/?] (NEW) Serial port (SERIAL) [Y/n/?] (NEW) Parallel port (LPT) [Y/n/?] (NEW) Real Time Clock (RTC) scheduling (RTC_TIMER) [Y/n/?] (NEW) Hardware interrupts (HARDWARE_IRQ) [Y/n/?] (NEW) System Management Mode (SMM) (USE_SMM) [Y/n/?] (NEW) Initialize MTRRs (MTRR_INIT) [Y/n/?] (NEW) Support ACPI timer (PMTIMER) [Y/n/?] (NEW) Support CPU timestamp counter as timer (TSC_TIMER) [Y/n/?] (NEW) * * BIOS interfaces * Drive interface (DRIVES) [Y/n/?] (NEW) DVD/CDROM booting (CDROM_BOOT) [Y/n/?] (NEW) DVD/CDROM boot drive emulation (CDROM_EMU) [Y/n/?] (NEW) PCIBIOS interface (PCIBIOS) [Y/n/?] (NEW) APM interface (APMBIOS) [Y/n/?] (NEW) PnP BIOS interface (PNPBIOS) [Y/n/?] (NEW) Option ROMS (OPTIONROMS) [Y/n/?] (NEW) Option roms are already at 0xc0000-0xf0000 (OPTIONROMS_DEPLOYED) [N/y/?] (NEW) PMM interface (PMM) [Y/n/?] (NEW) Boot interface (BOOT) [Y/n/?] (NEW) Keyboard interface (KEYBOARD) [Y/n/?] (NEW) Keyboard hook interface (KBD_CALL_INT15_4F) [Y/n/?] (NEW) Mouse interface (MOUSE) [Y/n/?] (NEW) S3 resume (S3_RESUME) [Y/n/?] (NEW) Hardware specific VGA helpers (VGAHOOKS) [Y/n/?] (NEW) Disable A20 (DISABLE_A20) [N/y/?] (NEW) Make unused UMB memory read/writeable. (WRITABLE_UPPERMEMORY) [N/y/?] (NEW) TPM support and TCG BIOS extensions (TCGBIOS) [N/y/?] n * * BIOS Tables * PIR table (PIRTABLE) [Y/n/?] (NEW) MPTable (MPTABLE) [Y/n/?] (NEW) SMBIOS (SMBIOS) [Y/n/?] (NEW) ACPI (ACPI) [Y/n/?] (NEW) Include default ACPI DSDT (ACPI_DSDT) [Y/n/?] (NEW) Load BIOS tables from ROM files (FW_ROMFILE_LOAD) [Y/n/?] (NEW) * * VGA ROM * VGA Hardware Type > 1. None (NO_VGABIOS) (NEW) 2. QEMU/Bochs Original IBM 256K VGA (VGA_STANDARD_VGA) (NEW) 3. QEMU/Bochs Cirrus SVGA (VGA_CIRRUS) (NEW) 4. QEMU/Bochs VBE SVGA (VGA_BOCHS) (NEW) 5. GeodeGX2 (VGA_GEODEGX2) (NEW) 6. GeodeLX (VGA_GEODELX) (NEW) choice[1-6]: * * Debugging * Debug level (DEBUG_LEVEL) [1] (NEW) Serial port debugging (DEBUG_SERIAL) [N/y/?] (NEW) Special IO port debugging (DEBUG_IO) [Y/n/?] (NEW) # # configuration written to <http://jenkins.xeni.kraxel.org:8080/job/seabios/ws/rpmbuild/rpm/BUILD/seabi…> # + make EXTRAVERSION=-16.b198.gdc8eb67-git-snapshot-by-kraxel.org Build Kconfig config file Compile checking out/src/misc.o Compile checking out/src/stacks.o Compile checking out/src/output.o Compile checking out/src/string.o Compile checking out/src/block.o Compile checking out/src/cdrom.o Compile checking out/src/disk.o Compile checking out/src/mouse.o Compile checking out/src/kbd.o Compile checking out/src/system.o Compile checking out/src/serial.o Compile checking out/src/clock.o Compile checking out/src/resume.o Compile checking out/src/pnpbios.o Compile checking out/src/vgahooks.o Compile checking out/src/pcibios.o Compile checking out/src/apm.o Compile checking out/src/hw/pci.o Compile checking out/src/hw/timer.o Compile checking out/src/hw/rtc.o Compile checking out/src/hw/dma.o Compile checking out/src/hw/pic.o Compile checking out/src/hw/ps2port.o Compile checking out/src/hw/serialio.o Compile checking out/src/hw/usb.o Compile checking out/src/hw/usb-uhci.o Compile checking out/src/hw/usb-ohci.o Compile checking out/src/hw/usb-ehci.o Compile checking out/src/hw/usb-hid.o Compile checking out/src/hw/usb-msc.o Compile checking out/src/hw/usb-uas.o Compile checking out/src/hw/blockcmd.o Compile checking out/src/hw/floppy.o Compile checking out/src/hw/ata.o Compile checking out/src/hw/ramdisk.o Compile checking out/src/hw/lsi-scsi.o Compile checking out/src/hw/esp-scsi.o Compile checking out/src/hw/megasas.o Compile checking out/src/post.o Compile checking out/src/e820map.o Compile checking out/src/malloc.o Compile checking out/src/romfile.o Compile checking out/src/x86.o Compile checking out/src/optionroms.o Compile checking out/src/pmm.o Compile checking out/src/font.o Compile checking out/src/boot.o Compile checking out/src/bootsplash.o Compile checking out/src/jpeg.o Compile checking out/src/bmp.o Compile checking out/src/tcgbios.o Compile checking out/src/sha1.o Compile checking out/src/hw/ahci.o Compile checking out/src/hw/pvscsi.o Compile checking out/src/hw/usb-xhci.o Compile checking out/src/hw/usb-hub.o Compile checking out/src/hw/sdcard.o Compile checking out/src/fw/coreboot.o Compile checking out/src/fw/lzmadecode.o Compile checking out/src/fw/multiboot.o Compile checking out/src/fw/csm.o Compile checking out/src/fw/biostables.o Compile checking out/src/fw/paravirt.o Compile checking out/src/fw/shadow.o Compile checking out/src/fw/pciinit.o Compile checking out/src/fw/smm.o Compile checking out/src/fw/smp.o Compile checking out/src/fw/mtrr.o Compile checking out/src/fw/xen.o Compile checking out/src/fw/acpi.o Compile checking out/src/fw/mptable.o Compile checking out/src/fw/pirtable.o Compile checking out/src/fw/smbios.o Compile checking out/src/fw/romfile_loader.o Compile checking out/src/hw/virtio-ring.o Compile checking out/src/hw/virtio-pci.o Compile checking out/src/hw/virtio-blk.o Compile checking out/src/hw/virtio-scsi.o Compile checking out/src/hw/tpm_drivers.o Compiling whole program out/ccode32flat.o Compiling whole program out/code32seg.o Compiling whole program out/ccode16.o Compiling to assembler out/src/asm-offsets.s Generating offset file out/asm-offsets.h Compiling (16bit) out/romlayout.o Building ld scripts Version: 1.9.0-16.b198.gdc8eb67-git-snapshot-by-kraxel.org Fixed space: 0xe05b-0x10000 total: 8101 slack: 9 Percent slack: 0.1% 16bit size: 33068 32bit segmented size: 2127 32bit flat size: 21941 32bit flat init size: 66208 Lowmem size: 2176 f-segment var size: 1200 Linking out/rom16.o Stripping out/rom16.strip.o Linking out/rom32seg.o Stripping out/rom32seg.strip.o Linking out/rom.o Prepping out/bios.bin.prep Total size: 130700 Fixed: 58336 Free: 372 (used 99.7% of 128KiB rom) Creating out/bios.bin + make EXTRAVERSION=-16.b198.gdc8eb67-git-snapshot-by-kraxel.org out/bios.bin make: `out/bios.bin' is up to date. + cp out/bios.bin rpm.bin/bios-qemu.bin + cp 'out/src/fw/*dsdt*.aml' rpm.bin/ cp: cannot stat 'out/src/fw/*dsdt*.aml': No such file or directory error: Bad exit status from /var/tmp/rpm-tmp.PsDRHn (%build) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.PsDRHn (%build) Build step 'Execute shell' marked build as failure Archiving artifacts

1 0

[PATCH] usb: Allow configuration of sigatt time (in etc/usb-time-sigatt)
by Kevin O'Connor 19 Nov '15

19 Nov '15

Several users have reported devices that take more than 100ms to announce their presence on a USB port. Allow the sigatt timeout to be specified at runtime as a way to extend the default timeout. Signed-off-by: Kevin O'Connor <kevin(a)koconnor.net> --- docs/Runtime_config.md | 1 + src/hw/usb.c | 6 +++++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/docs/Runtime_config.md b/docs/Runtime_config.md index d6fea28..483c375 100644 --- a/docs/Runtime_config.md +++ b/docs/Runtime_config.md @@ -189,3 +189,4 @@ There are several additional configuration options available in the | floppy1 | The type of the second floppy drive in the system. See the description of **floppy0** for more info. | threads | By default, SeaBIOS will parallelize hardware initialization during bootup to reduce boot time. Multiple hardware devices can be initialized in parallel between vga initialization and option rom initialization. One can set this file to a value of zero to force hardware initialization to run serially. Alternatively, one can set this file to 2 to enable early hardware initialization that runs in parallel with vga, option rom initialization, and the boot menu. | sdcard* | One may create one or more files with an "sdcard" prefix (eg, "etc/sdcard0") with the physical memory address of an SDHCI controller (one memory address per file). This may be useful for SDHCI controllers that do not appear as PCI devices, but are mapped to a consistent memory address. +| usb-time-sigatt | The USB2 specification requires devices to signal that they are attached within 100ms of the USB port being powered on. Some USB devices are known to require more time. Prior to receiving an attachment signal there is no way to know if a USB port is empty or if it has a device attached. One may specify an amount of time here (in milliseconds, default 100) to wait for a USB device attachment signal. Increasing this value will also increase the overall machine bootup time. diff --git a/src/hw/usb.c b/src/hw/usb.c index e46092c..2bffd25 100644 --- a/src/hw/usb.c +++ b/src/hw/usb.c @@ -8,6 +8,7 @@ #include "config.h" // CONFIG_* #include "malloc.h" // free #include "output.h" // dprintf +#include "romfile.h" // romfile_loadint #include "string.h" // memset #include "usb.h" // struct usb_s #include "usb-ehci.h" // ehci_setup @@ -455,12 +456,14 @@ resetfail: goto done; } +u32 usb_time_sigatt; + void usb_enumerate(struct usbhub_s *hub) { u32 portcount = hub->portcount; hub->threads = portcount; - hub->detectend = timer_calc(USB_TIME_SIGATT); + hub->detectend = timer_calc(usb_time_sigatt); // Launch a thread for every port. int i; @@ -497,5 +500,6 @@ usb_setup(void) ASSERT32FLAT(); if (! CONFIG_USB) return; + usb_time_sigatt = romfile_loadint("etc/usb-time-sigatt", USB_TIME_SIGATT); run_thread(__usb_setup, NULL); } -- 2.4.3

1 1

[PATCH 0/5] Improve TPM related code
by Stefan Berger 19 Nov '15

19 Nov '15

The first patch in this series introduces a function for better handling the error paths of functions where commands to the TPM do not work as expected. It temporairly disables the device. The other 4 patches refactor some of the code to get rid of local buffers and to make function easier to call. Some of the internal functions had to build up the same data structures as the BIOS interface expected, which was cumbersome. Regards, Stefan Stefan Berger (5): Temporarily deactivate the TPM in case of failure Refactor function building TPM commands Refactor the parameters being passed to tpm_extend_acpi_log Refactor hash_log_event BIOS interface function Refactor hash_log_extend_event src/tcgbios.c | 273 ++++++++++++++++++++++++++++++++++------------------------ src/tcgbios.h | 3 +- 2 files changed, 163 insertions(+), 113 deletions(-) -- 2.4.3

3 10

Re: [SeaBIOS] [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform
by Xulei (Stone) 19 Nov '15

19 Nov '15

Kevin, After deeply analyzing, i think there may be 3 possible reasons: 1)wrong CountCPUs value. It seems CountCPUs++ in handle_smp() has no lock to protect. So, sometimes, 2 or more vcpu may get the same current value of CountCPUs. Then we'll get a single incrementation instead of 2 or more and "while (cmos_smp_count != CountCPUs)" will loop forever; 2)wrong cmos_smp_count value. SeaBIOS rtc reads an incorrect number? 3)yield() stuck. Is it possible that SeaBIOS is stuck during yield? I've tested, when yield() is running, SeaBIOS seems has not created some other threads except the main thread. So I don't know what's the function of yield() here.? >Dear Kevin, > >Sorry for delayed replying. This patch works for me well. Thanks a lot! > >Recently, I found another odd thing. A qemu-kvm VM is stuck at the SeaBIOS >after self-rebooting many times. Analyzing the SeaBIOS log attached below, I >think there maybe someting wrong from this block of code: > >/src/fw/smp.c > > u8 cmos_smp_count = rtc_read(CMOS_BIOS_SMP_COUNT) + 1; > while (cmos_smp_count != CountCPUs) > asm volatile( > // Release lock and allow other processors to use the stack. > " movl %%esp, %1\n" > " movl $0, %0\n" > // Reacquire lock and take back ownership of stack. > "1:rep ; nop\n" > " lock btsl $0, %0\n" > " jc 1b\n" > : "+m" (SMPLock), "+m" (SMPStack) > : : "cc", "memory"); > yield(); > >It seems if SeaBIOS read an incorrect number sometimes from QEMU >through cmos 0x5f，the SeaBIOS really may be stucked. So, i wonder >what may cause this problem after a VM self-rebooting many times? > >================bad SeaBIOS log=========== >[2015-11-13 18:45:58] In resume (status=0) >[2015-11-13 18:45:58] In 32bit resume >[2015-11-13 18:45:58] Attempting a hard reboot >[2015-11-13 18:46:00] SeaBIOS (version rel-1.8.1-0-g4adadbd-20150316_085822-nilsson.home.kraxel.org) >[2015-11-13 18:46:00] No Xen hypervisor found. >[2015-11-13 18:46:00] Running on QEMU (i440fx) >[2015-11-13 18:46:00] Running on KVM >[2015-11-13 18:46:00] RamSize: 0xc0000000 [cmos] >[2015-11-13 18:46:00] Relocating init from 0x000de8f0 to 0xbffaec00 (size 70464) >[2015-11-13 18:46:00] Found QEMU fw_cfg >[2015-11-13 18:46:00] RamBlock: addr 0x0000000000000000 len 0x00000000c0000000 [e820] >[2015-11-13 18:46:00] RamBlock: addr 0x0000000100000000 len 0x0000000340000000 [e820] >[2015-11-13 18:46:00] Moving pm_base to 0x600 >[2015-11-13 18:46:00] boot order: >[2015-11-13 18:46:00] 1: /pci@i0cf8/scsi@e/disk@0,0 >[2015-11-13 18:46:00] 2: HALT >[2015-11-13 18:46:00] CPU Mhz=2402 >[2015-11-13 18:46:00] === PCI bus & bridge init === >[2015-11-13 18:46:00] PCI: pci_bios_init_bus_rec bus = 0x0 >[2015-11-13 18:46:00] === PCI device probing === >[2015-11-13 18:46:00] Found 21 PCI devices (max PCI bus is 00) >[2015-11-13 18:46:00] === PCI new allocation pass #1 === >[2015-11-13 18:46:00] PCI: check devices >[2015-11-13 18:46:00] === PCI new allocation pass #2 === >[2015-11-13 18:46:00] PCI: IO: c000 - c1cf >[2015-11-13 18:46:00] PCI: 32: 00000000c0000000 - 00000000fec00000 >[2015-11-13 18:46:00] PCI: map device bdf=00:1f.0 bar 0, addr 0000c000, size 00000100 [io] >[2015-11-13 18:46:00] PCI: map device bdf=00:0e.0 bar 0, addr 0000c100, size 00000040 [io] >[2015-11-13 18:46:00] PCI: map device bdf=00:0f.0 bar 0, addr 0000c140, size 00000040 [io] >[2015-11-13 18:46:00] PCI: map device bdf=00:01.2 bar 4, addr 0000c180, size 00000020 [io] >[2015-11-13 18:46:00] PCI: map device bdf=00:0d.0 bar 0, addr 0000c1a0, size 00000020 [io] >[2015-11-13 18:46:00] PCI: map device bdf=00:01.1 bar 4, addr 0000c1c0, size 00000010 [io] >[2015-11-13 18:46:00] PCI: map device bdf=00:02.0 bar 6, addr febe0000, size 00010000 [mem] >[2015-11-13 18:46:00] PCI: map device bdf=00:02.0 bar 1, addr febf0000, size 00001000 [mem] >[2015-11-13 18:46:00] PCI: map device bdf=00:0d.0 bar 1, addr febf1000, size 00001000 [mem] >[2015-11-13 18:46:00] PCI: map device bdf=00:0e.0 bar 1, addr febf2000, size 00001000 [mem] >[2015-11-13 18:46:00] PCI: map device bdf=00:0f.0 bar 1, addr febf3000, size 00001000 [mem] >[2015-11-13 18:46:00] PCI: map device bdf=00:10.0 bar 0, addr febf4000, size 00001000 [mem] >[2015-11-13 18:46:00] PCI: map device bdf=00:02.0 bar 0, addr f6000000, size 02000000 [prefmem] >[2015-11-13 18:46:00] PCI: map device bdf=00:10.0 bar 2, addr f8000000, size 01000000 [prefmem] >[2015-11-13 18:46:00] PCI: map device bdf=00:03.0 bar 2, addr f9000000, size 00800000 [prefmem] >[2015-11-13 18:46:00] PCI: map device bdf=00:04.0 bar 2, addr f9800000, size 00800000 [prefmem] >[2015-11-13 18:46:00] PCI: map device bdf=00:05.0 bar 2, addr fa000000, size 00800000 [prefmem] >[2015-11-13 18:46:00] PCI: map device bdf=00:06.0 bar 2, addr fa800000, size 00800000 [prefmem] >[2015-11-13 18:46:00] PCI: map device bdf=00:07.0 bar 2, addr fb000000, size 00800000 [prefmem] >[2015-11-13 18:46:00] PCI: map device bdf=00:08.0 bar 2, addr fb800000, size 00800000 [prefmem] >[2015-11-13 18:46:00] PCI: map device bdf=00:09.0 bar 2, addr fc000000, size 00800000 [prefmem] >[2015-11-13 18:46:00] PCI: map device bdf=00:0a.0 bar 2, addr fc800000, size 00800000 [prefmem] >[2015-11-13 18:46:00] PCI: map device bdf=00:0b.0 bar 2, addr fd000000, size 00800000 [prefmem] >[2015-11-13 18:46:00] PCI: map device bdf=00:0c.0 bar 2, addr fd800000, size 00800000 [prefmem] >[2015-11-13 18:46:00] PCI: init bdf=00:00.0 id=8086:1237 >[2015-11-13 18:46:00] PCI: init bdf=00:01.0 id=8086:7000 >[2015-11-13 18:46:00] PIIX3/PIIX4 init: elcr=00 0c >[2015-11-13 18:46:00] PCI: init bdf=00:01.1 id=8086:7010 >[2015-11-13 18:46:00] PCI: init bdf=00:01.2 id=8086:7020 >[2015-11-13 18:46:00] PCI: init bdf=00:01.3 id=8086:7113 >[2015-11-13 18:46:00] Using pmtimer, ioport 0x608 >[2015-11-13 18:46:00] PCI: init bdf=00:02.0 id=1013:00b8 >[2015-11-13 18:46:00] PCI: init bdf=00:03.0 id=15b3:1004 >[2015-11-13 18:46:00] PCI: init bdf=00:04.0 id=15b3:1004 >[2015-11-13 18:46:00] PCI: init bdf=00:05.0 id=15b3:1004 >[2015-11-13 18:46:00] PCI: init bdf=00:06.0 id=15b3:1004 >[2015-11-13 18:46:00] PCI: init bdf=00:07.0 id=15b3:1004 >[2015-11-13 18:46:00] PCI: init bdf=00:08.0 id=15b3:1004 >[2015-11-13 18:46:00] PCI: init bdf=00:09.0 id=15b3:1004 >[2015-11-13 18:46:00] PCI: init bdf=00:0a.0 id=15b3:1004 >[2015-11-13 18:46:00] PCI: init bdf=00:0b.0 id=15b3:1004 >[2015-11-13 18:46:00] PCI: init bdf=00:0c.0 id=15b3:1004 >[2015-11-13 18:46:00] PCI: init bdf=00:0d.0 id=1af4:1003 >[2015-11-13 18:46:00] PCI: init bdf=00:0e.0 id=1af4:1001 >[2015-11-13 18:46:00] PCI: init bdf=00:0f.0 id=1af4:1001 >[2015-11-13 18:46:00] PCI: init bdf=00:10.0 id=1af4:1110 >[2015-11-13 18:46:00] PCI: init bdf=00:1f.0 id=1af4:8888 >[2015-11-13 18:46:00] PCI: Using 00:02.0 for primary VGA >[2015-11-13 18:46:00] handle_smp: apic_id=1 >[2015-11-13 18:46:00] handle_smp: apic_id=6 >[2015-11-13 18:46:00] handle_smp: apic_id=7 >[2015-11-13 18:46:00] handle_smp: apic_id=3 >[2015-11-13 18:46:00] handle_smp: apic_id=2 >[2015-11-13 18:46:00] handle_smp: apic_id=5 >[2015-11-13 18:46:00] handle_smp: apic_id=4 >========The End, nothing more====== >>On Mon, Nov 09, 2015 at 03:06:18PM -0500, Kevin O'Connor wrote: >>> On Mon, Nov 09, 2015 at 08:32:53AM -0500, Kevin O'Connor wrote: >>> > On Fri, Nov 06, 2015 at 09:12:34AM +0000, Xulei (Stone) wrote: >>> > > >On Wed, Nov 04, 2015 at 08:48:20AM +0800, Gonglei wrote: >>> > > >I'm surprised you would see the above on a recent qemu/kvm though - as >>> > > >on a newer KVM I think the second reset would have to happen after >>> > > >HaveAttemptedReboot is set and prior to the memcpy in >>> > > >qemu_prep_reset() completing. Can you verify your KVM version? >>> > > >>> > > I've tested on KVM-3.6 and KVM-4.1.3. On both of these versions, i can >>> > > see this problem. >>> > > I do like this: put a HA and a watchdog mechanism in a VM. Deliberately, >>> > > let this VM lose heartbeat and don't feed dog. Then, after 2 minutes, >>> > > a self-defined timeout, HA mechnism will issue a internal reboot command to >>> > > the VM and watchdog mechanism will issue a "virsh reset" from the host. Then, >>> > > aforementioned problem will occurs in high probability. >>> > >>> > Ah, okay. I'm not sure what the best solution to this problem is. >>> >>> After thinking about this further, I think we can move the >>> HaveAttemptedReboot assignment after the memcpy. >> >>The previous patch could cause corruption if the memcpy() failed. I >>think the new SeaBIOS patch below should be okay though. >> >>-Kevin >> >> >>commit 8a6e44ad5c953266d2339b3299f5fb4ff32c8cbb >>Author: Kevin O'Connor <kevin(a)koconnor.net> >>Date: Mon Nov 9 15:00:19 2015 -0500 >> >> resume: Make KVM soft reboot loop detection more flexible >> >> Move the check for soft reboot loops from resume.c to shadow.c and >> directly check for the case where the memcpy fails. This prevents a >> hang if an external reboot request occurs during the BIOS memcpy. >> >> Signed-off-by: Kevin O'Connor <kevin(a)koconnor.net> >> >>diff --git a/src/fw/shadow.c b/src/fw/shadow.c >>index ee87d36..b2f2dd8 100644 >>--- a/src/fw/shadow.c >>+++ b/src/fw/shadow.c >>@@ -156,6 +156,8 @@ make_bios_readonly(void) >> make_bios_readonly_intel(ShadowBDF, Q35_HOST_BRIDGE_PAM0); >> } >> >>+static u8 AttemptingReboot; >>+ >> void >> qemu_prep_reset(void) >> { >>@@ -164,6 +166,19 @@ qemu_prep_reset(void) >> // QEMU doesn't map 0xc0000-0xfffff back to the original rom on a >> // reset, so do that manually before invoking a hard reset. >> make_bios_writable(); >>+ AttemptingReboot = 1; >>+ barrier(); >>+ if (!AttemptingReboot) >>+ goto fail; >>+ barrier(); >> memcpy(VSYMBOL(code32flat_start), VSYMBOL(code32flat_start) + BIOS_SRC_OFFSET >> , SYMBOL(code32flat_end) - SYMBOL(code32flat_start)); >>+ barrier(); >>+ if (AttemptingReboot) >>+ goto fail; >>+ return; >>+fail: >>+ // Attempt to restore code has failed - try to shutdown machine. >>+ dprintf(1, "Unable to hard-reboot machine - attempting shutdown.\n"); >>+ apm_shutdown(); >> } >>diff --git a/src/resume.c b/src/resume.c >>index a5465d8..afeadcf 100644 >>--- a/src/resume.c >>+++ b/src/resume.c >>@@ -114,19 +114,10 @@ s3_resume(void) >> farcall16big(&br); >> } >> >>-u8 HaveAttemptedReboot VARLOW; >>- >> // Attempt to invoke a hard-reboot. >> static void >> tryReboot(void) >> { >>- if (HaveAttemptedReboot) { >>- // Hard reboot has failed - try to shutdown machine. >>- dprintf(1, "Unable to hard-reboot machine - attempting shutdown.\n"); >>- apm_shutdown(); >>- } >>- HaveAttemptedReboot = 1; >>- >> dprintf(1, "Attempting a hard reboot\n"); >> >> // Setup for reset on qemu.

1 0

Re: [SeaBIOS] [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform
by Kevin O'Connor 19 Nov '15

19 Nov '15

On Fri, Nov 06, 2015 at 09:12:34AM +0000, Xulei (Stone) wrote: > > >On Wed, Nov 04, 2015 at 08:48:20AM +0800, Gonglei wrote: > >> On 2015/11/3 14:58, Xulei (Stone, Euler) wrote: > >> > On qemu-kvm platform, when I reset a VM through "virsh reset", and coincidently > >> > the VM is in process of internal rebooting at the same time. Then the VM will > >> > not be successfully reseted any more due to the reset reentrancy. I found: > >> > (1)SeaBios try to shutdown the VM after reseting it failed by apm_shutdown(). > >> > However, apm_shutdown() does not work on qemu-kvm platform; > >> > (2)I add 1s sleep in qemu_prep_reset(), then continuously reset the VM twice, > >> > aforementioned case must happen. > > > >So, the problem occurs when issuing a second reset before the first > >reset completes? > > Yes. Detailedly, the 2nd reset issued after "HaveAttemptedReboot = 1" > and prior to the memcpy completing in qemu_prep_reset(). > > >> > This patch fixes this issue by letting the VM always execute the reboot > >> > routing while a reenrancy happenes instead of attempting apm_shutdown on > >> > qemu-kvm platform. > > > >The reason for the HaveAttemptedReboot check is to work around old > >versions of KVM that unexpectedly map the same memory to both 0xf0000 > >and 0xffff0000. So, it does not make sense to wrap the check in a > >!runningOnKVM() block as that disables the only reason for the check. > > > >I'm surprised you would see the above on a recent qemu/kvm though - as > >on a newer KVM I think the second reset would have to happen after > >HaveAttemptedReboot is set and prior to the memcpy in > >qemu_prep_reset() completing. Can you verify your KVM version? > > > >-Kevin > > I've tested on KVM-3.6 and KVM-4.1.3. On both of these versions, i can > see this problem. > I do like this: put a HA and a watchdog mechanism in a VM. Deliberately, > let this VM lose heartbeat and don't feed dog. Then, after 2 minutes, > a self-defined timeout, HA mechnism will issue a internal reboot command to > the VM and watchdog mechanism will issue a "virsh reset" from the host. Then, > aforementioned problem will occurs in high probability. Ah, okay. I'm not sure what the best solution to this problem is. We don't want to exclude KVM because the check is meant to prevent an infinite loop on older versions of KVM (which looks like a mysterious hang to users). We also don't want to be in a situation where we reboot and the memcpy hasn't fully completed, as that's likely to lead to mysterious crashes on the next boot. -Kevin

2 3

[ANNOUNCE] SeaBIOS 1.9.0
by Kevin O'Connor 18 Nov '15

18 Nov '15

The 1.9.0 version of SeaBIOS has now been released. For more information on the release, please see: http://seabios.org/Releases New in this release: * The default boot menu key is now the ESC key (instead of F12) * Initial support for Trusted Platform Module (TPM) hardware and BIOS calls * Initial support for chain loading SeaBIOS from Grub (via multiboot support) * Initial support for booting from SD cards on real hardware * virtio 1.0 device support * The build will no longer include the build hostname or build time on "clean" builds. This makes the build binaries more "reproducible". * Basic support for running SeaBIOS on Baytrail Chromebooks * SeaVGABIOS improvements: * Improved support for old versions of x86emu (the "leal" instruction is now emulated) * Several bug fixes and code cleanups For information on obtaining SeaBIOS, please see: http://seabios.org/Download ===== git shortlog -n rel-1.8.0..rel-1.9.0 ===== Kevin O'Connor (126): docs: add page for SeaVGABIOS docs: Add page describing the patch contribution process docs: Add page on available CBFS/fw_cfg runtime config files docs: Prefer triple backticks to multiple lines with single backticks smp: Fix smp race introduced in 0673b787 docs: Note release date of 1.8.1 vgabios: On bda_save_restore() the saved vbe_mode also has flags in it vgabios: Don't use extra stack if it appears a modern OS is in use docs: Clarify that pci-optionrom-exec doesn't apply to roms in cbfs checkstack: Replace function information tuple with class checkstack: Simplify yield calculations checkstack: Prefer passing "function" class instead of function address smbios: Use integer signature instead of string signature vgabios: Don't use "smsww" instruction - it confuses x86emu vgabios: Add config option for assembler fixups vgabios: Emulate "leal" instruction checkstack: Minor - continue if not a regular asm line Don't forward declare functions with "inline" in headers build: Support "make VERSION=xyz" to override the default build version tcg: Use seabios setup()/prepboot() calling convention for tcg build: CONFIG_VGA_FIXUP_ASM should depend on CONFIG_BUILD_VGABIOS bootorder: Update "extra pci root" buses bootorder format to match qemu Make sure all code checks for malloc failures docs: Note release date of 1.8.2 block: Split process_op() command dispatch up into multiple functions block: Introduce default_process_op() with common command handling codes block: Route scsi style commands through 'struct disk_op_s' blockcmd: Introduce scsi_fill_cmd() ata: Handle ATA ATAPI drives directly via 'struct disk_op_s' requests ahci: Handle AHCI ATAPI drives directly via 'struct disk_op_s' requests usb-msc: Handle USB drives directly via 'struct disk_op_s' requests usb-uas: Handle USB drives directly via 'struct disk_op_s' requests lsi-scsi: Handle LSI drives directly via 'struct disk_op_s' requests esp-scsi: Handle ESP drives directly via 'struct disk_op_s' requests megasas: Handle Megasas drives directly via 'struct disk_op_s' requests virtio-scsi: Handle virtio drives directly via 'struct disk_op_s' requests pvscsi: Move pvscsi_fill_req() code into pvscsi_cmd() pvscsi: Handle pvscsi drives directly via 'struct disk_op_s' requests blockcmd: Remove unused scsi_process_op() and cdb_cmd_data() blockcmd: Convert cdb_is_read() to scsi_is_read() block: Rename process_XXX_op() functions to XXX_process_op() coreboot: Try to auto-detect if the CBFS anchor pointer is a relative pointer ps2: Support mode for polling the PS2 port instead of using irqs ata: Make sure "chanid" is relative to PCI device for bootorder file Don't enable interrupts prior to IVT and PIC setup ps2: Don't wait 100ms to discard possible extra reset receive byte timer: Delay timestamp counter init until after pmtimer is probed timer: Add CONFIG_TSC_TIMER build option to disable the CPU TSC timer ramdisk: Allow ramdisk support (CONFIG_FLASH_FLOPPY) under QEMU Minor - move declaration of CDRom_locks to code that uses it smm: ignore bits 16,18-31 of SMM revision ID at runtime too vgafb: Minor - move gfx_common() variables outside of switch statement sdcard: Check if card is present before sending commands to card sdcard: Implement controller frequency setting according to sdhci spec sdcard: Make sure controller support 3.3V before enabling it sdcard: Set timeout control register during init (to max allowed timeout) sdcard: Improve SD card initialization command sequence sdcard: Add proper delays during card power up mptable: Don't create mptable if it is very large optionroms: Don't run option rom on PCI bar if CBFS/fw_cfg version exists edd: Pass the segment/offset from int 1348 calls using a 'struct segoff_s' edd: Reduce parameters to fill_generic_edd() Move CanInterrupt check to check_irqs() Call cpu_relax() if yielding prior to interrupts being enabled sdcard: Fix typo - use sdcard_pio() instead of sdcard_pio_app() sdcard: Fill command bits according to spec sdcard: Support SDHCI v3.00 spec clock setting sdcard: Move power setup to new function sdcard_set_power() sdcard: Power controller up to maximum voltage supported sdcard: Power down controller on failure sdcard: The card should never be in a busy state at start of sdcard_pio() sdcard: Implement timeout on every block read in sdcard_pio_transfer() sdcard: Rename waitw() to sdcard_waitw() and simplify sdcard: Perform a controller reset at start of init sdcard: Check for error events during sdcard_pio() sdcard: Initial support for MMC cards sdcard: Allow the sdcard driver to run on real hardware rtc: Support disabling the RTC timer irq support Add minimal support for machines without hardware interrupts ps2: Eliminate "etc/ps2-poll-only"; use CONFIG_HARDWARE_IRQ instead sdcard: Allow sdcard addresses to be specified in CBFS files xhci: Minor - add USB port type comments to xhci_hub_reset() docs: Don't use an add-symbol-file offset when describing gdb debugging rtc: Disable NMI in rtc_mask() sdcard: Move sdcard_set_frequency()/sdcard_set_power() in sdcard.c sdcard: Move frequency setting into sdcard_card_setup() sdcard: Move drive registration to sdcard_card_setup() sdcard: Turn card_type into a bitmap and store if card is MMC type sdcard: Display sdcard product name in boot menu sdcard: Obtain card capacity and report it on the boot menu megasas: Use outl() on MFI_IDB register minor - correct spelling error in comment Simplify transition16/32 assembler code docs: Minor - add "code relocation" link to "Execution and code flow" document Unify smm/sloppy variants of call32_prep/post and call16_helper Rename Call32Data to Call16Data Unify inline assembler in variants of call16 functions Unify call32_sloppy() and call32() Use transition32_nmi_off from call32() and call16_back() Consolidate code16*() functions Always enable caching on transition32; backup/restore cr0 on call32 e820: Introduce e820_remove() and avoid exporting E820_HOLE e820: Rename memmap.c to e820map.c and use consistent "e820_" prefix e820: Update debugging messages to report 64bit values virtio: Simplify vring alignment code virtio: Move standard definitions from virtio-ring.h to standard headers malloc: Use consistent naming for internal low-level "alloc" functions malloc: Introduce common helper alloc_new_detail() malloc: Add warning if free() called on invalid memory malloc: Don't mix virtual and physical addresses memmap: Introduce SYMBOL() macro to access linker script symbols build: Rework version generation; don't allow make version override build: Report gcc and binutils versions in debug log build: Generate "reproducible" version strings on "clean" builds stacks: Use macro wrappers for call32() and stack_hop_back() malloc: Rename csm_malloc_preinit() to malloc_csm_preinit() build: Be more permissive in buildversion.py tool version scan docs: Document 'make EXTRAVERSION=xyz' and scripts/tarball.sh build: Allow official tarball builds to be considered "clean" coreboot: Minor - avoid K&R style function declaration biostables: Minor - fix incorrect indentation virtio: Minor - replace tab characters with space docs: Minor - replace seavgabios text in Build_overview.md with link buildversion: Avoid subprocess.check_output() as that requires python2.7 buildversion: Add debugging messages docs: Note v1.9.0 release Gerd Hoffmann (28): vga: simplify vga builds vga: rework virtio-vga support vga: add virtio-vga to kconfig pci: allow to loop over capabilities virtio: run drivers in 32bit mode virtio: add struct vp_device virtio: pass struct pci_device to vp_init_simple virtio: add version 1.0 structs and #defines virtio: add version 0.9.5 struct virtio: find version 1.0 virtio capabilities virtio: create vp_cap struct for legacy bar virtio: add read/write functions and macros virtio: make features 64bit, support version 1.0 features virtio: add version 1.0 support to vp_{get,set}_status virtio: add version 1.0 support to vp_get_isr virtio: add version 1.0 support to vp_reset virtio: add version 1.0 support to vp_notify virtio: remove unused vp_del_vq virtio: add version 1.0 support to vp_find_vq virtio-scsi: fix initialization for version 1.0 virtio-blk: fix initialization for version 1.0 virtio: use version 1.0 if available (flip the big switch) virtio: also probe version 1.0 pci ids virtio: legacy cleanup virtio-blk: 32bit cleanup virtio-scsi: 32bit cleanup virtio-ring: 32bit cleanup virtio-pci: use high memory for rings Stefan Berger (9): Add an implementation of a TPM TIS driver Implementation of the TCG BIOS extensions Support for BIOS interrupt handler Add 'measurement' code to the BIOS tpm: Introduce a #define for command tag tpm: Be consistent with array sizes in tcgbios.c tpm: clean up parameters to build_and_send_cmd tpm: Clean up in tcgbios.h tpm: Move call to tpm_option_rom into init_optionrom Paolo Bonzini (4): boot.c: delay exiting boot if menu key is ESC boot: switch default menu key to ESC smm: ignore bits 16,18-31 of SMM revision ID smm: fix outl argument order Vladimir Serbinenko (3): ahci: Ignore max_ports. Link rom.o with -N option. Add multiboot support. Marcel Apfelbaum (2): fw/pci: scan all buses if extraroots romfile is present fw/pci: map memory and IO regions for multiple pci root buses Stefan Weil (2): megasas: Fix outw, outl argument order Fix typos found by codespell Ameya Palande (1): x86: add barrier to read{b,w,l} and write{b,w,l} functions Andreas Färber (1): checkrom: Fix typo in error message Chen Fan (1): pci: enable SERR# for error forwarding in bridge control register Julius Werner (1): xhci: Count new Max Scratchpad Bufs bits from XHCI 1.1 Kyösti Mälkki (1): PCI SDHCI driver: Fix base address Magnus Granberg (1): build: use -fstack-check=no when available Marc Marí (1): Add QEMU fw_cfg DMA interface Paulo Alcantara (1): ich9: initialise RCBA register through LPC interface Quan Xu (1): make SeaBios compatible with Xen vTPM. tpearson(a)raptorengineeringinc.com (1): Add an option to only execute option ROMs contained in CBFS

2 1

[PATCH] tpm: fix compiler error with older gcc versions
by Stefan Berger 17 Nov '15

17 Nov '15

gcc v3.4 shows a warning due to "comparison is always false due to limited range of data type". This patch fixes it. Signed-off-by: Stefan Berger <stefanb(a)linux.vnet.ibm.com> --- src/hw/tpm_drivers.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hw/tpm_drivers.h b/src/hw/tpm_drivers.h index 34bb12d..48c6615 100644 --- a/src/hw/tpm_drivers.h +++ b/src/hw/tpm_drivers.h @@ -34,7 +34,7 @@ extern struct tpm_driver tpm_drivers[]; #define TIS_DRIVER_IDX 0 #define TPM_NUM_DRIVERS 1 -#define TPM_INVALID_DRIVER -1 +#define TPM_INVALID_DRIVER 0xf /* TIS driver */ /* address of locality 0 (TIS) */ -- 2.4.3

1 0

Issues with AHCI and AMD SB700
by Paul Menzel 12 Nov '15

12 Nov '15

Dear SeaBIOS folks, Timothy Pearson submitted the change below [1] to the coreboot repository. ``` ommit 14ebf951e41c085aa2f8420fcf7452dc5761514e Author: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Date: Sun Jun 21 16:27:03 2015 -0500 src/southbridge/amd/sb700: Reset SATA controller in AHCI mode during startup In AHCI mode SeaBIOS randomly fails to detect disks (AHCI timeouts), with the probability of a failure increasing with the number of disks connected to the controller. Resetting the SATA controller appears to show the true state of the underlying hardware, allowing the drive detection code to attempt link renegotiation as needed. Change-Id: Ib1f7c5f830a0cdba41cb6f5b05d759adee5ce369 Signed-off-by: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Reviewed-on: http://review.coreboot.org/11998 Tested-by: Raptor Engineering Automated Test Stand <noreply(a)raptorengineeringinc.com> Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Tested-by: build bot (Jenkins) diff --git a/src/southbridge/amd/sb700/sata.c b/src/southbridge/amd/sb700/sata.c index ae44446..63c07d8 100644 --- a/src/southbridge/amd/sb700/sata.c +++ b/src/southbridge/amd/sb700/sata.c @@ -131,6 +131,8 @@ static void sata_init(struct device *dev) /* get rev_id */ rev_id = pci_read_config8(sm_dev, 0x08) - 0x28; + printk(BIOS_SPEW, "rev_id=%x\n", rev_id); + if (sata_ahci_mode) { /* Enable link latency enhancement on A14 and above */ if (rev_id >= 0x14) { @@ -241,6 +243,27 @@ static void sata_init(struct device *dev) write32(sata_bar5 + 0xfc, dword); } + if (sata_ahci_mode) { + /* FIXME + * SeaBIOS does not know how to spin + * up the drives and therefore hangs + * in AHCI init if this is enabled... + */ + /* Enable staggered spin-up */ + dword = read32(sata_bar5 + 0x00); +#if 0 + dword |= 0x1 << 27; +#else + dword &= ~(0x1 << 27); +#endif + write32(sata_bar5 + 0x00, dword); + + /* Reset the HBA to avoid stuck drives in SeaBIOS */ + dword = read32(sata_bar5 + 0x04); + dword |= 0x1; + write32(sata_bar5 + 0x04, dword); + } + /* Write protect Sub-Class Code */ byte = pci_read_config8(dev, 0x40); byte &= ~(1 << 0); @@ -367,21 +390,21 @@ static void sata_init(struct device *dev) } /* Below is CIM InitSataLateFar */ - /* Enable interrupts from the HBA */ - byte = read8(sata_bar5 + 0x4); - byte |= 1 << 1; - write8((sata_bar5 + 0x4), byte); - if (!sata_ahci_mode) { - /* Clear error status */ - write32((sata_bar5 + 0x130), 0xFFFFFFFF); - write32((sata_bar5 + 0x1b0), 0xFFFFFFFF); - write32((sata_bar5 + 0x230), 0xFFFFFFFF); - write32((sata_bar5 + 0x2b0), 0xFFFFFFFF); - write32((sata_bar5 + 0x330), 0xFFFFFFFF); - write32((sata_bar5 + 0x3b0), 0xFFFFFFFF); + /* Enable interrupts from the HBA */ + byte = read8(sata_bar5 + 0x4); + byte |= 1 << 1; + write8((sata_bar5 + 0x4), byte); } + /* Clear error status */ + write32((sata_bar5 + 0x130), 0xFFFFFFFF); + write32((sata_bar5 + 0x1b0), 0xFFFFFFFF); + write32((sata_bar5 + 0x230), 0xFFFFFFFF); + write32((sata_bar5 + 0x2b0), 0xFFFFFFFF); + write32((sata_bar5 + 0x330), 0xFFFFFFFF); + write32((sata_bar5 + 0x3b0), 0xFFFFFFFF); + /* Clear SATA status,Firstly we get the AcpiGpe0BlkAddr */ /* ????? why CIM does not set the AcpiGpe0BlkAddr , but use it??? */ /* ????? why CIM does not set the AcpiGpe0BlkAddr , but use it??? */ ``` Do you know if there is a fix for SeaBIOS or is this a hardware issue? Thanks, Paul [1] http://review.coreboot.org/11998

1 0

[PATCH] buildversion: Avoid subprocess.check_output() as that requires python2.7
by Kevin O'Connor 11 Nov '15

11 Nov '15

Don't require python2.7 in buildversion.py. Also, ignore only those exceptions that are known to be possible. Signed-off-by: Kevin O'Connor <kevin(a)koconnor.net> --- scripts/buildversion.py | 30 +++++++++++++++++------------- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/scripts/buildversion.py b/scripts/buildversion.py index d61fc9e..5b8807e 100755 --- a/scripts/buildversion.py +++ b/scripts/buildversion.py @@ -4,7 +4,7 @@ # Copyright (C) 2015 Kevin O'Connor <kevin(a)koconnor.net> # # This file may be distributed under the terms of the GNU GPLv3 license. -import sys, os, subprocess, time, socket, optparse +import sys, os, subprocess, shlex, time, socket, optparse VERSION_FORMAT = """ /* DO NOT EDIT! This is an autogenerated file. See scripts/buildversion.py. */ @@ -12,16 +12,24 @@ VERSION_FORMAT = """ #define BUILD_TOOLS "%s" """ +# Run program and return the specified output +def check_output(prog): + try: + process = subprocess.Popen(shlex.split(prog), stdout=subprocess.PIPE) + output = process.communicate()[0] + retcode = process.poll() + except OSError: + return "" + try: + return output.decode() + except UnicodeError: + return "" + # Obtain version info from "git" program def git_version(): if not os.path.exists('.git'): return "" - params = "git describe --tags --long --dirty".split() - try: - ver = subprocess.check_output(params).decode().strip() - except: - return "" - return ver + return check_output("git describe --tags --long --dirty").strip() # Look for version in a ".version" file. Official release tarballs # have this file (see scripts/tarball.sh). @@ -32,7 +40,7 @@ def file_version(): f = open('.version', 'r') ver = f.readline().strip() f.close() - except: + except OSError: return "" return ver @@ -50,11 +58,7 @@ def tool_versions(tools): success = 0 for tool in tools: # Extract first line from "tool --version" output - try: - ver = subprocess.check_output([tool, '--version']).decode() - except: - continue - verstr = ver.split('\n')[0] + verstr = check_output("%s --version" % (tool,)).split('\n')[0] # Check if this tool looks like a binutils program isbinutils = 0 if verstr.startswith('GNU '): -- 2.4.3

3 5

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SeaBIOS November 2015