SeaBIOS November 2015

seabios@seabios.org

19 participants
48 discussions

Questions on SeaBIOS TPM
by Kevin O'Connor 20 Nov '15

20 Nov '15

Hi Stefan, I've been reading through the tcgbios and tpm_drivers code in SeaBIOS. I have a couple of questions: Why does the driver sometimes use tpm_sha1_calc() and sometimes use sha1()? It seems the software sha1 implementation is always superior, so why bothering implementing the hardware version? (The spec seems to agree with this as well.) It seems like dropping tpm_sha1_calc() would simplify the code. What is SCALAR in tpm_drivers() for - it seems like all the timeouts in the spec are increased by 10? Also, it seems like tpm_drivers.c uses durations and timeouts in milliseconds, while tcgbios.c:determine_timeouts() uses values in microseconds. I don't understand the error handling in tpm_extend_acpi_log() and tpm_extend(). Why does a log overflow in tpm_extend_acpi_log() shutdown the tpm chip (via tpm_set_failure() )? In particular, tpm_extend_acpi_log can be called from clients via the 16bit BIOS interface, and it's the only way a client could cause the tpm chip to shutdown. Why does tpm_extend() call reset_acpi_log() on failure? It seems odd that a failure in communication with the TPM chip would result in an ACPI log reset - no other TPM chip failure does that. Is it expected that the tcpa ACPI table could move or be modified at runtime? The code rescans for the table twice on every call to tpm_extend_acpi_log() - if it can't move or be modified then I think it would be simpler to cache the values. -Kevin

2 1

Jenkins build is back to normal : seabios #201
by Jenkins Build Host 20 Nov '15

20 Nov '15

See <http://jenkins.xeni.kraxel.org:8080/job/seabios/201/>

1 0

Build failed in Jenkins: seabios #200
by Jenkins Build Host 20 Nov '15

20 Nov '15

See <http://jenkins.xeni.kraxel.org:8080/job/seabios/200/> ------------------------------------------ [...truncated 76 lines...] + /usr/bin/xz -dc <http://jenkins.xeni.kraxel.org:8080/job/seabios/ws/rpmbuild/seabios.git-gdc…> + /usr/bin/tar -xf - + STATUS=0 + '[' 0 -ne 0 ']' + cd seabios.git + /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w . + exit 0 Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.B02ILE + umask 022 + cd <http://jenkins.xeni.kraxel.org:8080/job/seabios/ws/rpmbuild/rpm/BUILD> + cd seabios.git + extra=-16.b200.gdc8eb67-git-snapshot-by-kraxel.org + echo 1.9.0 + mkdir rpm.bin + mkdir rpm.doc + do_build <http://jenkins.xeni.kraxel.org:8080/job/seabios/ws/rpmbuild/config.bios.qemu> out/bios.bin + local cfg=<http://jenkins.xeni.kraxel.org:8080/job/seabios/ws/rpmbuild/config.bios.qemu> + local target=out/bios.bin + make distclean scripts/kconfig/conf --olddefconfig <http://jenkins.xeni.kraxel.org:8080/job/seabios/ws/rpmbuild/rpm/BUILD/seabi…> # # configuration written to <http://jenkins.xeni.kraxel.org:8080/job/seabios/ws/rpmbuild/rpm/BUILD/seabi…> # + rm -rf out + cp <http://jenkins.xeni.kraxel.org:8080/job/seabios/ws/rpmbuild/config.bios.qemu> .config + yes '' + make oldconfig scripts/kconfig/conf --oldconfig <http://jenkins.xeni.kraxel.org:8080/job/seabios/ws/rpmbuild/rpm/BUILD/seabi…> * * Restart config... * * * General Features * Build Target 1. Build for coreboot (COREBOOT) (NEW) > 2. Build for QEMU/Xen/KVM/Bochs (QEMU) 3. Build as Compatibility Support Module for EFI BIOS (CSM) (NEW) choice[1-3]: Support Xen HVM (XEN) [N/y/?] n Parallelize hardware init (THREADS) [Y/n/?] (NEW) Copy init code to high memory (RELOCATE_INIT) [Y/n/?] (NEW) Bootmenu (BOOTMENU) [Y/n/?] (NEW) Graphical boot splash screen (BOOTSPLASH) [Y/n/?] (NEW) Boot ordering (BOOTORDER) [Y/n/?] (NEW) Use internal stack for 16bit interrupt entry points (ENTRY_EXTRASTACK) [Y/n/?] (NEW) Allocate memory that needs to be in first Meg above 0xc0000 (MALLOC_UPPERMEMORY) [Y/n/?] (NEW) ROM size (in KB) (ROM_SIZE) [128] 128 * * Hardware support * ATA controllers (ATA) [Y/n/?] (NEW) ATA DMA (ATA_DMA) [N/y/?] (NEW) ATA 32bit PIO (ATA_PIO32) [N/y/?] (NEW) AHCI controllers (AHCI) [Y/n/?] (NEW) SD controllers (SDCARD) [N/y/?] n virtio-blk controllers (VIRTIO_BLK) [Y/n/?] (NEW) virtio-scsi controllers (VIRTIO_SCSI) [Y/n/?] (NEW) PVSCSI controllers (PVSCSI) [Y/n/?] (NEW) AMD PCscsi controllers (ESP_SCSI) [Y/n/?] (NEW) lsi53c895a scsi controllers (LSI_SCSI) [Y/n/?] (NEW) LSI MegaRAID SAS controllers (MEGASAS) [Y/n/?] (NEW) Floppy controller (FLOPPY) [Y/n/?] (NEW) Floppy images from CBFS or fw_cfg (FLASH_FLOPPY) [Y/n/?] (NEW) PS/2 port (PS2PORT) [Y/n/?] (NEW) USB (USB) [Y/n/?] (NEW) USB UHCI controllers (USB_UHCI) [Y/n/?] (NEW) USB OHCI controllers (USB_OHCI) [N/y/?] n USB EHCI controllers (USB_EHCI) [Y/n/?] (NEW) USB XHCI controllers (USB_XHCI) [N/y/?] n USB drives (USB_MSC) [Y/n/?] (NEW) UAS drives (USB_UAS) [N/y/?] n USB hubs (USB_HUB) [Y/n/?] (NEW) USB keyboards (USB_KEYBOARD) [Y/n/?] (NEW) USB mice (USB_MOUSE) [Y/n/?] (NEW) Serial port (SERIAL) [Y/n/?] (NEW) Parallel port (LPT) [Y/n/?] (NEW) Real Time Clock (RTC) scheduling (RTC_TIMER) [Y/n/?] (NEW) Hardware interrupts (HARDWARE_IRQ) [Y/n/?] (NEW) System Management Mode (SMM) (USE_SMM) [Y/n/?] (NEW) Initialize MTRRs (MTRR_INIT) [Y/n/?] (NEW) Support ACPI timer (PMTIMER) [Y/n/?] (NEW) Support CPU timestamp counter as timer (TSC_TIMER) [Y/n/?] (NEW) * * BIOS interfaces * Drive interface (DRIVES) [Y/n/?] (NEW) DVD/CDROM booting (CDROM_BOOT) [Y/n/?] (NEW) DVD/CDROM boot drive emulation (CDROM_EMU) [Y/n/?] (NEW) PCIBIOS interface (PCIBIOS) [Y/n/?] (NEW) APM interface (APMBIOS) [Y/n/?] (NEW) PnP BIOS interface (PNPBIOS) [Y/n/?] (NEW) Option ROMS (OPTIONROMS) [Y/n/?] (NEW) Option roms are already at 0xc0000-0xf0000 (OPTIONROMS_DEPLOYED) [N/y/?] (NEW) PMM interface (PMM) [Y/n/?] (NEW) Boot interface (BOOT) [Y/n/?] (NEW) Keyboard interface (KEYBOARD) [Y/n/?] (NEW) Keyboard hook interface (KBD_CALL_INT15_4F) [Y/n/?] (NEW) Mouse interface (MOUSE) [Y/n/?] (NEW) S3 resume (S3_RESUME) [Y/n/?] (NEW) Hardware specific VGA helpers (VGAHOOKS) [Y/n/?] (NEW) Disable A20 (DISABLE_A20) [N/y/?] (NEW) Make unused UMB memory read/writeable. (WRITABLE_UPPERMEMORY) [N/y/?] (NEW) TPM support and TCG BIOS extensions (TCGBIOS) [N/y/?] n * * BIOS Tables * PIR table (PIRTABLE) [Y/n/?] (NEW) MPTable (MPTABLE) [Y/n/?] (NEW) SMBIOS (SMBIOS) [Y/n/?] (NEW) ACPI (ACPI) [Y/n/?] (NEW) Include default ACPI DSDT (ACPI_DSDT) [Y/n/?] (NEW) Load BIOS tables from ROM files (FW_ROMFILE_LOAD) [Y/n/?] (NEW) * * VGA ROM * VGA Hardware Type > 1. None (NO_VGABIOS) (NEW) 2. QEMU/Bochs Original IBM 256K VGA (VGA_STANDARD_VGA) (NEW) 3. QEMU/Bochs Cirrus SVGA (VGA_CIRRUS) (NEW) 4. QEMU/Bochs VBE SVGA (VGA_BOCHS) (NEW) 5. GeodeGX2 (VGA_GEODEGX2) (NEW) 6. GeodeLX (VGA_GEODELX) (NEW) choice[1-6]: * * Debugging * Debug level (DEBUG_LEVEL) [1] (NEW) Serial port debugging (DEBUG_SERIAL) [N/y/?] (NEW) Special IO port debugging (DEBUG_IO) [Y/n/?] (NEW) # # configuration written to <http://jenkins.xeni.kraxel.org:8080/job/seabios/ws/rpmbuild/rpm/BUILD/seabi…> # + make EXTRAVERSION=-16.b200.gdc8eb67-git-snapshot-by-kraxel.org Build Kconfig config file Compile checking out/src/misc.o Compile checking out/src/stacks.o Compile checking out/src/output.o Compile checking out/src/string.o Compile checking out/src/block.o Compile checking out/src/cdrom.o Compile checking out/src/disk.o Compile checking out/src/mouse.o Compile checking out/src/kbd.o Compile checking out/src/system.o Compile checking out/src/serial.o Compile checking out/src/clock.o Compile checking out/src/resume.o Compile checking out/src/pnpbios.o Compile checking out/src/vgahooks.o Compile checking out/src/pcibios.o Compile checking out/src/apm.o Compile checking out/src/hw/pci.o Compile checking out/src/hw/timer.o Compile checking out/src/hw/rtc.o Compile checking out/src/hw/dma.o Compile checking out/src/hw/pic.o Compile checking out/src/hw/ps2port.o Compile checking out/src/hw/serialio.o Compile checking out/src/hw/usb.o Compile checking out/src/hw/usb-uhci.o Compile checking out/src/hw/usb-ohci.o Compile checking out/src/hw/usb-ehci.o Compile checking out/src/hw/usb-hid.o Compile checking out/src/hw/usb-msc.o Compile checking out/src/hw/usb-uas.o Compile checking out/src/hw/blockcmd.o Compile checking out/src/hw/floppy.o Compile checking out/src/hw/ata.o Compile checking out/src/hw/ramdisk.o Compile checking out/src/hw/lsi-scsi.o Compile checking out/src/hw/esp-scsi.o Compile checking out/src/hw/megasas.o Compile checking out/src/post.o Compile checking out/src/e820map.o Compile checking out/src/malloc.o Compile checking out/src/romfile.o Compile checking out/src/x86.o Compile checking out/src/optionroms.o Compile checking out/src/pmm.o Compile checking out/src/font.o Compile checking out/src/boot.o Compile checking out/src/bootsplash.o Compile checking out/src/jpeg.o Compile checking out/src/bmp.o Compile checking out/src/tcgbios.o Compile checking out/src/sha1.o Compile checking out/src/hw/ahci.o Compile checking out/src/hw/pvscsi.o Compile checking out/src/hw/usb-xhci.o Compile checking out/src/hw/usb-hub.o Compile checking out/src/hw/sdcard.o Compile checking out/src/fw/coreboot.o Compile checking out/src/fw/lzmadecode.o Compile checking out/src/fw/multiboot.o Compile checking out/src/fw/csm.o Compile checking out/src/fw/biostables.o Compile checking out/src/fw/paravirt.o Compile checking out/src/fw/shadow.o Compile checking out/src/fw/pciinit.o Compile checking out/src/fw/smm.o Compile checking out/src/fw/smp.o Compile checking out/src/fw/mtrr.o Compile checking out/src/fw/xen.o Compile checking out/src/fw/acpi.o Compile checking out/src/fw/mptable.o Compile checking out/src/fw/pirtable.o Compile checking out/src/fw/smbios.o Compile checking out/src/fw/romfile_loader.o Compile checking out/src/hw/virtio-ring.o Compile checking out/src/hw/virtio-pci.o Compile checking out/src/hw/virtio-blk.o Compile checking out/src/hw/virtio-scsi.o Compile checking out/src/hw/tpm_drivers.o Compiling whole program out/ccode32flat.o Compiling whole program out/code32seg.o Compiling whole program out/ccode16.o Compiling to assembler out/src/asm-offsets.s Generating offset file out/asm-offsets.h Compiling (16bit) out/romlayout.o Building ld scripts Version: 1.9.0-16.b200.gdc8eb67-git-snapshot-by-kraxel.org Fixed space: 0xe05b-0x10000 total: 8101 slack: 9 Percent slack: 0.1% 16bit size: 33068 32bit segmented size: 2127 32bit flat size: 21941 32bit flat init size: 66208 Lowmem size: 2176 f-segment var size: 1200 Linking out/rom16.o Stripping out/rom16.strip.o Linking out/rom32seg.o Stripping out/rom32seg.strip.o Linking out/rom.o Prepping out/bios.bin.prep Total size: 130700 Fixed: 58336 Free: 372 (used 99.7% of 128KiB rom) Creating out/bios.bin + make EXTRAVERSION=-16.b200.gdc8eb67-git-snapshot-by-kraxel.org iasl make: Nothing to be done for `iasl'. + make EXTRAVERSION=-16.b200.gdc8eb67-git-snapshot-by-kraxel.org out/bios.bin make: `out/bios.bin' is up to date. + cp out/bios.bin rpm.bin/bios-qemu.bin + cp 'out/src/fw/*dsdt*.aml' rpm.bin/ cp: cannot stat 'out/src/fw/*dsdt*.aml': No such file or directory error: Bad exit status from /var/tmp/rpm-tmp.B02ILE (%build) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.B02ILE (%build) Build step 'Execute shell' marked build as failure Archiving artifacts

1 0

Re: [SeaBIOS] [PATCH] tpm: Move standard definitions from tcgbios.h to new file std/tcg.h
by Kevin O'Connor 20 Nov '15

20 Nov '15

On Thu, Nov 19, 2015 at 07:44:27PM -0500, Stefan Berger wrote: > "Kevin O'Connor" <kevin(a)koconnor.net> wrote on 11/19/2015 07:07:27 PM: > > From: "Kevin O'Connor" <kevin(a)koconnor.net> > > On Thu, Nov 19, 2015 at 06:33:59PM -0500, Stefan Berger wrote: > > > Let me know how to proceed on the menu part. Do you agree with the > last > > > code I had posted module the fact that once we leave the menu you want > the > > > machine to be reset? It is not necessary to do that, but we can do it. > > > > From a TPM perspective machine resets are only necessary when certain > TPM > > > state changes are done. > > > > It's been a while since I last looked at that. My only real concern > > is minimizing the impact to the non-tpm seabios code. I'd prefer not > > to change the main SeaBIOS boot prompt, and adding loops (or loops via > > Though adding an additional boot *menu item* is ok? Yes. > > gotos) to the boot menu code seems strange to me. Outside of that, I > > Once the user selects the TPM submenu and then leaves it, what should > happen? If we reset the machine, we wouldn't need to add a loop because > there is no way to go back to the main menu. Otherwise getting back into > the previous menu seem 'normal'. I don't understand what you are asking. It seems to me selecting the TPM config from the boot menu could be considered "booting into the TPM configuration" instead of selecting the "TPM submenu". When treated as "booting into the TPM configuration" then at the completion of configuration the next natural step would be to reboot. This is similar to how a traditional BIOS handles its "BIOS setup menu" - the machine reboots upon exiting the setup menu. I'm sure there are other ways to do this, but it does seem strange to me to restructure the boot menu for something that I understand is going to be very infrequently accessed. -Kevin

1 0

Re: [SeaBIOS] [PATCH] tpm: Move standard definitions from tcgbios.h to new file std/tcg.h
by Kevin O'Connor 20 Nov '15

20 Nov '15

On Thu, Nov 19, 2015 at 06:33:59PM -0500, Stefan Berger wrote: > Let me know how to proceed on the menu part. Do you agree with the last > code I had posted module the fact that once we leave the menu you want the > machine to be reset? It is not necessary to do that, but we can do it. > From a TPM perspective machine resets are only necessary when certain TPM > state changes are done. It's been a while since I last looked at that. My only real concern is minimizing the impact to the non-tpm seabios code. I'd prefer not to change the main SeaBIOS boot prompt, and adding loops (or loops via gotos) to the boot menu code seems strange to me. Outside of that, I don't have a preference on whether TPM resets the machine or not. -Kevin

2 1

Re: [SeaBIOS] [PATCH] tpm: Move standard definitions from tcgbios.h to new file std/tcg.h
by Kevin O'Connor 20 Nov '15

20 Nov '15

On Thu, Nov 19, 2015 at 08:00:27PM +0000, Stefan Berger wrote: > "Kevin O'Connor" <kevin(a)koconnor.net> wrote on 11/19/2015 09:33:09 AM: > > > > > Signed-off-by: Kevin O'Connor <kevin(a)koconnor.net> > > Tested-by: Stefan Berger <stefanb(a)us.ibm.com> Thanks. It looks like I inadvertently moved "enum ipltype" from tcgbios.h to std/tcg.h . I moved it back in my local copy. -Kevin

2 1

[PATCH] tpm: Move standard definitions from tcgbios.h to new file std/tcg.h
by Kevin O'Connor 19 Nov '15

19 Nov '15

Signed-off-by: Kevin O'Connor <kevin(a)koconnor.net> --- The tcgbios.h file is pretty big - it would be great if we could separate out the SeaBIOS specific parts from the definitions that are part of the standard. --- src/hw/tpm_drivers.c | 4 +- src/{tcgbios.h => std/tcg.h} | 29 +--- src/tcgbios.c | 20 ++- src/tcgbios.h | 351 ------------------------------------------- 4 files changed, 14 insertions(+), 390 deletions(-) copy src/{tcgbios.h => std/tcg.h} (93%) diff --git a/src/hw/tpm_drivers.c b/src/hw/tpm_drivers.c index 444eac3..b5cde00 100644 --- a/src/hw/tpm_drivers.c +++ b/src/hw/tpm_drivers.c @@ -8,11 +8,11 @@ // This file may be distributed under the terms of the GNU LGPLv3 license. #include "config.h" // CONFIG_TPM_TIS_SHA1THRESHOLD +#include "hw/tpm_drivers.h" // struct tpm_driver +#include "std/tcg.h" // TCG_NO_RESPONSE #include "string.h" // memcpy #include "util.h" // msleep #include "x86.h" // readl -#include "hw/tpm_drivers.h" // struct tpm_driver -#include "tcgbios.h" // TCG_* static const u32 tis_default_timeouts[4] = { TIS_DEFAULT_TIMEOUT_A, diff --git a/src/tcgbios.h b/src/std/tcg.h similarity index 93% copy from src/tcgbios.h copy to src/std/tcg.h index 2b0b65d..464d494 100644 --- a/src/tcgbios.h +++ b/src/std/tcg.h @@ -1,5 +1,5 @@ -#ifndef TCGBIOS_H -#define TCGBIOS_H +#ifndef STD_TCG_H +#define STD_TCG_H #include "types.h" @@ -99,19 +99,8 @@ enum irq_ids { #define EV_IPL 13 #define EV_IPL_PARTITION_DATA 14 - -#define STATUS_FLAG_SHUTDOWN (1 << 0) - #define SHA1_BUFSIZE 20 - -struct iovec -{ - size_t length; - const void *data; -}; - - /* Input and Output blocks for the TCG BIOS commands */ struct hleei_short @@ -361,16 +350,4 @@ enum ipltype { IPL_EL_TORITO_2 }; - -struct bregs; -void tpm_interrupt_handler32(struct bregs *regs); - -void tpm_setup(void); -void tpm_prepboot(void); -void tpm_s3_resume(void); -u32 tpm_add_bcv(u32 bootdrv, const u8 *addr, u32 length); -u32 tpm_add_cdrom(u32 bootdrv, const u8 *addr, u32 length); -u32 tpm_add_cdrom_catalog(const u8 *addr, u32 length); -u32 tpm_option_rom(const void *addr, u32 len); - -#endif /* TCGBIOS_H */ +#endif // tcg.h diff --git a/src/tcgbios.c b/src/tcgbios.c index c4e3b5e..9ae075a 100644 --- a/src/tcgbios.c +++ b/src/tcgbios.c @@ -9,22 +9,20 @@ // // This file may be distributed under the terms of the GNU LGPLv3 license. - -#include "config.h" - -#include "types.h" +#include "bregs.h" // struct bregs #include "byteorder.h" // cpu_to_* -#include "hw/tpm_drivers.h" // tpm_drivers[] +#include "config.h" // CONFIG_TCGBIOS #include "farptr.h" // MAKE_FLATPTR +#include "fw/paravirt.h" // runningOnXen +#include "hw/tpm_drivers.h" // tpm_drivers[] +#include "output.h" // dprintf +#include "sha1.h" // sha1 +#include "std/acpi.h" // RSDP_SIGNATURE, rsdt_descriptor +#include "std/smbios.h" // struct smbios_entry_point +#include "std/tcg.h" // TCG_PC_LOGOVERFLOW #include "string.h" // checksum #include "tcgbios.h"// tpm_*, prototypes #include "util.h" // printf, get_keystroke -#include "output.h" // dprintf -#include "std/acpi.h" // RSDP_SIGNATURE, rsdt_descriptor -#include "bregs.h" // struct bregs -#include "sha1.h" // sha1 -#include "fw/paravirt.h" // runningOnXen -#include "std/smbios.h" static const u8 Startup_ST_CLEAR[] = { 0x00, TPM_ST_CLEAR }; static const u8 Startup_ST_STATE[] = { 0x00, TPM_ST_STATE }; diff --git a/src/tcgbios.h b/src/tcgbios.h index 2b0b65d..0f9d5c3 100644 --- a/src/tcgbios.h +++ b/src/tcgbios.h @@ -3,365 +3,14 @@ #include "types.h" -/* Define for section 12.3 */ -#define TCG_PC_OK 0x0 -#define TCG_PC_TPMERROR 0x1 -#define TCG_PC_LOGOVERFLOW 0x2 -#define TCG_PC_UNSUPPORTED 0x3 - -#define TPM_ALG_SHA 0x4 - -#define TCG_MAGIC 0x41504354L -#define TCG_VERSION_MAJOR 1 -#define TCG_VERSION_MINOR 2 - -#define TPM_OK 0x0 -#define TPM_RET_BASE 0x1 -#define TCG_GENERAL_ERROR (TPM_RET_BASE + 0x0) -#define TCG_TPM_IS_LOCKED (TPM_RET_BASE + 0x1) -#define TCG_NO_RESPONSE (TPM_RET_BASE + 0x2) -#define TCG_INVALID_RESPONSE (TPM_RET_BASE + 0x3) -#define TCG_INVALID_ACCESS_REQUEST (TPM_RET_BASE + 0x4) -#define TCG_FIRMWARE_ERROR (TPM_RET_BASE + 0x5) -#define TCG_INTEGRITY_CHECK_FAILED (TPM_RET_BASE + 0x6) -#define TCG_INVALID_DEVICE_ID (TPM_RET_BASE + 0x7) -#define TCG_INVALID_VENDOR_ID (TPM_RET_BASE + 0x8) -#define TCG_UNABLE_TO_OPEN (TPM_RET_BASE + 0x9) -#define TCG_UNABLE_TO_CLOSE (TPM_RET_BASE + 0xa) -#define TCG_RESPONSE_TIMEOUT (TPM_RET_BASE + 0xb) -#define TCG_INVALID_COM_REQUEST (TPM_RET_BASE + 0xc) -#define TCG_INVALID_ADR_REQUEST (TPM_RET_BASE + 0xd) -#define TCG_WRITE_BYTE_ERROR (TPM_RET_BASE + 0xe) -#define TCG_READ_BYTE_ERROR (TPM_RET_BASE + 0xf) -#define TCG_BLOCK_WRITE_TIMEOUT (TPM_RET_BASE + 0x10) -#define TCG_CHAR_WRITE_TIMEOUT (TPM_RET_BASE + 0x11) -#define TCG_CHAR_READ_TIMEOUT (TPM_RET_BASE + 0x12) -#define TCG_BLOCK_READ_TIMEOUT (TPM_RET_BASE + 0x13) -#define TCG_TRANSFER_ABORT (TPM_RET_BASE + 0x14) -#define TCG_INVALID_DRV_FUNCTION (TPM_RET_BASE + 0x15) -#define TCG_OUTPUT_BUFFER_TOO_SHORT (TPM_RET_BASE + 0x16) -#define TCG_FATAL_COM_ERROR (TPM_RET_BASE + 0x17) -#define TCG_INVALID_INPUT_PARA (TPM_RET_BASE + 0x18) -#define TCG_TCG_COMMAND_ERROR (TPM_RET_BASE + 0x19) -#define TCG_INTERFACE_SHUTDOWN (TPM_RET_BASE + 0x20) -//define TCG_PC_UNSUPPORTED (TPM_RET_BASE + 0x21) -#define TCG_PC_TPM_NOT_PRESENT (TPM_RET_BASE + 0x22) -#define TCG_PC_TPM_DEACTIVATED (TPM_RET_BASE + 0x23) - - -#define TPM_ORD_SelfTestFull 0x00000050 -#define TPM_ORD_ForceClear 0x0000005d -#define TPM_ORD_GetCapability 0x00000065 -#define TPM_ORD_PhysicalEnable 0x0000006f -#define TPM_ORD_PhysicalDisable 0x00000070 -#define TPM_ORD_SetOwnerInstall 0x00000071 -#define TPM_ORD_PhysicalSetDeactivated 0x00000072 -#define TPM_ORD_SetTempDeactivated 0x00000073 -#define TPM_ORD_Startup 0x00000099 -#define TPM_ORD_PhysicalPresence 0x4000000a -#define TPM_ORD_Extend 0x00000014 -#define TPM_ORD_SHA1Start 0x000000a0 -#define TPM_ORD_SHA1Update 0x000000a1 -#define TPM_ORD_SHA1Complete 0x000000a2 -#define TSC_ORD_ResetEstablishmentBit 0x4000000b - - -#define TPM_ST_CLEAR 0x1 -#define TPM_ST_STATE 0x2 -#define TPM_ST_DEACTIVATED 0x3 - - -/* TPM command error codes */ -#define TPM_INVALID_POSTINIT 0x26 -#define TPM_BAD_LOCALITY 0x3d - -/* TPM command tags */ -#define TPM_TAG_RQU_CMD 0x00c1 - -/* interrupt identifiers (al register) */ -enum irq_ids { - TCG_StatusCheck = 0, - TCG_HashLogExtendEvent = 1, - TCG_PassThroughToTPM = 2, - TCG_ShutdownPreBootInterface = 3, - TCG_HashLogEvent = 4, - TCG_HashAll = 5, - TCG_TSS = 6, - TCG_CompactHashLogExtendEvent = 7, -}; - -/* event types: 10.4.1 / table 11 */ -#define EV_POST_CODE 1 -#define EV_SEPARATOR 4 -#define EV_ACTION 5 -#define EV_EVENT_TAG 6 -#define EV_COMPACT_HASH 12 -#define EV_IPL 13 -#define EV_IPL_PARTITION_DATA 14 - - #define STATUS_FLAG_SHUTDOWN (1 << 0) -#define SHA1_BUFSIZE 20 - - struct iovec { size_t length; const void *data; }; - -/* Input and Output blocks for the TCG BIOS commands */ - -struct hleei_short -{ - u16 ipblength; - u16 reserved; - const void *hashdataptr; - u32 hashdatalen; - u32 pcrindex; - const void *logdataptr; - u32 logdatalen; -} PACKED; - - -struct hleei_long -{ - u16 ipblength; - u16 reserved; - void *hashdataptr; - u32 hashdatalen; - u32 pcrindex; - u32 reserved2; - void *logdataptr; - u32 logdatalen; -} PACKED; - - -struct hleeo -{ - u16 opblength; - u16 reserved; - u32 eventnumber; - u8 digest[SHA1_BUFSIZE]; -} PACKED; - - -struct pttti -{ - u16 ipblength; - u16 reserved; - u16 opblength; - u16 reserved2; - u8 tpmopin[0]; -} PACKED; - - -struct pttto -{ - u16 opblength; - u16 reserved; - u8 tpmopout[0]; -}; - - -struct hlei -{ - u16 ipblength; - u16 reserved; - const void *hashdataptr; - u32 hashdatalen; - u32 pcrindex; - u32 logeventtype; - const void *logdataptr; - u32 logdatalen; -} PACKED; - - -struct hleo -{ - u16 opblength; - u16 reserved; - u32 eventnumber; -} PACKED; - - -struct hai -{ - u16 ipblength; - u16 reserved; - const void *hashdataptr; - u32 hashdatalen; - u32 algorithmid; -} PACKED; - - -struct ti -{ - u16 ipblength; - u16 reserved; - u16 opblength; - u16 reserved2; - u8 tssoperandin[0]; -} PACKED; - - -struct to -{ - u16 opblength; - u16 reserved; - u8 tssoperandout[0]; -} PACKED; - - -struct pcpes -{ - u32 pcrindex; - u32 eventtype; - u8 digest[SHA1_BUFSIZE]; - u32 eventdatasize; - u32 event; -} PACKED; - -struct pcctes -{ - u32 eventid; - u32 eventdatasize; - u8 digest[SHA1_BUFSIZE]; -} PACKED; - -struct pcctes_romex -{ - u32 eventid; - u32 eventdatasize; - u16 reserved; - u16 pfa; - u8 digest[SHA1_BUFSIZE]; -} PACKED; - - -#define TPM_REQ_HEADER \ - u16 tag; \ - u32 totlen; \ - u32 ordinal; - -#define TPM_REQ_HEADER_SIZE (sizeof(u16) + sizeof(u32) + sizeof(u32)) - -#define TPM_RSP_HEADER \ - u16 tag; \ - u32 totlen; \ - u32 errcode; - -#define TPM_RSP_HEADER_SIZE (sizeof(u16) + sizeof(u32) + sizeof(u32)) - -struct tpm_req_header { - TPM_REQ_HEADER; -} PACKED; - - -struct tpm_rsp_header { - TPM_RSP_HEADER; -} PACKED; - - -struct tpm_req_extend { - TPM_REQ_HEADER - u32 pcrindex; - u8 digest[SHA1_BUFSIZE]; -} PACKED; - - -struct tpm_rsp_extend { - TPM_RSP_HEADER - u8 digest[SHA1_BUFSIZE]; -} PACKED; - - -struct tpm_req_getcap_perm_flags { - TPM_REQ_HEADER - u32 capArea; - u32 subCapSize; - u32 subCap; -} PACKED; - - -struct tpm_permanent_flags { - u16 tag; - u8 flags[20]; -} PACKED; - - -enum permFlagsIndex { - PERM_FLAG_IDX_DISABLE = 0, - PERM_FLAG_IDX_OWNERSHIP, - PERM_FLAG_IDX_DEACTIVATED, - PERM_FLAG_IDX_READPUBEK, - PERM_FLAG_IDX_DISABLEOWNERCLEAR, - PERM_FLAG_IDX_ALLOW_MAINTENANCE, - PERM_FLAG_IDX_PHYSICAL_PRESENCE_LIFETIME_LOCK, - PERM_FLAG_IDX_PHYSICAL_PRESENCE_HW_ENABLE, -}; - - -struct tpm_res_getcap_perm_flags { - TPM_RSP_HEADER - u32 size; - struct tpm_permanent_flags perm_flags; -} PACKED; - - -struct tpm_res_getcap_ownerauth { - TPM_RSP_HEADER - u32 size; - u8 flag; -} PACKED; - - -struct tpm_res_getcap_timeouts { - TPM_RSP_HEADER - u32 size; - u32 timeouts[4]; -} PACKED; - - -struct tpm_res_getcap_durations { - TPM_RSP_HEADER - u32 size; - u32 durations[3]; -} PACKED; - - -struct tpm_res_sha1start { - TPM_RSP_HEADER - u32 max_num_bytes; -} PACKED; - - -struct tpm_res_sha1complete { - TPM_RSP_HEADER - u8 hash[20]; -} PACKED; - -struct pttti_extend { - struct pttti pttti; - struct tpm_req_extend req; -} PACKED; - - -struct pttto_extend { - struct pttto pttto; - struct tpm_rsp_extend rsp; -} PACKED; - - -enum ipltype { - IPL_BCV = 0, - IPL_EL_TORITO_1, - IPL_EL_TORITO_2 -}; - - struct bregs; void tpm_interrupt_handler32(struct bregs *regs); -- 2.4.3

2 1

Re: [SeaBIOS] Build failed in Jenkins: seabios #198
by Kevin O'Connor 19 Nov '15

19 Nov '15

On Thu, Nov 19, 2015 at 02:59:43PM +0100, Jenkins Build Host wrote: > See <http://jenkins.xeni.kraxel.org:8080/job/seabios/198/changes> > > Changes: [...] > [kevin] acpi: Don't build SSDT files on every build; store them in git > [...] > Total size: 130700 Fixed: 58336 Free: 372 (used 99.7% of 128KiB rom) > Creating out/bios.bin > + make EXTRAVERSION=-16.b198.gdc8eb67-git-snapshot-by-kraxel.org out/bios.bin > make: `out/bios.bin' is up to date. > + cp out/bios.bin rpm.bin/bios-qemu.bin > + cp 'out/src/fw/*dsdt*.aml' rpm.bin/ > cp: cannot stat 'out/src/fw/*dsdt*.aml': No such file or directory > error: Bad exit status from /var/tmp/rpm-tmp.PsDRHn (%build) Looks like the rpm build has a dependency on the acpi-dsdt.aml and q35-acpi-dsdt.aml files. I'd prefer not to require iasl for every seabios build. We could create a new makefile target (eg, make aml) and then update the rpm to call both "make" and "make aml". Thoughts? -Kevin

2 4

Jenkins build is back to normal : seabios #199
by Jenkins Build Host 19 Nov '15

19 Nov '15

See <http://jenkins.xeni.kraxel.org:8080/job/seabios/199/>

1 0

[PATCH 0/5] Do not require iasl for SeaBIOS builds
by Kevin O'Connor 19 Nov '15

19 Nov '15

It's been over 2 years since the last meaningful change to the DSDT files in the SeaBIOS repo. (And that's with good cause, as the content is now only used by old QEMU machine types and it should be static.) It does not make sense to require iasl on every build to generate these files. Instead, it's simpler to just commit the four generated files into the code repo. -Kevin Kevin O'Connor (5): acpi_extract: Move main code to new function main() acpi_extract: Make the generated .hex files more human readable acpi_extract: Don't generate unused (and empty) q35-acpi-dsdt.hex file acpi: Don't build SSDT files on every build; store them in git acpi: Remove build check for iasl Makefile | 4 +- scripts/acpi_extract.py | 232 ++++++++++---------- scripts/test-build.sh | 13 -- src/fw/acpi-dsdt.hex | 554 ++++++++++++++++++++++++++++++++++++++++++++++++ src/fw/acpi.c | 8 +- src/fw/ssdt-misc.hex | 88 ++++++++ src/fw/ssdt-pcihp.hex | 38 ++++ src/fw/ssdt-proc.hex | 35 +++ 8 files changed, 843 insertions(+), 129 deletions(-) create mode 100644 src/fw/acpi-dsdt.hex create mode 100644 src/fw/ssdt-misc.hex create mode 100644 src/fw/ssdt-pcihp.hex create mode 100644 src/fw/ssdt-proc.hex -- 2.4.3

1 6

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SeaBIOS November 2015