SeaBIOS February 2013

seabios@seabios.org

24 participants
63 discussions

[PATCH 1/5] geodevga: fix errors in geode_fp_* functions
by Christian Gmeiner 15 Feb '13

15 Feb '13

Signed-off-by: Christian Gmeiner <christian.gmeiner(a)gmail.com> --- vgasrc/geodevga.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vgasrc/geodevga.c b/vgasrc/geodevga.c index c2dabf5..ef840a4 100644 --- a/vgasrc/geodevga.c +++ b/vgasrc/geodevga.c @@ -140,7 +140,7 @@ static u32 geode_fp_read(int reg) { u32 val = geode_mem_read(GET_GLOBAL(GeodeVP) + VP_FP_START + reg); dprintf(4, "%s(0x%08x) = 0x%08x\n" - , __func__, GET_GLOBAL(GeodeVP) + reg, val); + , __func__, GET_GLOBAL(GeodeVP) + VP_FP_START + reg, val); return val; } @@ -148,7 +148,7 @@ static void geode_fp_write(int reg, u32 val) { dprintf(4, "%s(0x%08x, 0x%08x)\n" , __func__, GET_GLOBAL(GeodeVP) + VP_FP_START + reg, val); - geode_mem_mask(GET_GLOBAL(GeodeVP) + reg, ~0, val); + geode_mem_mask(GET_GLOBAL(GeodeVP) + VP_FP_START + reg, ~0, val); } /**************************************************************** -- 1.7.12.2.421.g261b511

2 6

[PATCH] USB-EHCI: Fix null pointer assignment
by Avik Sil 15 Feb '13

15 Feb '13

cntl->regs should not be accessed before initializing it. Signed-off-by: Avik Sil <aviksil(a)linux.vnet.ibm.com> --- src/usb-ehci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/usb-ehci.c b/src/usb-ehci.c index f28f343..69a9194 100644 --- a/src/usb-ehci.c +++ b/src/usb-ehci.c @@ -347,9 +347,9 @@ ehci_setup(struct pci_device *pci, int busid, struct pci_device *comppci) cntl->usb.pci = pci; cntl->usb.type = USB_TYPE_EHCI; cntl->caps = caps; + cntl->regs = (void*)caps + readb(&caps->caplength); if (hcc_params & HCC_64BIT_ADDR) cntl->regs->ctrldssegment = 0; - cntl->regs = (void*)caps + readb(&caps->caplength); dprintf(1, "EHCI init on dev %02x:%02x.%x (regs=%p)\n" , pci_bdf_to_bus(bdf), pci_bdf_to_dev(bdf) -- 1.7.11.7

2 1

[Qemu-devel][PATCH 0/6] change acpi numa info format passed from qemu to seabios
by liguang 14 Feb '13

14 Feb '13

orginally, numa info was packed into an array of 64-bit data which was implicit and hard to maintain, so we define a struct for these info, hope to be as clear as enough. these changes also involved seabios paches which was sent to seabios mail-list. Li Guang(6) [PATCH 1/6] pc/bios: move common BIOS_CFG_IOPORT into fw_cfg.h [PATCH 2/6] pc/numa: refactor bios_init function [PATCH 3/6] bitops: change BITS_TO_LONGS [PATCH 4/6] pc: format load_linux() [PATCH 5/6] load_linux: report open kernel file & its size error [PATCH 6/6] load_linux: change kernel header size allocation hw/fw_cfg.h | 4 ++++ hw/pc.c | 163 +++++++++++++++++++++++++++++++------------------------------- hw/sun4u.c | 3 +-- 3 files changed, 89 insertions(+), 81 deletions(-)

4 15

Re: [SeaBIOS] [PATCH 0/5][RFC] Simultaneous multi-platform support
by Peter Stuge 14 Feb '13

14 Feb '13

Fred . wrote: > I propose the name running_on_Xen() The proper way to do that is to send a perfect patch, created using git, with your commit on top of current seabios.git code. //Peter

1 0

[PATCH 0/5][RFC] Simultaneous multi-platform support
by Kevin O'Connor 14 Feb '13

14 Feb '13

This patch series enables SeaBIOS to be compiled for multiple platforms (eg, CSM, QEMU, Coreboot) at the same time. This is useful for cases where SeaBIOS is running under coreboot which is running under QEMU, for example. This series is an RFC - some things are not ideal. For example, if CSM or COREBOOT is enabled then CONFIG_DEBUG_IO is automatically disabled (even if ultimately the image is run directly under QEMU). Also, some features of QEMU wont be available when SeaBIOS is launched from CSM/coreboot, even if it is ultimately running under QEMU. Kevin O'Connor (5): POST: Consolidate platform preinit() calls. Introduce framework for detecting what platform SeaBIOS is running on. Convert common compile time checks to started/runningOnX() checks. Determine century during init and store in VARLOW mem during runtime. Enable simultaneous multi-platform support in Kconfig. src/Kconfig | 23 ++++++-------- src/ata.c | 3 +- src/block.c | 3 +- src/blockcmd.c | 2 +- src/boot.c | 10 +++--- src/clock.c | 26 +++++++++------ src/coreboot.c | 17 +++++++--- src/csm.c | 2 ++ src/esp-scsi.c | 3 +- src/floppy.c | 3 +- src/lsi-scsi.c | 3 +- src/mtrr.c | 4 +-- src/optionroms.c | 3 +- src/paravirt.c | 24 ++++++++++---- src/paravirt.h | 95 +++++++++++++++++++++++++++++++++++++++++++++++++++++-- src/pciinit.c | 4 +-- src/post.c | 53 +++++++++++++++---------------- src/ramdisk.c | 2 +- src/resume.c | 6 +--- src/shadow.c | 12 ++++--- src/smm.c | 10 ++---- src/smp.c | 4 +-- src/virtio-blk.c | 4 +-- src/virtio-scsi.c | 2 +- src/xen.c | 67 +++++++++++++++++++++------------------ src/xen.h | 7 ---- 26 files changed, 253 insertions(+), 139 deletions(-) -- 1.7.11.7

5 23

[PATCH] vgabios: Bochs/QEMU vgabios support should depend on CONFIG_QEMU.
by Kevin O'Connor 13 Feb '13

13 Feb '13

The Cirrus, Standard VGA, and Bochs VGA should depend on CONFIG_QEMU and not CONFIG_COREBOOT. Signed-off-by: Kevin O'Connor <kevin(a)koconnor.net> --- vgasrc/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/vgasrc/Kconfig b/vgasrc/Kconfig index 089a447..0901c04 100644 --- a/vgasrc/Kconfig +++ b/vgasrc/Kconfig @@ -11,14 +11,14 @@ menu "VGA ROM" Do not build a VGA BIOS. config VGA_STANDARD_VGA - depends on !COREBOOT + depends on QEMU bool "QEMU/Bochs Original IBM 256K VGA" help Build basic VGA BIOS support (pre Super-VGA) for use on emulators. config VGA_CIRRUS - depends on !COREBOOT + depends on QEMU bool "QEMU/Bochs Cirrus SVGA" help Build support for Cirrus VGA emulation found on QEMU @@ -26,7 +26,7 @@ menu "VGA ROM" intended for use on real Cirrus hardware. config VGA_BOCHS - depends on !COREBOOT + depends on QEMU bool "QEMU/Bochs VBE SVGA" help Build support for Bochs DISPI interface (a custom VBE -- 1.7.11.7

1 0

Re: [SeaBIOS] [PATCH 8/8] Convert some QEMU cmos config variables to the romfile interface.
by Kevin O'Connor 13 Feb '13

13 Feb '13

On Mon, Feb 11, 2013 at 09:21:29AM +0100, Paolo Bonzini wrote: > Il 10/02/2013 05:48, Kevin O'Connor ha scritto: > > @@ -300,9 +300,8 @@ timer_setup(void) > > SET_BDA(timer_counter, ticks); > > > > // Setup Century storage > > - if (CONFIG_QEMU) { > > - Century = inb_cmos(CMOS_CENTURY); > > - } else { > > + Century = romfile_loadint("etc/century", 0); > > + if (!Century) { > > // Infer current century from the year. > > u8 year = inb_cmos(CMOS_RTC_YEAR); > > if (year > 0x80) > > The right thing to would be to use the FADT century field. In fact we > should also set the century field to 0x32 under QEMU. I'm not much of a fan of storing content in the CMOS. It's fine on QEMU, but on real-hardware it tends to cause conflicts when switching between the factory bios and coreboot. Since the century field isn't going to change for another 87 years I think it's safe to avoid cmos in this case. -Kevin

2 2

Re: [SeaBIOS] [RFC PATCH] VGA BIOS init fails if first mode used is graphical
by David Woodhouse 13 Feb '13

13 Feb '13

On Wed, 2013-02-13 at 12:50 +0100, Fred . wrote: > Would it be possible to boot in a resolution any more modern than the > old IBM PC BIOS of 1980? > Which probably used same resolution as something from 1960 or 1970. > Maybe 132*60 instead of 40*25 or 80*25 rows/columns of text? Please don't top-post. Do me the courtesy of properly trimming your citations to quote *only* what is needed for context, and place your reply *below* it, if you want me to do you the courtesy of taking the time to reply. I will not reply to another top-posted message. I really don't understand what you're even trying to achieve. The whole *POINT* of SeaBIOS is to emulate the old IBM PC BIOS of 1980. Well, and a few later developments, but basically that's the point. DOS, and various other 16-bit bootloaders and operating systems, will expect the standard 80x25 text mode. If they don't find that, then they will fail to work correctly. Anything *else* can call the standard INT 10h video BIOS calls to set whatever mode it wants. What user experience do you actually expect to achieve, from the changes that you're suggesting? Bootloaders like Grub these days will already use graphical modes. The SeaBIOS splash screen can also be graphical, and you can go seamlessly from one to the other. What is it that you actually *want*, in real terms? I'm not even sure you know... -- dwmw2

2 1

Re: [SeaBIOS] [RFC PATCH] VGA BIOS init fails if first mode used is graphical
by Gerd Hoffmann 13 Feb '13

13 Feb '13

Hi, > So the computer boots up and passes it to the bootloader And here does the plan fail. There is simply no way to do that. Bootloaders expect the vga being in 80x25 text mode, period. > Doesn't Apple's computers do that? I don't know. Yes, they do. > Would it be possible to boot in a resolution any more modern than the old > IBM PC BIOS of 1980? As long as we are using the IBM PC BIOS interfaces if 1980 (which seabios is all about): No way. With EFI (which apple uses btw) it's another story ... cheers, Gerd

1 0

Re: [SeaBIOS] [RFC PATCH] VGA BIOS init fails if first mode used is graphical
by David Woodhouse 13 Feb '13

13 Feb '13

On Wed, 2013-02-13 at 10:44 +0100, Fred . wrote: > Can SeaBIOS init to a high resolution video mode such as 1920x1200? I'm not entirely sure what you're asking. Can SeaVGABIOS initialise a high-resolution mode? Yes. It supports 1920x1200 and 2560x1600 modes. All you have to do is call INT 10h with the appropriate mode-setting request. Or are you asking if it can do so *power-up*, setting a graphical mode so that nothing displays as expected, because operating systems and bootloaders expect the screen to be in *text* mode? To which the answer would be that yes it *can* be patched to do so, but that would be bad. Or are you asking if it can do so for the OVMF/CSM case? In which case again it *could* but OVMF is about to set the mode for itself anyway so it would be pointless. -- dwmw2

2 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SeaBIOS February 2013