SeaBIOS October 2017

seabios@seabios.org

17 participants
38 discussions

K-TEK-M275TP-FN-BL-ML USB keyboard support
by Аладышев Константин 28 Apr '18

28 Apr '18

Hello! I'm having problems with K-TEK-M275TP-FN-BL-ML keyboard (http://www.key-tek.cn/Productview.asp?id=777). It is USB device with keyboard and touchpad combined. It works in OS correctly, but doesn't work in SeaBIOS. I've tried to debug this issue and found that "usb_kbd_setup" function fails on "(epdesc->wMaxPacketSize != 8)" check, cause "epdesc->wMaxPacketSize" is actually 32. I've modified this "if" statement to pass 32 value also and now function completes successfully. But it didn't help to solve my issue. There are no interrupts from keyboard, "ehci_poll_intr" always returns -1 on check: if (token & QTD_STS_ACTIVE) { // No intrs found. return -1; } I don't know what to do now. What should I check next? Does SeaBIOS support USB keyboard+touchpad devices at all?

2 5

[PATCH 0/4] RFC: add CRB TPM device
by marcandre.lureau＠redhat.com 12 Feb '18

12 Feb '18

From: Marc-André Lureau <marcandre.lureau(a)redhat.com> Hi, The following series implements a limited TPM CRB driver. The TIS device with a TPM 2.0 seems to be ignored by Windows 10, so I implemented a simple CRB device that I will send shortly on the qemu-devel. With the CRB device, Windows 10 correctly recognized and exchange with a TPM 2.0. As long as the device isn't in qemu, I suppose this series should remain RFC. Feedback welcome! Marc-André Lureau (4): x86: add readq() tpm: generalize init_timeout() tpm: use get_tpm_version() callback WIP: add TPM CRB device support src/hw/tpm_drivers.c | 226 ++++++++++++++++++++++++++++++++++++++++++++++++--- src/hw/tpm_drivers.h | 26 ++++++ src/x86.h | 5 ++ 3 files changed, 245 insertions(+), 12 deletions(-) -- 2.14.1.146.gd35faa819

5 12

USB Device is not stable, Cannot use it with long time
by Lying 30 Oct '17

30 Oct '17

First, I can running my qemu guest normally, And i can use keyboard and mouse in my VM, But i cannot use those after one day. And cannot find any useful log in my system. those message is my VM state( with qemu-monitor-command ): Device 0.1, Port 1, Speed 1.5 Mb/s, Product G100s Gaming Keyboard, ID: hostdev0 Device 0.2, Port 2, Speed 1.5 Mb/s, Product USB Optical Mouse, ID: hostdev1 it show me qemu add device normally,But i cannot use it

1 0

Re: [SeaBIOS] Failure to detect high-capacity SD card
by Kevin O'Connor 28 Oct '17

28 Oct '17

On Fri, Oct 27, 2017 at 08:26:35PM -0500, Matt DeVillier wrote: > On Fri, Oct 27, 2017 at 7:08 PM, Kevin O'Connor <kevin(a)koconnor.net> wrote: > > > Can you try the two patches below? (Go back to master, apply the > > first, gather the log, go back to master, apply the second, gather the > > log.) > > > > -Kevin > > > > w/patch 1 only: https://paste.ubuntu.com/25833503/ > > w/patch 2 only: https://paste.ubuntu.com/25833542/ Okay. One more thing to try is a slightly different voltage range. -Kevin --- a/src/hw/sdcard.c +++ b/src/hw/sdcard.c @@ -123,6 +123,17 @@ struct sdhci_s { #define SRF_DATA 0x04 // SDHCI result flags +#define SR_OCR_VDD_165_195 (1<<7) +#define SR_OCR_VDD_27_28 (1<<15) +#define SR_OCR_VDD_28_29 (1<<16) +#define SR_OCR_VDD_29_30 (1<<17) +#define SR_OCR_VDD_30_31 (1<<18) +#define SR_OCR_VDD_31_32 (1<<19) +#define SR_OCR_VDD_32_33 (1<<20) +#define SR_OCR_VDD_33_34 (1<<21) +#define SR_OCR_VDD_34_35 (1<<22) +#define SR_OCR_VDD_35_36 (1<<23) +#define SR_OCR_S18R (1<<24) #define SR_OCR_CCS (1<<30) #define SR_OCR_NOTBUSY (1<<31) @@ -181,7 +192,7 @@ static int sdcard_pio(struct sdhci_s *regs, int cmd, u32 *param) { u32 state = readl(&regs->present_state); - dprintf(9, "sdcard_pio cmd %x %x %x\n", cmd, *param, state); + dprintf(1, "sdcard_pio cmd %x %x %x\n", cmd, *param, state); if ((state & SP_CMD_INHIBIT) || ((cmd & 0x03) == 0x03 && state & SP_DAT_INHIBIT)) { dprintf(1, "sdcard_pio not ready %x\n", state); @@ -203,7 +214,7 @@ sdcard_pio(struct sdhci_s *regs, int cmd, u32 *param) writew(&regs->irq_status, SI_CMD_COMPLETE); // Read response memcpy(param, regs->response, sizeof(regs->response)); - dprintf(9, "sdcard cmd %x response %x %x %x %x\n" + dprintf(1, "sdcard cmd %x response %x %x %x %x\n" , cmd, param[0], param[1], param[2], param[3]); return 0; } @@ -302,13 +313,13 @@ sdcard_set_power(struct sdhci_s *regs) u32 cap = readl(&regs->cap_lo); u32 volt, vbits; if (cap & SD_CAPLO_V33) { - volt = 1<<20; + volt = SR_OCR_VDD_32_33 | SR_OCR_VDD_33_34; vbits = SPC_V33; } else if (cap & SD_CAPLO_V30) { - volt = 1<<18; + volt = SR_OCR_VDD_29_30 | SR_OCR_VDD_30_31; vbits = SPC_V30; } else if (cap & SD_CAPLO_V18) { - volt = 1<<7; + volt = SR_OCR_VDD_165_195; vbits = SPC_V18; } else { dprintf(1, "SD controller unsupported volt range (%x)\n", cap); @@ -399,11 +410,11 @@ sdcard_card_setup(struct sddrive_s *drive, int volt, int prio) if (ret) return ret; // Let card know SDHC/SDXC is supported and confirm voltage - u32 hcs = 0, vrange = (volt >= (1<<15) ? 0x100 : 0x200) | 0xaa; + u32 hcs = 0, vrange = (volt >= SR_OCR_VDD_27_28 ? 0x100 : 0x200) | 0xaa; param[0] = vrange; ret = sdcard_pio(regs, SC_SEND_IF_COND, param); if (!ret && param[0] == vrange) - hcs = (1<<30); + hcs = SR_OCR_CCS | (1<<28); // Verify SD card (instead of MMC or SDIO) param[0] = 0x00; ret = sdcard_pio_app(regs, SC_APP_SEND_OP_COND, param); @@ -414,8 +425,12 @@ sdcard_card_setup(struct sddrive_s *drive, int volt, int prio) if (ret) return ret; drive->card_type |= SF_MMC; - hcs = (1<<30); + hcs = SR_OCR_CCS; } + // XXX + if (volt == (SR_OCR_VDD_32_33 | SR_OCR_VDD_33_34) + && hcs && readl(&regs->cap_lo) & SD_CAPLO_V18) + hcs |= SR_OCR_S18R; // Init card u32 end = timer_calc(SDHCI_POWERUP_TIMEOUT); for (;;) { @@ -434,6 +449,10 @@ sdcard_card_setup(struct sddrive_s *drive, int volt, int prio) } msleep(5); // Avoid flooding log when debugging } + if (param[0] & SR_OCR_S18R) { + dprintf(1, "Card requests 1.8 volt\n"); + return -1; + } drive->card_type |= (param[0] & SR_OCR_CCS) ? SF_HIGHCAPACITY : 0; // Select card (get cid, set rca, get csd, select card) param[0] = 0x00;

2 1

Re: [SeaBIOS] Failure to detect high-capacity SD card
by Kevin O'Connor 27 Oct '17

27 Oct '17

On Thu, Oct 26, 2017 at 09:04:57PM -0500, Matt DeVillier wrote: > On Thu, Oct 26, 2017 at 11:26 AM, Kevin O'Connor <kevin(a)koconnor.net> wrote: > > > On Thu, Oct 26, 2017 at 11:14:53AM -0400, Matt DeVillier wrote: > > > On Thu, Oct 26, 2017 at 10:59 AM, Kevin O'Connor <kevin(a)koconnor.net> > > wrote: > > > > > > with the patch, USB devices are not available from the boot menu either > > (it > > > appears to hang?), and therefore device cannot be booted to get said log > > > > That sounds like a bad compile then - nothing in the patch should have > > impacted usb. > > > > In any case, the patch below tests the same thing and it should work > > on eMMC also. > > still timing out on detection: https://paste.ubuntu.com/25826387/ Can you try the two patches below? (Go back to master, apply the first, gather the log, go back to master, apply the second, gather the log.) -Kevin ====================== patch 1 ========================= --- a/src/hw/sdcard.c +++ b/src/hw/sdcard.c @@ -181,7 +181,7 @@ static int sdcard_pio(struct sdhci_s *regs, int cmd, u32 *param) { u32 state = readl(&regs->present_state); - dprintf(9, "sdcard_pio cmd %x %x %x\n", cmd, *param, state); + dprintf(1, "sdcard_pio cmd %x %x %x\n", cmd, *param, state); if ((state & SP_CMD_INHIBIT) || ((cmd & 0x03) == 0x03 && state & SP_DAT_INHIBIT)) { dprintf(1, "sdcard_pio not ready %x\n", state); @@ -203,7 +203,7 @@ sdcard_pio(struct sdhci_s *regs, int cmd, u32 *param) writew(&regs->irq_status, SI_CMD_COMPLETE); // Read response memcpy(param, regs->response, sizeof(regs->response)); - dprintf(9, "sdcard cmd %x response %x %x %x %x\n" + dprintf(1, "sdcard cmd %x response %x %x %x %x\n" , cmd, param[0], param[1], param[2], param[3]); return 0; } @@ -403,7 +403,7 @@ sdcard_card_setup(struct sddrive_s *drive, int volt, int prio) param[0] = vrange; ret = sdcard_pio(regs, SC_SEND_IF_COND, param); if (!ret && param[0] == vrange) - hcs = (1<<30); + hcs = (1<<30) | (1<<28); // Verify SD card (instead of MMC or SDIO) param[0] = 0x00; ret = sdcard_pio_app(regs, SC_APP_SEND_OP_COND, param); ====================== patch 2 ========================= --- a/src/hw/sdcard.c +++ b/src/hw/sdcard.c @@ -123,6 +123,7 @@ struct sdhci_s { #define SRF_DATA 0x04 // SDHCI result flags +#define SR_OCR_S18R (1<<24) #define SR_OCR_CCS (1<<30) #define SR_OCR_NOTBUSY (1<<31) @@ -181,7 +182,7 @@ static int sdcard_pio(struct sdhci_s *regs, int cmd, u32 *param) { u32 state = readl(&regs->present_state); - dprintf(9, "sdcard_pio cmd %x %x %x\n", cmd, *param, state); + dprintf(1, "sdcard_pio cmd %x %x %x\n", cmd, *param, state); if ((state & SP_CMD_INHIBIT) || ((cmd & 0x03) == 0x03 && state & SP_DAT_INHIBIT)) { dprintf(1, "sdcard_pio not ready %x\n", state); @@ -203,7 +204,7 @@ sdcard_pio(struct sdhci_s *regs, int cmd, u32 *param) writew(&regs->irq_status, SI_CMD_COMPLETE); // Read response memcpy(param, regs->response, sizeof(regs->response)); - dprintf(9, "sdcard cmd %x response %x %x %x %x\n" + dprintf(1, "sdcard cmd %x response %x %x %x %x\n" , cmd, param[0], param[1], param[2], param[3]); return 0; } @@ -416,6 +417,9 @@ sdcard_card_setup(struct sddrive_s *drive, int volt, int prio) drive->card_type |= SF_MMC; hcs = (1<<30); } + // XXX + if (volt == (1<<20) && hcs && readl(&regs->cap_lo) & SD_CAPLO_V18) + hcs |= SR_OCR_S18R; // Init card u32 end = timer_calc(SDHCI_POWERUP_TIMEOUT); for (;;) { @@ -434,6 +438,10 @@ sdcard_card_setup(struct sddrive_s *drive, int volt, int prio) } msleep(5); // Avoid flooding log when debugging } + if (param[0] & SR_OCR_S18R) { + dprintf(1, "Card requests 1.8 volt\n"); + return -1; + } drive->card_type |= (param[0] & SR_OCR_CCS) ? SF_HIGHCAPACITY : 0; // Select card (get cid, set rca, get csd, select card) param[0] = 0x00;

2 1

Time for a seabios 1.11 release?
by Gerd Hoffmann 27 Oct '17

27 Oct '17

Hi, Quite a few changes accumulated in master. Time to plan a new release I think, so we can pick up the improvements in qemu 2.11. Comments? Anything pending for qemu which needs firmware support? cheers, Gerd

2 3

Re: [SeaBIOS] Failure to detect high-capacity SD card
by Kevin O'Connor 26 Oct '17

26 Oct '17

On Thu, Oct 26, 2017 at 11:14:53AM -0400, Matt DeVillier wrote: > On Thu, Oct 26, 2017 at 10:59 AM, Kevin O'Connor <kevin(a)koconnor.net> wrote: > > > On Thu, Oct 26, 2017 at 10:46:06AM -0400, Matt DeVillier wrote: > > > On Thu, Oct 26, 2017 at 12:56 AM, Kevin O'Connor <kevin(a)koconnor.net> > > wrote: > > > > > > > Does the patch below help? > > > > > > > > -Kevin > > > > > > > > > > > > --- a/src/hw/sdcard.c > > > > +++ b/src/hw/sdcard.c > > > > @@ -405,6 +405,7 @@ sdcard_card_setup(struct sddrive_s *drive, int > > volt, > > > > int prio) > > > > if (!ret && param[0] == vrange) > > > > hcs = (1<<30); > > > > // Verify SD card (instead of MMC or SDIO) > > > > +#if 0 > > > > param[0] = 0x00; > > > > ret = sdcard_pio_app(regs, SC_APP_SEND_OP_COND, param); > > > > if (ret) { > > > > @@ -416,6 +417,7 @@ sdcard_card_setup(struct sddrive_s *drive, int > > volt, > > > > int prio) > > > > drive->card_type |= SF_MMC; > > > > hcs = (1<<30); > > > > } > > > > +#endif > > > > // Init card > > > > u32 end = timer_calc(SDHCI_POWERUP_TIMEOUT); > > > > for (;;) { > > > > > > > > > > with the patch applied, neither the internal eMMC nor the large-capacity > > > external SD card are detected > > > > Yeah - this disables MMC. Any chance to get the log from this run? > > (Let me know if eMMC is needed to get the log.) > > > > -Kevin > > > > with the patch, USB devices are not available from the boot menu either (it > appears to hang?), and therefore device cannot be booted to get said log That sounds like a bad compile then - nothing in the patch should have impacted usb. In any case, the patch below tests the same thing and it should work on eMMC also. -Kevin --- a/src/hw/sdcard.c +++ b/src/hw/sdcard.c @@ -404,19 +404,8 @@ sdcard_card_setup(struct sddrive_s *drive, int volt, int prio) ret = sdcard_pio(regs, SC_SEND_IF_COND, param); if (!ret && param[0] == vrange) hcs = (1<<30); - // Verify SD card (instead of MMC or SDIO) - param[0] = 0x00; - ret = sdcard_pio_app(regs, SC_APP_SEND_OP_COND, param); - if (ret) { - // Check for MMC card - param[0] = 0x00; - ret = sdcard_pio(regs, SC_SEND_OP_COND, param); - if (ret) - return ret; - drive->card_type |= SF_MMC; - hcs = (1<<30); - } // Init card + int firstloop = 1; u32 end = timer_calc(SDHCI_POWERUP_TIMEOUT); for (;;) { param[0] = hcs | volt; // high-capacity support and voltage level @@ -424,8 +413,18 @@ sdcard_card_setup(struct sddrive_s *drive, int volt, int prio) ret = sdcard_pio(regs, SC_SEND_OP_COND, param); else ret = sdcard_pio_app(regs, SC_APP_SEND_OP_COND, param); - if (ret) + if (ret) { + if (firstloop) { + // Check for MMC card + firstloop = 0; + drive->card_type |= SF_MMC; + hcs = (1<<30); + end = timer_calc(SDHCI_POWERUP_TIMEOUT); + continue; + } return ret; + } + firstloop = 0; if (param[0] & SR_OCR_NOTBUSY) break; if (timer_check(end)) {

2 1

Re: [SeaBIOS] Failure to detect high-capacity SD card
by Kevin O'Connor 26 Oct '17

26 Oct '17

On Thu, Oct 26, 2017 at 10:46:06AM -0400, Matt DeVillier wrote: > On Thu, Oct 26, 2017 at 12:56 AM, Kevin O'Connor <kevin(a)koconnor.net> wrote: > > > Does the patch below help? > > > > -Kevin > > > > > > --- a/src/hw/sdcard.c > > +++ b/src/hw/sdcard.c > > @@ -405,6 +405,7 @@ sdcard_card_setup(struct sddrive_s *drive, int volt, > > int prio) > > if (!ret && param[0] == vrange) > > hcs = (1<<30); > > // Verify SD card (instead of MMC or SDIO) > > +#if 0 > > param[0] = 0x00; > > ret = sdcard_pio_app(regs, SC_APP_SEND_OP_COND, param); > > if (ret) { > > @@ -416,6 +417,7 @@ sdcard_card_setup(struct sddrive_s *drive, int volt, > > int prio) > > drive->card_type |= SF_MMC; > > hcs = (1<<30); > > } > > +#endif > > // Init card > > u32 end = timer_calc(SDHCI_POWERUP_TIMEOUT); > > for (;;) { > > > > with the patch applied, neither the internal eMMC nor the large-capacity > external SD card are detected Yeah - this disables MMC. Any chance to get the log from this run? (Let me know if eMMC is needed to get the log.) -Kevin

2 1

Re: [SeaBIOS] Failure to detect high-capacity SD card
by Kevin O'Connor 26 Oct '17

26 Oct '17

On Wed, Oct 25, 2017 at 11:02:50PM -0500, Matt DeVillier wrote: > On Mon, Oct 23, 2017 at 12:04 PM, Kevin O'Connor <kevin(a)koconnor.net> wrote: > > > On Mon, Oct 23, 2017 at 11:59:16AM -0500, Matt DeVillier wrote: > > > On Mon, Oct 23, 2017 at 11:34 AM, Kevin O'Connor <kevin(a)koconnor.net> > > wrote: > > > > On Mon, Oct 23, 2017 at 10:55:57AM -0500, Matt DeVillier wrote: > > > > > On Mon, Oct 23, 2017 at 10:50 AM, Kevin O'Connor <kevin(a)koconnor.net > > > > > > > > > On Mon, Oct 23, 2017 at 10:39:03AM -0400, Kevin O'Connor wrote: > > > > > > Unfortunately, I can't see anything wrong in the log - the card > > isn't > > > > > > coming out of its initialization phase. I can't see any reason why > > > > > > that would be. Has the user verified the card works under Linux? > > > > > card is detected/usable under Linux, no problem there > > > > Can you grab the syslog/dmesg output from Linux as it detects and > > > > initializes the card? > > > sure, any special kernel params for debugging? > > > > The more info on the sdcard the better. I'm not hopeful, but maybe > > something Linux does to the sdcard will help point out why seabios > > isn't able to init the card. > > > > -Kevin > > > > dmesg: https://paste.ubuntu.com/25820588/ > cat /sys/kernel/debug/mmc1/ios : https://paste.ubuntu.com/25821138/ Does the patch below help? -Kevin --- a/src/hw/sdcard.c +++ b/src/hw/sdcard.c @@ -405,6 +405,7 @@ sdcard_card_setup(struct sddrive_s *drive, int volt, int prio) if (!ret && param[0] == vrange) hcs = (1<<30); // Verify SD card (instead of MMC or SDIO) +#if 0 param[0] = 0x00; ret = sdcard_pio_app(regs, SC_APP_SEND_OP_COND, param); if (ret) { @@ -416,6 +417,7 @@ sdcard_card_setup(struct sddrive_s *drive, int volt, int prio) drive->card_type |= SF_MMC; hcs = (1<<30); } +#endif // Init card u32 end = timer_calc(SDHCI_POWERUP_TIMEOUT); for (;;) {

2 1

Re: [SeaBIOS] Failure to detect high-capacity SD card
by Kevin O'Connor 25 Oct '17

25 Oct '17

On Mon, Oct 23, 2017 at 11:59:16AM -0500, Matt DeVillier wrote: > On Mon, Oct 23, 2017 at 11:34 AM, Kevin O'Connor <kevin(a)koconnor.net> wrote: > > On Mon, Oct 23, 2017 at 10:55:57AM -0500, Matt DeVillier wrote: > > > On Mon, Oct 23, 2017 at 10:50 AM, Kevin O'Connor <kevin(a)koconnor.net> > > > > On Mon, Oct 23, 2017 at 10:39:03AM -0400, Kevin O'Connor wrote: > > > > Unfortunately, I can't see anything wrong in the log - the card isn't > > > > coming out of its initialization phase. I can't see any reason why > > > > that would be. Has the user verified the card works under Linux? > > > card is detected/usable under Linux, no problem there > > Can you grab the syslog/dmesg output from Linux as it detects and > > initializes the card? > sure, any special kernel params for debugging? The more info on the sdcard the better. I'm not hopeful, but maybe something Linux does to the sdcard will help point out why seabios isn't able to init the card. -Kevin

2 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SeaBIOS October 2017