Hello,
thanks for help.
On 03.10.2017 18:15, Kevin O'Connor wrote:
Can you recompile SeaBIOS with the patch below applied? I don't have a good way to test this, but I'm hopeful it will help detect the USB2 disconnect and avoid the controller hang.
I've applied the patch. But maybe I need some help with this. Coreboot will always overwrite these changes.
error: Your local changes to the following files would be overwritten by checkout: src/hw/usb-xhci.c Please, commit your changes or stash them before you can switch branches. Aborting
I've tried stash, but that really won't work. I went back to version rel-1.10.0-70-gf3d2a15, applied the patch and copy it to the master branch. Don't know, if I've done a "checkout -- <file>" or something else, but after all, I got it working and can compile with the patch. But I don't know how. :-)
Now, I am on version: rel-1.10.0-72-gf703604-dirty-20171008_051220-x220.
The controller doesn't hang any more and the device is detected at boot. I'm not sure, if it's only USB2. Because of the verbose logging, the cbmem console log is truncated.
I've attached the debug files.
Hopefully you can commit you're changes. If you need further testing, please send a message.
Best regards, Reiner
--
Dear Reiner,
Am 08.10.2017 um 06:25 schrieb diffusae:
On 03.10.2017 18:15, Kevin O'Connor wrote:
Can you recompile SeaBIOS with the patch below applied? I don't have a good way to test this, but I'm hopeful it will help detect the USB2 disconnect and avoid the controller hang.
I've applied the patch. But maybe I need some help with this. Coreboot will always overwrite these changes.
error: Your local changes to the following files would be overwritten by checkout: src/hw/usb-xhci.c Please, commit your changes or stash them before you can switch branches. Aborting
I've tried stash, but that really won't work. I went back to version rel-1.10.0-70-gf3d2a15, applied the patch and copy it to the master branch. Don't know, if I've done a "checkout -- <file>" or something else, but after all, I got it working and can compile with the patch. But I don't know how. :-)
You could build SeaBIOS yourself externally, and that the result `bios.bin.elf` to CBFS by configuring Kconfig to add an ELF file (section *Payloads* in the coreboot menu) or by doing it yourself with `cbfstool build/coreboot.rom add-payload -n fallback/payload -f path/to/bios.bin.elf -c lzma`.
[…]
Kind regards,
Paul
On Sun, Oct 08, 2017 at 06:25:02AM +0200, diffusae wrote:
On 03.10.2017 18:15, Kevin O'Connor wrote:
Can you recompile SeaBIOS with the patch below applied? I don't have a good way to test this, but I'm hopeful it will help detect the USB2 disconnect and avoid the controller hang.
I've applied the patch. But maybe I need some help with this. Coreboot will always overwrite these changes.
As Paul points out, the best way to apply seabios patches is to compile seabios separately.
[...]
The controller doesn't hang any more and the device is detected at boot. I'm not sure, if it's only USB2. Because of the verbose logging, the cbmem console log is truncated.
The log indicates the device was detected as both USB2 and USB3. The USB2 version was successfully brought down, and the USB3 version remained live. So, everything looks good.
Hopefully you can commit you're changes. If you need further testing, please send a message.
Thanks, I committed the changes.
-Kevin
On 10.10.2017 02:59, Kevin O'Connor wrote:
As Paul points out, the best way to apply seabios patches is to compile seabios separately.
Yes, thanks to Paul for that hint. The last time I did it this way, is about four years ago. Now, it's a bit more convenient to compile Seabios with coreboot. I only was wondering, that it was possible with git. Next time, i will do it the recommended way. If your changes are committed, than I don't need the patch.
The log indicates the device was detected as both USB2 and USB3. The USB2 version was successfully brought down, and the USB3 version remained live. So, everything looks good.
That's fine. I will try to boot from USB3 devices, next time.
Thanks, I committed the changes.
Perfectly, thanks also for your help.
Regards, Reiner
-
diffusae -
Kevin O'Connor -
Paul Menzel