Re: [SeaBIOS] [PATCH] pvscsi boot support

[Paul Menzel]

Dear Evgeny,

thank you for the patch!

Am Sonntag, den 06.10.2013, 14:14 +0300 schrieb Evgeny Budilovsky:

Is this version 2 of the patch from »Sun,  6 Oct 2013 13:23:26 +0300«?
Did you just remove the first Signed-off-by line? (Please mark different
iterations in the subject line, like »[PATCH v3]«. See
`--subject-prefix=Subject-Prefix` in `git help format-patch`.)
> Signed-off-by: Evgeny Budilovsky
>
> Makefile          |    2 +-
>  src/Kconfig       |    6 +
>  src/block.c       |    1 +
>  src/block.h       |    1 +
>  src/hw/blockcmd.c |    3 +
>  src/hw/pci_ids.h  |    3 +
>  src/hw/pvscsi.c   |  365 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  src/hw/pvscsi.h   |    8 ++
>  src/post.c        |    2 +
>  9 files changed, 390 insertions(+), 1 deletion(-)
>  create mode 100644 src/hw/pvscsi.c
>  create mode 100644 src/hw/pvscsi.h

How did you test this? Does everything work?
> diff --git a/Makefile b/Makefile
> index 3218970..6c6302e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -34,7 +34,7 @@ SRCBOTH=misc.c stacks.c output.c string.c x86.c block.c cdrom.c mouse.c kbd.c \
>      hw/usb-hid.c hw/usb-msc.c hw/usb-uas.c \
>      hw/blockcmd.c hw/floppy.c hw/ata.c hw/ahci.c hw/ramdisk.c \
>      hw/virtio-ring.c hw/virtio-pci.c hw/virtio-blk.c hw/virtio-scsi.c \
> hw/lsi-scsi.c hw/esp-scsi.c hw/megasas.c
> hw/lsi-scsi.c hw/esp-scsi.c hw/megasas.c hw/pvscsi.c
>
> SRC16=$(SRCBOTH) system.c disk.c font.c
>  SRC32FLAT=$(SRCBOTH) post.c memmap.c malloc.c pmm.c romfile.c optionroms.c \
>      boot.c bootsplash.c jpeg.c bmp.c \
> diff --git a/src/Kconfig b/src/Kconfig
> index c40cc61..e4967d2 100644
> --- a/src/Kconfig
> +++ b/src/Kconfig
> @@ -161,6 +161,12 @@ menu "Hardware support"
>          default y
>          help
>              Support boot from virtio-scsi storage.
> config PVSCSI
>    depends on DRIVES && QEMU_HARDWARE
>    bool "pvscsi controllers"
>    default y
>    help
>        Support boot from pvscsi storage.

Could you at list write »Paravirtualized SCSI« out once, please? So
people grepping for that can find it too. Not sure if if the
abbreviation should be written all upper case like in the Wiki [1]. I do
not know if that is the official spelling.

[…]

Thanks,

Paul

[1] http://wiki.xen.org/wiki/Paravirtualized_SCSI

[PATCH] pvscsi boot support

[Evgeny Budilovsky]

On Mon, Oct 7, 2013 at 10:40 AM, Paul Menzel <
[e-mail]> wrote:
> Dear Evgeny,
>
> thank you for the patch!
>
> Am Sonntag, den 06.10.2013, 14:14 +0300 schrieb Evgeny Budilovsky:
>
> Is this version 2 of the patch from »Sun,  6 Oct 2013 13:23:26 +0300«?
> Did you just remove the first Signed-off-by line? (Please mark different
> iterations in the subject line, like »[PATCH v3]«. See
> `--subject-prefix=Subject-Prefix` in `git help format-patch`.)
>
> Yes sorry for this. The intention was to remove the redundant signed-off

stuff. I will send the next iteration using the proper prefix :)
> Signed-off-by: Evgeny Budilovsky
> > Makefile          |    2 +-
> >  src/Kconfig       |    6 +
> >  src/block.c       |    1 +
> >  src/block.h       |    1 +
> >  src/hw/blockcmd.c |    3 +
> >  src/hw/pci_ids.h  |    3 +
> >  src/hw/pvscsi.c   |  365
>
> +++++++++++++++++++++++++++++++++++++++++++++++++++++
> > src/hw/pvscsi.h   |    8 ++
> >  src/post.c        |    2 +
> >  9 files changed, 390 insertions(+), 1 deletion(-)
> >  create mode 100644 src/hw/pvscsi.c
> >  create mode 100644 src/hw/pvscsi.h
>
> How did you test this? Does everything work?

I've used windows images (win 2008/2012) taken from esx with vmware tools
installed and boot disk configured to use pvscsi.
Also I've used linux (ubuntu 12.04) where pvscsi drivers installed by
default and booted it using qemu cmd similar to this:

./x86_64-softmmu/qemu-system-x86_64 -snapshot -device pvscsi,id=pvscsi0
-device scsi-disk,bus=pvscsi0.0,drive=drive0 -drive
id=drive0,if=none,file=ubuntu-12.04.qcow2 -bios roms/seabios/out/bios.bin
> > diff --git a/Makefile b/Makefile
> > index 3218970..6c6302e 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -34,7 +34,7 @@ SRCBOTH=misc.c stacks.c output.c string.c x86.c
>
> block.c cdrom.c mouse.c kbd.c \
> >  hw/usb-hid.c hw/usb-msc.c hw/usb-uas.c \
> >  hw/blockcmd.c hw/floppy.c hw/ata.c hw/ahci.c hw/ramdisk.c \
> >  hw/virtio-ring.c hw/virtio-pci.c hw/virtio-blk.c hw/virtio-scsi.c \
> > hw/lsi-scsi.c hw/esp-scsi.c hw/megasas.c
> > hw/lsi-scsi.c hw/esp-scsi.c hw/megasas.c hw/pvscsi.c
> >
> > SRC16=$(SRCBOTH) system.c disk.c font.c
> >  SRC32FLAT=$(SRCBOTH) post.c memmap.c malloc.c pmm.c romfile.c
>
> optionroms.c \
> >  boot.c bootsplash.c jpeg.c bmp.c \
> >
> > diff --git a/src/Kconfig b/src/Kconfig
> > index c40cc61..e4967d2 100644
> > --- a/src/Kconfig
> > +++ b/src/Kconfig
> > @@ -161,6 +161,12 @@ menu "Hardware support"
> >          default y
> >          help
> >              Support boot from virtio-scsi storage.
> > config PVSCSI
> >    depends on DRIVES && QEMU_HARDWARE
> >    bool "pvscsi controllers"
> >    default y
> >    help
> >        Support boot from pvscsi storage.
>
> Could you at list write »Paravirtualized SCSI« out once, please? So
> people grepping for that can find it too. Not sure if if the
> abbreviation should be written all upper case like in the Wiki [1]. I do
> not know if that is the official spelling.

Yes sure sounds reasonable I will resend the changes
> […]
>
> Thanks,
>
> Paul
>
> [1] http://wiki.xen.org/wiki/Paravirtualized_SCSI