Re: [SeaBIOS] [PATCH] ACPI: Remove unnecessary Return(One) calls from DSDT.

[Marc Jones]

On Mon, Oct 29, 2012 at 10:17 AM, Marc Jones <[e-mail]> wrote:
> Acked-by: Marc Jones <[e-mail]>
>
> On Sat, Oct 27, 2012 at 7:33 PM, Kevin O'Connor <[e-mail]> wrote:
> > Recent iasl compilers warn about spurious return calls.  Remove extra
> > return calls from the GPE event methods.
> >
> > Signed-off-by: Kevin O'Connor <[e-mail]>
> > ---
> >  src/acpi-dsdt.dsl | 20 ++------------------
> >  1 file changed, 2 insertions(+), 18 deletions(-)
> >
> > diff --git a/src/acpi-dsdt.dsl b/src/acpi-dsdt.dsl
> > index d2575a5..284d70d 100644
> > --- a/src/acpi-dsdt.dsl
> > +++ b/src/acpi-dsdt.dsl
> > @@ -559,7 +559,6 @@ DefinitionBlock (
> >                      PCNT(Local0, 3)
> >                  }
> >              }
> > -            Return(One)
> >          }
> >
> > }
> > @@ -729,7 +728,6 @@ DefinitionBlock (
> >                  }
> >                  Increment(Local0)
> >              }
> > -            Return(One)
> >          }
> >      }
> >
> > @@ -743,54 +741,40 @@ DefinitionBlock (
> >          Name(_HID, "ACPI0006")
> >
> > Method(_L00) {
> > -            Return(0x01)
> >          }
> >          Method(_E01) {
> >              // PCI hotplug event
> > -            Return(\_SB.PCI0.PCNF())
> > +            \_SB.PCI0.PCNF()
> >          }
> >          Method(_E02) {
> >              // CPU hotplug event
> > -            Return(\_SB.PRSC())
> > +            \_SB.PRSC()
> >          }
> >          Method(_L03) {
> > -            Return(0x01)
> >          }
> >          Method(_L04) {
> > -            Return(0x01)
> >          }
> >          Method(_L05) {
> > -            Return(0x01)
> >          }
> >          Method(_L06) {
> > -            Return(0x01)
> >          }
> >          Method(_L07) {
> > -            Return(0x01)
> >          }
> >          Method(_L08) {
> > -            Return(0x01)
> >          }
> >          Method(_L09) {
> > -            Return(0x01)
> >          }
> >          Method(_L0A) {
> > -            Return(0x01)
> >          }
> >          Method(_L0B) {
> > -            Return(0x01)
> >          }
> >          Method(_L0C) {
> > -            Return(0x01)
> >          }
> >          Method(_L0D) {
> > -            Return(0x01)
> >          }
> >          Method(_L0E) {
> > -            Return(0x01)
> >          }
> >          Method(_L0F) {
> > -            Return(0x01)
> >          }
> >      }
> >  }
> > --
> > 1.7.11.7
> >
> > _______________________________________________
> > SeaBIOS mailing list
> > [e-mail]
> > http://www.seabios.org/mailman/listinfo/seabios