Hi,
This patch series adds support for all HD and QXGA resolutions.
I've taken Gerd's advice on the v1 patch and split the formatting improvments into a separate patch.
I also tried to take Gerd's advice on removing some of the older colors depths for higher resolutions. However, upon doing this Windows was no longer recognizing some of the resolutions so I had to add them back. I split that up into a separate patch in case anyone wants to try and reproduce the issue. But, it should be fine to include those common color depths anyway for maximal compatibility.
Best regards,
Elliot
Elliot Killick (3): svgamodes: Add all HD and QXGA resolutions svgamodes: Improve formatting svgamodes: Add color depths other than just 32-bit
vgasrc/svgamodes.c | 217 +++++++++++++++++++++++++++++---------------- 1 file changed, 140 insertions(+), 77 deletions(-)
Add support for all high-definition and quad extended graphics array resolutions as listed on Wikipedia. Additionally, eliminate any color depths that are less than 32-bits for resolutions greater than Full HD.
https://en.wikipedia.org/wiki/Graphics_display_resolution
Signed-off-by: Elliot Killick elliotkillick@zohomail.eu --- vgasrc/svgamodes.c | 45 +++++++++++++++++++++++++++++++++------------ 1 file changed, 33 insertions(+), 12 deletions(-)
diff --git a/vgasrc/svgamodes.c b/vgasrc/svgamodes.c index 6e494c7..3420d2b 100644 --- a/vgasrc/svgamodes.c +++ b/vgasrc/svgamodes.c @@ -72,25 +72,46 @@ struct generic_svga_mode svga_modes[] VAR16 = { { 0x184, { MM_DIRECT, 1680, 1050, 16, 8, 16, SEG_GRAPH } }, { 0x185, { MM_DIRECT, 1680, 1050, 24, 8, 16, SEG_GRAPH } }, { 0x186, { MM_DIRECT, 1680, 1050, 32, 8, 16, SEG_GRAPH } }, - { 0x187, { MM_DIRECT, 1920, 1200, 16, 8, 16, SEG_GRAPH } }, - { 0x188, { MM_DIRECT, 1920, 1200, 24, 8, 16, SEG_GRAPH } }, { 0x189, { MM_DIRECT, 1920, 1200, 32, 8, 16, SEG_GRAPH } }, - { 0x18a, { MM_DIRECT, 2560, 1600, 16, 8, 16, SEG_GRAPH } }, - { 0x18b, { MM_DIRECT, 2560, 1600, 24, 8, 16, SEG_GRAPH } }, - { 0x18c, { MM_DIRECT, 2560, 1600, 32, 8, 16, SEG_GRAPH } }, { 0x18d, { MM_DIRECT, 1280, 720, 16, 8, 16, SEG_GRAPH } }, { 0x18e, { MM_DIRECT, 1280, 720, 24, 8, 16, SEG_GRAPH } }, { 0x18f, { MM_DIRECT, 1280, 720, 32, 8, 16, SEG_GRAPH } }, { 0x190, { MM_DIRECT, 1920, 1080, 16, 8, 16, SEG_GRAPH } }, { 0x191, { MM_DIRECT, 1920, 1080, 24, 8, 16, SEG_GRAPH } }, { 0x192, { MM_DIRECT, 1920, 1080, 32, 8, 16, SEG_GRAPH } }, + { 0x193, { MM_DIRECT, 1600, 900, 16, 8, 16, SEG_GRAPH } }, + { 0x194, { MM_DIRECT, 1600, 900, 24, 8, 16, SEG_GRAPH } }, + { 0x195, { MM_DIRECT, 1600, 900, 32, 8, 16, SEG_GRAPH } }, + { 0x196, { MM_DIRECT, 960, 540, 16, 8, 16, SEG_GRAPH } }, + { 0x197, { MM_DIRECT, 960, 540, 24, 8, 16, SEG_GRAPH } }, + { 0x198, { MM_DIRECT, 960, 540, 32, 8, 16, SEG_GRAPH } }, + { 0x199, { MM_DIRECT, 1280, 1080, 16, 8, 16, SEG_GRAPH } }, + { 0x19a, { MM_DIRECT, 1280, 1080, 24, 8, 16, SEG_GRAPH } }, + { 0x19b, { MM_DIRECT, 1280, 1080, 32, 8, 16, SEG_GRAPH } },
- /* custom resolutions for 16:9 displays */ - { 0x193, { MM_DIRECT, 1600, 900, 16, 8, 16, SEG_GRAPH } }, - { 0x194, { MM_DIRECT, 1600, 900, 24, 8, 16, SEG_GRAPH } }, - { 0x195, { MM_DIRECT, 1600, 900, 32, 8, 16, SEG_GRAPH } }, - { 0x196, { MM_DIRECT, 2560, 1440, 16, 8, 16, SEG_GRAPH } }, - { 0x197, { MM_DIRECT, 2560, 1440, 24, 8, 16, SEG_GRAPH } }, - { 0x198, { MM_DIRECT, 2560, 1440, 32, 8, 16, SEG_GRAPH } }, + /* other high-definition resolutions */ + { 0x19c, { MM_DIRECT, 2048, 1080, 32, 8, 16, SEG_GRAPH } }, + { 0x19d, { MM_DIRECT, 2160, 1080, 32, 8, 16, SEG_GRAPH } }, + { 0x19e, { MM_DIRECT, 2560, 1080, 32, 8, 16, SEG_GRAPH } }, + { 0x19f, { MM_DIRECT, 2560, 1440, 32, 8, 16, SEG_GRAPH } }, + { 0x1a0, { MM_DIRECT, 3200, 1800, 32, 8, 16, SEG_GRAPH } }, + { 0x1a1, { MM_DIRECT, 3440, 1440, 32, 8, 16, SEG_GRAPH } }, + { 0x1a2, { MM_DIRECT, 3840, 1080, 32, 8, 16, SEG_GRAPH } }, + { 0x1a3, { MM_DIRECT, 3840, 1600, 32, 8, 16, SEG_GRAPH } }, + { 0x1a4, { MM_DIRECT, 3840, 2160, 32, 8, 16, SEG_GRAPH } }, + { 0x1a5, { MM_DIRECT, 4096, 2160, 32, 8, 16, SEG_GRAPH } }, + { 0x1a6, { MM_DIRECT, 5120, 2160, 32, 8, 16, SEG_GRAPH } }, + { 0x1a7, { MM_DIRECT, 5120, 2880, 32, 8, 16, SEG_GRAPH } }, + { 0x1a8, { MM_DIRECT, 7680, 4320, 32, 8, 16, SEG_GRAPH } }, + { 0x1a9, { MM_DIRECT, 17280, 4320, 32, 8, 16, SEG_GRAPH } }, + + /* quad extended graphics array resolutions */ + { 0x1aa, { MM_DIRECT, 2048, 1152, 32, 8, 16, SEG_GRAPH } }, + { 0x1ab, { MM_DIRECT, 2048, 1536, 32, 8, 16, SEG_GRAPH } }, + { 0x1ac, { MM_DIRECT, 2560, 1600, 32, 8, 16, SEG_GRAPH } }, + { 0x1ad, { MM_DIRECT, 2560, 2048, 32, 8, 16, SEG_GRAPH } }, + { 0x1ae, { MM_DIRECT, 3200, 2048, 32, 8, 16, SEG_GRAPH } }, + { 0x1af, { MM_DIRECT, 3200, 2400, 32, 8, 16, SEG_GRAPH } }, + { 0x1b0, { MM_DIRECT, 3840, 2400, 32, 8, 16, SEG_GRAPH } }, }; unsigned int svga_mcount VAR16 = ARRAY_SIZE(svga_modes);
Normalize capitalization of hex identifiers and fix indentation to accommodate new 5-digit resolution width.
Signed-off-by: Elliot Killick elliotkillick@zohomail.eu --- vgasrc/svgamodes.c | 148 ++++++++++++++++++++++----------------------- 1 file changed, 74 insertions(+), 74 deletions(-)
diff --git a/vgasrc/svgamodes.c b/vgasrc/svgamodes.c index 3420d2b..ea86c6c 100644 --- a/vgasrc/svgamodes.c +++ b/vgasrc/svgamodes.c @@ -13,81 +13,81 @@
struct generic_svga_mode svga_modes[] VAR16 = { /* standard modes */ - { 0x100, { MM_PACKED, 640, 400, 8, 8, 16, SEG_GRAPH } }, - { 0x101, { MM_PACKED, 640, 480, 8, 8, 16, SEG_GRAPH } }, - { 0x102, { MM_PLANAR, 800, 600, 4, 8, 16, SEG_GRAPH } }, - { 0x103, { MM_PACKED, 800, 600, 8, 8, 16, SEG_GRAPH } }, - { 0x104, { MM_PLANAR, 1024, 768, 4, 8, 16, SEG_GRAPH } }, - { 0x105, { MM_PACKED, 1024, 768, 8, 8, 16, SEG_GRAPH } }, - { 0x106, { MM_PLANAR, 1280, 1024, 4, 8, 16, SEG_GRAPH } }, - { 0x107, { MM_PACKED, 1280, 1024, 8, 8, 16, SEG_GRAPH } }, - { 0x10D, { MM_DIRECT, 320, 200, 15, 8, 16, SEG_GRAPH } }, - { 0x10E, { MM_DIRECT, 320, 200, 16, 8, 16, SEG_GRAPH } }, - { 0x10F, { MM_DIRECT, 320, 200, 24, 8, 16, SEG_GRAPH } }, - { 0x110, { MM_DIRECT, 640, 480, 15, 8, 16, SEG_GRAPH } }, - { 0x111, { MM_DIRECT, 640, 480, 16, 8, 16, SEG_GRAPH } }, - { 0x112, { MM_DIRECT, 640, 480, 24, 8, 16, SEG_GRAPH } }, - { 0x113, { MM_DIRECT, 800, 600, 15, 8, 16, SEG_GRAPH } }, - { 0x114, { MM_DIRECT, 800, 600, 16, 8, 16, SEG_GRAPH } }, - { 0x115, { MM_DIRECT, 800, 600, 24, 8, 16, SEG_GRAPH } }, - { 0x116, { MM_DIRECT, 1024, 768, 15, 8, 16, SEG_GRAPH } }, - { 0x117, { MM_DIRECT, 1024, 768, 16, 8, 16, SEG_GRAPH } }, - { 0x118, { MM_DIRECT, 1024, 768, 24, 8, 16, SEG_GRAPH } }, - { 0x119, { MM_DIRECT, 1280, 1024, 15, 8, 16, SEG_GRAPH } }, - { 0x11A, { MM_DIRECT, 1280, 1024, 16, 8, 16, SEG_GRAPH } }, - { 0x11B, { MM_DIRECT, 1280, 1024, 24, 8, 16, SEG_GRAPH } }, - { 0x11C, { MM_PACKED, 1600, 1200, 8, 8, 16, SEG_GRAPH } }, - { 0x11D, { MM_DIRECT, 1600, 1200, 15, 8, 16, SEG_GRAPH } }, - { 0x11E, { MM_DIRECT, 1600, 1200, 16, 8, 16, SEG_GRAPH } }, - { 0x11F, { MM_DIRECT, 1600, 1200, 24, 8, 16, SEG_GRAPH } }, + { 0x100, { MM_PACKED, 640, 400, 8, 8, 16, SEG_GRAPH } }, + { 0x101, { MM_PACKED, 640, 480, 8, 8, 16, SEG_GRAPH } }, + { 0x102, { MM_PLANAR, 800, 600, 4, 8, 16, SEG_GRAPH } }, + { 0x103, { MM_PACKED, 800, 600, 8, 8, 16, SEG_GRAPH } }, + { 0x104, { MM_PLANAR, 1024, 768, 4, 8, 16, SEG_GRAPH } }, + { 0x105, { MM_PACKED, 1024, 768, 8, 8, 16, SEG_GRAPH } }, + { 0x106, { MM_PLANAR, 1280, 1024, 4, 8, 16, SEG_GRAPH } }, + { 0x107, { MM_PACKED, 1280, 1024, 8, 8, 16, SEG_GRAPH } }, + { 0x10d, { MM_DIRECT, 320, 200, 15, 8, 16, SEG_GRAPH } }, + { 0x10e, { MM_DIRECT, 320, 200, 16, 8, 16, SEG_GRAPH } }, + { 0x10f, { MM_DIRECT, 320, 200, 24, 8, 16, SEG_GRAPH } }, + { 0x110, { MM_DIRECT, 640, 480, 15, 8, 16, SEG_GRAPH } }, + { 0x111, { MM_DIRECT, 640, 480, 16, 8, 16, SEG_GRAPH } }, + { 0x112, { MM_DIRECT, 640, 480, 24, 8, 16, SEG_GRAPH } }, + { 0x113, { MM_DIRECT, 800, 600, 15, 8, 16, SEG_GRAPH } }, + { 0x114, { MM_DIRECT, 800, 600, 16, 8, 16, SEG_GRAPH } }, + { 0x115, { MM_DIRECT, 800, 600, 24, 8, 16, SEG_GRAPH } }, + { 0x116, { MM_DIRECT, 1024, 768, 15, 8, 16, SEG_GRAPH } }, + { 0x117, { MM_DIRECT, 1024, 768, 16, 8, 16, SEG_GRAPH } }, + { 0x118, { MM_DIRECT, 1024, 768, 24, 8, 16, SEG_GRAPH } }, + { 0x119, { MM_DIRECT, 1280, 1024, 15, 8, 16, SEG_GRAPH } }, + { 0x11a, { MM_DIRECT, 1280, 1024, 16, 8, 16, SEG_GRAPH } }, + { 0x11b, { MM_DIRECT, 1280, 1024, 24, 8, 16, SEG_GRAPH } }, + { 0x11c, { MM_PACKED, 1600, 1200, 8, 8, 16, SEG_GRAPH } }, + { 0x11d, { MM_DIRECT, 1600, 1200, 15, 8, 16, SEG_GRAPH } }, + { 0x11e, { MM_DIRECT, 1600, 1200, 16, 8, 16, SEG_GRAPH } }, + { 0x11f, { MM_DIRECT, 1600, 1200, 24, 8, 16, SEG_GRAPH } }, /* other modes */ - { 0x140, { MM_DIRECT, 320, 200, 32, 8, 16, SEG_GRAPH } }, - { 0x141, { MM_DIRECT, 640, 400, 32, 8, 16, SEG_GRAPH } }, - { 0x142, { MM_DIRECT, 640, 480, 32, 8, 16, SEG_GRAPH } }, - { 0x143, { MM_DIRECT, 800, 600, 32, 8, 16, SEG_GRAPH } }, - { 0x144, { MM_DIRECT, 1024, 768, 32, 8, 16, SEG_GRAPH } }, - { 0x145, { MM_DIRECT, 1280, 1024, 32, 8, 16, SEG_GRAPH } }, - { 0x146, { MM_PACKED, 320, 200, 8, 8, 16, SEG_GRAPH } }, - { 0x147, { MM_DIRECT, 1600, 1200, 32, 8, 16, SEG_GRAPH } }, - { 0x148, { MM_PACKED, 1152, 864, 8, 8, 16, SEG_GRAPH } }, - { 0x149, { MM_DIRECT, 1152, 864, 15, 8, 16, SEG_GRAPH } }, - { 0x14a, { MM_DIRECT, 1152, 864, 16, 8, 16, SEG_GRAPH } }, - { 0x14b, { MM_DIRECT, 1152, 864, 24, 8, 16, SEG_GRAPH } }, - { 0x14c, { MM_DIRECT, 1152, 864, 32, 8, 16, SEG_GRAPH } }, - { 0x175, { MM_DIRECT, 1280, 768, 16, 8, 16, SEG_GRAPH } }, - { 0x176, { MM_DIRECT, 1280, 768, 24, 8, 16, SEG_GRAPH } }, - { 0x177, { MM_DIRECT, 1280, 768, 32, 8, 16, SEG_GRAPH } }, - { 0x178, { MM_DIRECT, 1280, 800, 16, 8, 16, SEG_GRAPH } }, - { 0x179, { MM_DIRECT, 1280, 800, 24, 8, 16, SEG_GRAPH } }, - { 0x17a, { MM_DIRECT, 1280, 800, 32, 8, 16, SEG_GRAPH } }, - { 0x17b, { MM_DIRECT, 1280, 960, 16, 8, 16, SEG_GRAPH } }, - { 0x17c, { MM_DIRECT, 1280, 960, 24, 8, 16, SEG_GRAPH } }, - { 0x17d, { MM_DIRECT, 1280, 960, 32, 8, 16, SEG_GRAPH } }, - { 0x17e, { MM_DIRECT, 1440, 900, 16, 8, 16, SEG_GRAPH } }, - { 0x17f, { MM_DIRECT, 1440, 900, 24, 8, 16, SEG_GRAPH } }, - { 0x180, { MM_DIRECT, 1440, 900, 32, 8, 16, SEG_GRAPH } }, - { 0x181, { MM_DIRECT, 1400, 1050, 16, 8, 16, SEG_GRAPH } }, - { 0x182, { MM_DIRECT, 1400, 1050, 24, 8, 16, SEG_GRAPH } }, - { 0x183, { MM_DIRECT, 1400, 1050, 32, 8, 16, SEG_GRAPH } }, - { 0x184, { MM_DIRECT, 1680, 1050, 16, 8, 16, SEG_GRAPH } }, - { 0x185, { MM_DIRECT, 1680, 1050, 24, 8, 16, SEG_GRAPH } }, - { 0x186, { MM_DIRECT, 1680, 1050, 32, 8, 16, SEG_GRAPH } }, - { 0x189, { MM_DIRECT, 1920, 1200, 32, 8, 16, SEG_GRAPH } }, - { 0x18d, { MM_DIRECT, 1280, 720, 16, 8, 16, SEG_GRAPH } }, - { 0x18e, { MM_DIRECT, 1280, 720, 24, 8, 16, SEG_GRAPH } }, - { 0x18f, { MM_DIRECT, 1280, 720, 32, 8, 16, SEG_GRAPH } }, - { 0x190, { MM_DIRECT, 1920, 1080, 16, 8, 16, SEG_GRAPH } }, - { 0x191, { MM_DIRECT, 1920, 1080, 24, 8, 16, SEG_GRAPH } }, - { 0x192, { MM_DIRECT, 1920, 1080, 32, 8, 16, SEG_GRAPH } }, - { 0x193, { MM_DIRECT, 1600, 900, 16, 8, 16, SEG_GRAPH } }, - { 0x194, { MM_DIRECT, 1600, 900, 24, 8, 16, SEG_GRAPH } }, - { 0x195, { MM_DIRECT, 1600, 900, 32, 8, 16, SEG_GRAPH } }, - { 0x196, { MM_DIRECT, 960, 540, 16, 8, 16, SEG_GRAPH } }, - { 0x197, { MM_DIRECT, 960, 540, 24, 8, 16, SEG_GRAPH } }, - { 0x198, { MM_DIRECT, 960, 540, 32, 8, 16, SEG_GRAPH } }, - { 0x199, { MM_DIRECT, 1280, 1080, 16, 8, 16, SEG_GRAPH } }, - { 0x19a, { MM_DIRECT, 1280, 1080, 24, 8, 16, SEG_GRAPH } }, - { 0x19b, { MM_DIRECT, 1280, 1080, 32, 8, 16, SEG_GRAPH } }, + { 0x140, { MM_DIRECT, 320, 200, 32, 8, 16, SEG_GRAPH } }, + { 0x141, { MM_DIRECT, 640, 400, 32, 8, 16, SEG_GRAPH } }, + { 0x142, { MM_DIRECT, 640, 480, 32, 8, 16, SEG_GRAPH } }, + { 0x143, { MM_DIRECT, 800, 600, 32, 8, 16, SEG_GRAPH } }, + { 0x144, { MM_DIRECT, 1024, 768, 32, 8, 16, SEG_GRAPH } }, + { 0x145, { MM_DIRECT, 1280, 1024, 32, 8, 16, SEG_GRAPH } }, + { 0x146, { MM_PACKED, 320, 200, 8, 8, 16, SEG_GRAPH } }, + { 0x147, { MM_DIRECT, 1600, 1200, 32, 8, 16, SEG_GRAPH } }, + { 0x148, { MM_PACKED, 1152, 864, 8, 8, 16, SEG_GRAPH } }, + { 0x149, { MM_DIRECT, 1152, 864, 15, 8, 16, SEG_GRAPH } }, + { 0x14a, { MM_DIRECT, 1152, 864, 16, 8, 16, SEG_GRAPH } }, + { 0x14b, { MM_DIRECT, 1152, 864, 24, 8, 16, SEG_GRAPH } }, + { 0x14c, { MM_DIRECT, 1152, 864, 32, 8, 16, SEG_GRAPH } }, + { 0x175, { MM_DIRECT, 1280, 768, 16, 8, 16, SEG_GRAPH } }, + { 0x176, { MM_DIRECT, 1280, 768, 24, 8, 16, SEG_GRAPH } }, + { 0x177, { MM_DIRECT, 1280, 768, 32, 8, 16, SEG_GRAPH } }, + { 0x178, { MM_DIRECT, 1280, 800, 16, 8, 16, SEG_GRAPH } }, + { 0x179, { MM_DIRECT, 1280, 800, 24, 8, 16, SEG_GRAPH } }, + { 0x17a, { MM_DIRECT, 1280, 800, 32, 8, 16, SEG_GRAPH } }, + { 0x17b, { MM_DIRECT, 1280, 960, 16, 8, 16, SEG_GRAPH } }, + { 0x17c, { MM_DIRECT, 1280, 960, 24, 8, 16, SEG_GRAPH } }, + { 0x17d, { MM_DIRECT, 1280, 960, 32, 8, 16, SEG_GRAPH } }, + { 0x17e, { MM_DIRECT, 1440, 900, 16, 8, 16, SEG_GRAPH } }, + { 0x17f, { MM_DIRECT, 1440, 900, 24, 8, 16, SEG_GRAPH } }, + { 0x180, { MM_DIRECT, 1440, 900, 32, 8, 16, SEG_GRAPH } }, + { 0x181, { MM_DIRECT, 1400, 1050, 16, 8, 16, SEG_GRAPH } }, + { 0x182, { MM_DIRECT, 1400, 1050, 24, 8, 16, SEG_GRAPH } }, + { 0x183, { MM_DIRECT, 1400, 1050, 32, 8, 16, SEG_GRAPH } }, + { 0x184, { MM_DIRECT, 1680, 1050, 16, 8, 16, SEG_GRAPH } }, + { 0x185, { MM_DIRECT, 1680, 1050, 24, 8, 16, SEG_GRAPH } }, + { 0x186, { MM_DIRECT, 1680, 1050, 32, 8, 16, SEG_GRAPH } }, + { 0x189, { MM_DIRECT, 1920, 1200, 32, 8, 16, SEG_GRAPH } }, + { 0x18d, { MM_DIRECT, 1280, 720, 16, 8, 16, SEG_GRAPH } }, + { 0x18e, { MM_DIRECT, 1280, 720, 24, 8, 16, SEG_GRAPH } }, + { 0x18f, { MM_DIRECT, 1280, 720, 32, 8, 16, SEG_GRAPH } }, + { 0x190, { MM_DIRECT, 1920, 1080, 16, 8, 16, SEG_GRAPH } }, + { 0x191, { MM_DIRECT, 1920, 1080, 24, 8, 16, SEG_GRAPH } }, + { 0x192, { MM_DIRECT, 1920, 1080, 32, 8, 16, SEG_GRAPH } }, + { 0x193, { MM_DIRECT, 1600, 900, 16, 8, 16, SEG_GRAPH } }, + { 0x194, { MM_DIRECT, 1600, 900, 24, 8, 16, SEG_GRAPH } }, + { 0x195, { MM_DIRECT, 1600, 900, 32, 8, 16, SEG_GRAPH } }, + { 0x196, { MM_DIRECT, 960, 540, 16, 8, 16, SEG_GRAPH } }, + { 0x197, { MM_DIRECT, 960, 540, 24, 8, 16, SEG_GRAPH } }, + { 0x198, { MM_DIRECT, 960, 540, 32, 8, 16, SEG_GRAPH } }, + { 0x199, { MM_DIRECT, 1280, 1080, 16, 8, 16, SEG_GRAPH } }, + { 0x19a, { MM_DIRECT, 1280, 1080, 24, 8, 16, SEG_GRAPH } }, + { 0x19b, { MM_DIRECT, 1280, 1080, 32, 8, 16, SEG_GRAPH } },
/* other high-definition resolutions */ { 0x19c, { MM_DIRECT, 2048, 1080, 32, 8, 16, SEG_GRAPH } },
When not specifiying the other color depths, some of the resolutions were not appearing as an option on Windows 10.
Signed-off-by: Elliot Killick elliotkillick@zohomail.eu --- vgasrc/svgamodes.c | 84 ++++++++++++++++++++++++++++++++++------------ 1 file changed, 63 insertions(+), 21 deletions(-)
diff --git a/vgasrc/svgamodes.c b/vgasrc/svgamodes.c index ea86c6c..3db2bc5 100644 --- a/vgasrc/svgamodes.c +++ b/vgasrc/svgamodes.c @@ -90,28 +90,70 @@ struct generic_svga_mode svga_modes[] VAR16 = { { 0x19b, { MM_DIRECT, 1280, 1080, 32, 8, 16, SEG_GRAPH } },
/* other high-definition resolutions */ - { 0x19c, { MM_DIRECT, 2048, 1080, 32, 8, 16, SEG_GRAPH } }, - { 0x19d, { MM_DIRECT, 2160, 1080, 32, 8, 16, SEG_GRAPH } }, - { 0x19e, { MM_DIRECT, 2560, 1080, 32, 8, 16, SEG_GRAPH } }, - { 0x19f, { MM_DIRECT, 2560, 1440, 32, 8, 16, SEG_GRAPH } }, - { 0x1a0, { MM_DIRECT, 3200, 1800, 32, 8, 16, SEG_GRAPH } }, - { 0x1a1, { MM_DIRECT, 3440, 1440, 32, 8, 16, SEG_GRAPH } }, - { 0x1a2, { MM_DIRECT, 3840, 1080, 32, 8, 16, SEG_GRAPH } }, - { 0x1a3, { MM_DIRECT, 3840, 1600, 32, 8, 16, SEG_GRAPH } }, - { 0x1a4, { MM_DIRECT, 3840, 2160, 32, 8, 16, SEG_GRAPH } }, - { 0x1a5, { MM_DIRECT, 4096, 2160, 32, 8, 16, SEG_GRAPH } }, - { 0x1a6, { MM_DIRECT, 5120, 2160, 32, 8, 16, SEG_GRAPH } }, - { 0x1a7, { MM_DIRECT, 5120, 2880, 32, 8, 16, SEG_GRAPH } }, - { 0x1a8, { MM_DIRECT, 7680, 4320, 32, 8, 16, SEG_GRAPH } }, - { 0x1a9, { MM_DIRECT, 17280, 4320, 32, 8, 16, SEG_GRAPH } }, + { 0x19c, { MM_DIRECT, 2048, 1080, 16, 8, 16, SEG_GRAPH } }, + { 0x19d, { MM_DIRECT, 2048, 1080, 24, 8, 16, SEG_GRAPH } }, + { 0x19e, { MM_DIRECT, 2048, 1080, 32, 8, 16, SEG_GRAPH } }, + { 0x19f, { MM_DIRECT, 2160, 1080, 16, 8, 16, SEG_GRAPH } }, + { 0x1a0, { MM_DIRECT, 2160, 1080, 24, 8, 16, SEG_GRAPH } }, + { 0x1a1, { MM_DIRECT, 2160, 1080, 32, 8, 16, SEG_GRAPH } }, + { 0x1a2, { MM_DIRECT, 2560, 1080, 16, 8, 16, SEG_GRAPH } }, + { 0x1a3, { MM_DIRECT, 2560, 1080, 24, 8, 16, SEG_GRAPH } }, + { 0x1a4, { MM_DIRECT, 2560, 1080, 32, 8, 16, SEG_GRAPH } }, + { 0x1a5, { MM_DIRECT, 2560, 1440, 16, 8, 16, SEG_GRAPH } }, + { 0x1a6, { MM_DIRECT, 2560, 1440, 24, 8, 16, SEG_GRAPH } }, + { 0x1a7, { MM_DIRECT, 2560, 1440, 32, 8, 16, SEG_GRAPH } }, + { 0x1a8, { MM_DIRECT, 3200, 1800, 16, 8, 16, SEG_GRAPH } }, + { 0x1a9, { MM_DIRECT, 3200, 1800, 24, 8, 16, SEG_GRAPH } }, + { 0x1aa, { MM_DIRECT, 3200, 1800, 32, 8, 16, SEG_GRAPH } }, + { 0x1ab, { MM_DIRECT, 3440, 1440, 16, 8, 16, SEG_GRAPH } }, + { 0x1ac, { MM_DIRECT, 3440, 1440, 24, 8, 16, SEG_GRAPH } }, + { 0x1ad, { MM_DIRECT, 3440, 1440, 32, 8, 16, SEG_GRAPH } }, + { 0x1ae, { MM_DIRECT, 3840, 1080, 16, 8, 16, SEG_GRAPH } }, + { 0x1af, { MM_DIRECT, 3840, 1080, 24, 8, 16, SEG_GRAPH } }, + { 0x1b0, { MM_DIRECT, 3840, 1080, 32, 8, 16, SEG_GRAPH } }, + { 0x1b1, { MM_DIRECT, 3840, 1600, 16, 8, 16, SEG_GRAPH } }, + { 0x1b2, { MM_DIRECT, 3840, 1600, 24, 8, 16, SEG_GRAPH } }, + { 0x1b3, { MM_DIRECT, 3840, 1600, 32, 8, 16, SEG_GRAPH } }, + { 0x1b4, { MM_DIRECT, 3840, 2160, 16, 8, 16, SEG_GRAPH } }, + { 0x1b5, { MM_DIRECT, 3840, 2160, 24, 8, 16, SEG_GRAPH } }, + { 0x1b6, { MM_DIRECT, 3840, 2160, 32, 8, 16, SEG_GRAPH } }, + { 0x1b7, { MM_DIRECT, 4096, 2160, 16, 8, 16, SEG_GRAPH } }, + { 0x1b8, { MM_DIRECT, 4096, 2160, 24, 8, 16, SEG_GRAPH } }, + { 0x1b9, { MM_DIRECT, 4096, 2160, 32, 8, 16, SEG_GRAPH } }, + { 0x1ba, { MM_DIRECT, 5120, 2160, 16, 8, 16, SEG_GRAPH } }, + { 0x1bb, { MM_DIRECT, 5120, 2160, 24, 8, 16, SEG_GRAPH } }, + { 0x1bc, { MM_DIRECT, 5120, 2160, 32, 8, 16, SEG_GRAPH } }, + { 0x1bd, { MM_DIRECT, 5120, 2880, 16, 8, 16, SEG_GRAPH } }, + { 0x1be, { MM_DIRECT, 5120, 2880, 24, 8, 16, SEG_GRAPH } }, + { 0x1bf, { MM_DIRECT, 5120, 2880, 32, 8, 16, SEG_GRAPH } }, + { 0x1c0, { MM_DIRECT, 7680, 4320, 16, 8, 16, SEG_GRAPH } }, + { 0x1c1, { MM_DIRECT, 7680, 4320, 24, 8, 16, SEG_GRAPH } }, + { 0x1c2, { MM_DIRECT, 7680, 4320, 32, 8, 16, SEG_GRAPH } }, + { 0x1c3, { MM_DIRECT, 17280, 4320, 16, 8, 16, SEG_GRAPH } }, + { 0x1c4, { MM_DIRECT, 17280, 4320, 24, 8, 16, SEG_GRAPH } }, + { 0x1c5, { MM_DIRECT, 17280, 4320, 32, 8, 16, SEG_GRAPH } },
/* quad extended graphics array resolutions */ - { 0x1aa, { MM_DIRECT, 2048, 1152, 32, 8, 16, SEG_GRAPH } }, - { 0x1ab, { MM_DIRECT, 2048, 1536, 32, 8, 16, SEG_GRAPH } }, - { 0x1ac, { MM_DIRECT, 2560, 1600, 32, 8, 16, SEG_GRAPH } }, - { 0x1ad, { MM_DIRECT, 2560, 2048, 32, 8, 16, SEG_GRAPH } }, - { 0x1ae, { MM_DIRECT, 3200, 2048, 32, 8, 16, SEG_GRAPH } }, - { 0x1af, { MM_DIRECT, 3200, 2400, 32, 8, 16, SEG_GRAPH } }, - { 0x1b0, { MM_DIRECT, 3840, 2400, 32, 8, 16, SEG_GRAPH } }, + { 0x1c6, { MM_DIRECT, 2048, 1152, 16, 8, 16, SEG_GRAPH } }, + { 0x1c7, { MM_DIRECT, 2048, 1152, 24, 8, 16, SEG_GRAPH } }, + { 0x1c8, { MM_DIRECT, 2048, 1152, 32, 8, 16, SEG_GRAPH } }, + { 0x1c9, { MM_DIRECT, 2048, 1536, 16, 8, 16, SEG_GRAPH } }, + { 0x1ca, { MM_DIRECT, 2048, 1536, 24, 8, 16, SEG_GRAPH } }, + { 0x1cb, { MM_DIRECT, 2048, 1536, 32, 8, 16, SEG_GRAPH } }, + { 0x1cc, { MM_DIRECT, 2560, 1600, 16, 8, 16, SEG_GRAPH } }, + { 0x1cd, { MM_DIRECT, 2560, 1600, 24, 8, 16, SEG_GRAPH } }, + { 0x1ce, { MM_DIRECT, 2560, 1600, 32, 8, 16, SEG_GRAPH } }, + { 0x1cf, { MM_DIRECT, 2560, 2048, 16, 8, 16, SEG_GRAPH } }, + { 0x1d0, { MM_DIRECT, 2560, 2048, 24, 8, 16, SEG_GRAPH } }, + { 0x1d1, { MM_DIRECT, 2560, 2048, 32, 8, 16, SEG_GRAPH } }, + { 0x1d2, { MM_DIRECT, 3200, 2048, 16, 8, 16, SEG_GRAPH } }, + { 0x1d3, { MM_DIRECT, 3200, 2048, 24, 8, 16, SEG_GRAPH } }, + { 0x1d4, { MM_DIRECT, 3200, 2048, 32, 8, 16, SEG_GRAPH } }, + { 0x1d5, { MM_DIRECT, 3200, 2400, 16, 8, 16, SEG_GRAPH } }, + { 0x1d6, { MM_DIRECT, 3200, 2400, 24, 8, 16, SEG_GRAPH } }, + { 0x1d7, { MM_DIRECT, 3200, 2400, 32, 8, 16, SEG_GRAPH } }, + { 0x1d8, { MM_DIRECT, 3840, 2400, 16, 8, 16, SEG_GRAPH } }, + { 0x1d9, { MM_DIRECT, 3840, 2400, 24, 8, 16, SEG_GRAPH } }, + { 0x1da, { MM_DIRECT, 3840, 2400, 32, 8, 16, SEG_GRAPH } }, }; unsigned int svga_mcount VAR16 = ARRAY_SIZE(svga_modes);
On Tue, May 04, 2021 at 07:43:35PM -0400, Elliot Killick via SeaBIOS wrote:
Hi,
This patch series adds support for all HD and QXGA resolutions.
I've taken Gerd's advice on the v1 patch and split the formatting improvments into a separate patch.
I also tried to take Gerd's advice on removing some of the older colors depths for higher resolutions. However, upon doing this Windows was no longer recognizing some of the resolutions so I had to add them back. I split that up into a separate patch in case anyone wants to try and reproduce the issue. But, it should be fine to include those common color depths anyway for maximal compatibility.
Thanks, and sorry for the delay in responding.
In general it looks fine to me, but I was hoping Gerd could take a look as well. As one minor nit, I think it would be preferable to squash patch 2 and 3 as it seems odd to remove the modes just to add them back again.
Cheers, -Kevin
On Thu, May 20, 2021 at 01:55:12PM -0400, Kevin O'Connor wrote:
On Tue, May 04, 2021 at 07:43:35PM -0400, Elliot Killick via SeaBIOS wrote:
Hi,
This patch series adds support for all HD and QXGA resolutions.
I've taken Gerd's advice on the v1 patch and split the formatting improvments into a separate patch.
I also tried to take Gerd's advice on removing some of the older colors depths for higher resolutions. However, upon doing this Windows was no longer recognizing some of the resolutions so I had to add them back. I split that up into a separate patch in case anyone wants to try and reproduce the issue. But, it should be fine to include those common color depths anyway for maximal compatibility.
Thanks, and sorry for the delay in responding.
In general it looks fine to me, but I was hoping Gerd could take a look as well.
Looks sane to me.
As one minor nit, I think it would be preferable to squash patch 2 and 3 as it seems odd to remove the modes just to add them back again.
You mean squash 1+3 I guess?
take care, Gerd
On Fri, May 21, 2021 at 11:03:00AM +0200, Gerd Hoffmann wrote:
On Thu, May 20, 2021 at 01:55:12PM -0400, Kevin O'Connor wrote:
On Tue, May 04, 2021 at 07:43:35PM -0400, Elliot Killick via SeaBIOS wrote:
Hi,
This patch series adds support for all HD and QXGA resolutions.
I've taken Gerd's advice on the v1 patch and split the formatting improvments into a separate patch.
I also tried to take Gerd's advice on removing some of the older colors depths for higher resolutions. However, upon doing this Windows was no longer recognizing some of the resolutions so I had to add them back. I split that up into a separate patch in case anyone wants to try and reproduce the issue. But, it should be fine to include those common color depths anyway for maximal compatibility.
Thanks, and sorry for the delay in responding.
In general it looks fine to me, but I was hoping Gerd could take a look as well.
Looks sane to me.
As one minor nit, I think it would be preferable to squash patch 2 and 3 as it seems odd to remove the modes just to add them back again.
You mean squash 1+3 I guess?
Sorry, yes.
-Kevin
-
Elliot Killick -
Gerd Hoffmann -
Kevin O'Connor