Re: [SeaBIOS] [PATCH 00/10] Xenstore communication support for Seabios

[Daniel Castro]

On Mon, Aug 29, 2011 at 1:15 AM, Kevin O'Connor <[e-mail]> wrote:
> On Thu, Aug 25, 2011 at 10:22:43AM +0100, Ian Campbell wrote:
> > On Tue, 2011-08-23 at 21:10 -0400, Kevin O'Connor wrote:
> > > It looks to me like this patch series adds capabilities that a later
> > > patch series will use. The patch series itself looks okay to me
> > > (though, I do find the multiple copyright statements in the middle of
> > > xen.h confusing).
> >
> > That is a consequence of mashing bits of multiple Xen public headers
> > into a single xen.h. We could fracture it into xen/*.h instead if that
> > would be preferable?
>
> How about just moving all the copyright notices next to the license
> text.

I think it is important to be able to trace the header to a specific
file in the xen headers. It will make it easier to read and
understand.
> -Kevin