Re: [SeaBIOS] [PATCH] KVM vcpu hotplug seabios infrastructure

[Isaku Yamahata]

Hi Jison.

Can you check the changeset of 12cbb43b9dc8a16f712188cb308a0eb0321f3e20
and update Makefile changes?

The rule for acpi-ssdt-15.hex and acpi-ssdt-anycpu.hex seems
same, so it can be combined into a single generic rule.
The rules removes the files at the last, but it would be more
reliable to use Makefile intermediate and let make to remove
them automatically.

On Sun, Jun 20, 2010 at 11:40:02PM +0800, Liu, Jinsong wrote:
> Kevin O'Connor wrote:
> > On Wed, Jun 16, 2010 at 12:19:24PM +0800, Liu, Jinsong wrote:
> > > Gleb Natapov wrote:
> > > > FWIW looks good to me. This patch removes dynamic creation of
> > > > Processor scope and supports only 15/255 cpus configuration, but
> > > > given that new code is much more complex that old one I don't see
> > > > other possibilities (unless we'll add aml compiler to seabios
> > > > runtime).
> > I'm okay with the approach (two SSDTs selected by cpu count).  The
> > build changes don't look right (15.c is too cryptic).  However, more
> > importantly, I want to see where we end up going with the qemu/seabios
> > acpi interface discussion before committing this.
> >
> > -Kevin
>
> Kevin,
>
> Thanks for comments!
>
> In your last comments, you prefer not to use iasl to compile seabios.
> Now I update the patch as attached (only need update Makefile):
> cancel cryptic name like 15.c from Makefile, and we give detailed description for cpu number in new version;
> user don't need iasl again to compile seabios, except if they want to change dsdt/ssdt itself;
>
> The process to apply patch and build in my desktop is:
> $ git apply kvm-vcpu-hotplug-seabios.patch
> $ git add src/acpi-ssdt.dsl
> $ git add src/mk_ssdt.c
> $ git add src/acpi-ssdt-15.hex
> $ git add src/acpi-ssdt-anycpu.hex
> $ git commit -a
> $ make
>
> We test the updated patch, it works OK with linux2.6.32 hot-add and hot-remove.
>
> Thanks,
> Jinsong
> SeaBIOS mailing list
> [e-mail]
> http://www.seabios.org/mailman/listinfo/seabios

[PATCH] KVM vcpu hotplug seabios infrastructure

[Liu, Jinsong]

Isaku,

Thanks for comments!
I didn't fine changeset 12cbb43b9dc8a16f712188cb308a0eb0321f3e20, I pull from git://git.kernel.org/pub/scm/virt/kvm/seabios.git, any misunderstanding?

As for makefile rule for acpi-ssdt-15.hex and acpi-ssdt-anycpu.hex, we in fact combine them into 1 generic rule in our old patch, as attached.
However, the old makefile require iasl for user compiling seabios.
Kevin prefer not using iasl, so we update it as new version.

Thanks,
Jinsong

Isaku Yamahata wrote:
> Hi Jison.
>
> Can you check the changeset of
> 12cbb43b9dc8a16f712188cb308a0eb0321f3e20 and update Makefile changes?
>
> The rule for acpi-ssdt-15.hex and acpi-ssdt-anycpu.hex seems
> same, so it can be combined into a single generic rule.
> The rules removes the files at the last, but it would be more
> reliable to use Makefile intermediate and let make to remove
> them automatically.
>
> On Sun, Jun 20, 2010 at 11:40:02PM +0800, Liu, Jinsong wrote:
> > Kevin O'Connor wrote:
> > > On Wed, Jun 16, 2010 at 12:19:24PM +0800, Liu, Jinsong wrote:
> > > > Gleb Natapov wrote:
> > > > > FWIW looks good to me. This patch removes dynamic creation of
> > > > > Processor scope and supports only 15/255 cpus configuration, but
> > > > > given that new code is much more complex that old one I don't see
> > > > > other possibilities (unless we'll add aml compiler to seabios
> > > > > runtime).
> > > I'm okay with the approach (two SSDTs selected by cpu count).  The
> > > build changes don't look right (15.c is too cryptic).  However, more
> > > importantly, I want to see where we end up going with the
> > > qemu/seabios acpi interface discussion before committing this.
> > >
> > > -Kevin
> >
> > Kevin,
> >
> > Thanks for comments!
> >
> > In your last comments, you prefer not to use iasl to compile seabios.
> > Now I update the patch as attached (only need update Makefile):
> > cancel cryptic name like 15.c from Makefile, and we give detailed
> >
> > description for cpu number in new version; 
> > 2. user don't need iasl again to compile seabios, except if they
> > want to change dsdt/ssdt itself;
> >
> > The process to apply patch and build in my desktop is:
> > $ git apply kvm-vcpu-hotplug-seabios.patch
> > $ git add src/acpi-ssdt.dsl
> > $ git add src/mk_ssdt.c
> > $ git add src/acpi-ssdt-15.hex
> > $ git add src/acpi-ssdt-anycpu.hex
> > $ git commit -a
> > $ make
> >
> > We test the updated patch, it works OK with linux2.6.32 hot-add and
> > hot-remove.
> >
> > Thanks,
> > Jinsong
> > SeaBIOS mailing list
> > [e-mail]
> > http://www.seabios.org/mailman/listinfo/seabios

[PATCH] KVM vcpu hotplug seabios infrastructure

[Liu, Jinsong]

Liu, Jinsong wrote:
> Isaku,
>
> Thanks for comments!
> I didn't fine changeset 12cbb43b9dc8a16f712188cb308a0eb0321f3e20, I

Sorry, mis-type. I mean 'I didn't find changeset ...'
> pull from git://git.kernel.org/pub/scm/virt/kvm/seabios.git, any
> misunderstanding?
>
> As for makefile rule for acpi-ssdt-15.hex and acpi-ssdt-anycpu.hex,
> we in fact combine them into 1 generic rule in our old patch, as
> attached. However, the old makefile require iasl for user compiling
> seabios.  
> Kevin prefer not using iasl, so we update it as new version.
>
> Thanks,
> Jinsong
>
> Isaku Yamahata wrote:
> > Hi Jison.
> >
> > Can you check the changeset of
> > 12cbb43b9dc8a16f712188cb308a0eb0321f3e20 and update Makefile changes?
> >
> > The rule for acpi-ssdt-15.hex and acpi-ssdt-anycpu.hex seems
> > same, so it can be combined into a single generic rule.
> > The rules removes the files at the last, but it would be more
> > reliable to use Makefile intermediate and let make to remove
> > them automatically.