[[PATCH] ] Prevent build failure by not splitting line in the middle of arguments to checkrom.py script

[Sander Eikelenboom]

File "./scripts/checkrom.py", line 24, in main
    objinfo, finalsize, rawfile, outfile = sys.argv[1:]
ValueError: need more than 3 values to unpack

Signed-off-by: Sander Eikelenboom 
---
 Makefile |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index cb15217..8efc902 100644
--- a/Makefile
+++ b/Makefile
@@ -182,8 +182,7 @@ $(OUT)bios.bin.prep: $(OUT)rom.o scripts/checkrom.py
    $(Q)rm -f $(OUT)bios.bin $(OUT)Csm16.bin $(OUT)bios.bin.elf
    $(Q)$(OBJDUMP) -thr $< > $<.objdump
    $(Q)$(OBJCOPY) -O binary $< $(OUT)bios.bin.raw
-	$(Q)$(PYTHON) ./scripts/checkrom.py $<.objdump $(CONFIG_ROM_SIZE) \
-		$(OUT)bios.bin.raw $(OUT)bios.bin.prep
+	$(Q)$(PYTHON) ./scripts/checkrom.py $<.objdump $(CONFIG_ROM_SIZE) $(OUT)bios.bin.raw $(OUT)bios.bin.prep

$(OUT)bios.bin: $(OUT)bios.bin.prep
    @echo "  Creating $@"

[[PATCH] ] Prevent build failure by not splitting line in the middle of arguments to checkrom.py script

[Kevin O'Connor]

On Thu, Jan 09, 2014 at 08:18:43PM +0100, Sander Eikelenboom wrote:
> File "./scripts/checkrom.py", line 24, in main
>     objinfo, finalsize, rawfile, outfile = sys.argv[1:]
> ValueError: need more than 3 values to unpack

That doesn't fail for me - what OS / distribution are you using to
build?

-Kevin

[[PATCH] ] Prevent build failure by not splitting line in the middle of arguments to checkrom.py script

[Sander Eikelenboom]

Friday, January 10, 2014, 2:13:42 AM, you wrote:
> On Thu, Jan 09, 2014 at 08:18:43PM +0100, Sander Eikelenboom wrote:
> > File "./scripts/checkrom.py", line 24, in main
> >     objinfo, finalsize, rawfile, outfile = sys.argv[1:]
> > ValueError: need more than 3 values to unpack
> That doesn't fail for me - what OS / distribution are you using to
> build?

It occurs when building as part of Xen, on Debian wheezy.
> -Kevin

[[PATCH] ] Prevent build failure by not splitting line in the middle of arguments to checkrom.py script

[Kevin O'Connor]

On Fri, Jan 10, 2014 at 10:00:13AM +0100, Sander Eikelenboom wrote:
> Friday, January 10, 2014, 2:13:42 AM, you wrote:
> > On Thu, Jan 09, 2014 at 08:18:43PM +0100, Sander Eikelenboom wrote:
> > > File "./scripts/checkrom.py", line 24, in main
> > >     objinfo, finalsize, rawfile, outfile = sys.argv[1:]
> > > ValueError: need more than 3 values to unpack
> > That doesn't fail for me - what OS / distribution are you using to
> > build?
>
> It occurs when building as part of Xen, on Debian wheezy.

Thanks.  I suspect there must be something else contributing to the
failure, but your patch makes sense so I have pushed it to the main
repo.

-Kevin

[[PATCH] ] Prevent build failure by not splitting line in the middle of arguments to checkrom.py script

[Sander Eikelenboom]

Friday, January 10, 2014, 7:14:15 PM, you wrote:
> On Fri, Jan 10, 2014 at 10:00:13AM +0100, Sander Eikelenboom wrote:
> > Friday, January 10, 2014, 2:13:42 AM, you wrote:
> > > On Thu, Jan 09, 2014 at 08:18:43PM +0100, Sander Eikelenboom wrote:
> > > > File "./scripts/checkrom.py", line 24, in main
> > > >     objinfo, finalsize, rawfile, outfile = sys.argv[1:]
> > > > ValueError: need more than 3 values to unpack
> > > That doesn't fail for me - what OS / distribution are you using to
> > > build?
> >
> > It occurs when building as part of Xen, on Debian wheezy.
> Thanks.  I suspect there must be something else contributing to the
> failure, but your patch makes sense so I have pushed it to the main
> repo.

I didn't saw any other python line being wrapped in that Makefile, although there were even longer ones
and i don't know if it uses that checkrom.py script on every build.

Any how thx !
> -Kevin