[PATCH] vgabios: Improve Kconfig descriptions for the vga card types.

[Kevin O'Connor]

Signed-off-by: Kevin O'Connor 
---
 vgasrc/Kconfig |   17 +++++++++--------
 1 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/vgasrc/Kconfig b/vgasrc/Kconfig
index c436aeb..6b22c39 100644
--- a/vgasrc/Kconfig
+++ b/vgasrc/Kconfig
@@ -12,13 +12,14 @@ menu "VGA ROM"

config VGA_STANDARD_VGA
             depends on !COREBOOT
-            bool "Standard VGA"
+            bool "QEMU/Bochs Original IBM 256K VGA"
             help
-                Build basic VGA BIOS support for use on emulators.
+                Build basic VGA BIOS support (pre Super-VGA) for use
+                on emulators.

config VGA_CIRRUS
             depends on !COREBOOT
-            bool "QEMU Cirrus CLGD 54xx VGA BIOS"
+            bool "QEMU/Bochs Cirrus SVGA"
             help
                 Build support for Cirrus VGA emulation found on QEMU
                 and Bochs emulators.  This is for emulators; it is not
@@ -26,18 +27,18 @@ menu "VGA ROM"

config VGA_BOCHS
             depends on !COREBOOT
-            bool "Bochs DISPI interface VGA BIOS"
+            bool "QEMU/Bochs VBE SVGA"
             help
-                Build support for Bochs DISPI interface found on QEMU
-                and Bochs emulators.
+                Build support for Bochs DISPI interface (a custom VBE
+                protocol) found on QEMU and Bochs emulators.

config VGA_GEODEGX2
-            bool "GeodeGX2 interface VGA BIOS"
+            bool "GeodeGX2"
             help
                 Build support for Geode GX2 vga.

config VGA_GEODELX
-            bool "GeodeLX interface VGA BIOS"
+            bool "GeodeLX"
             help
                 Build support for Geode LX vga.
     endchoice

[PATCH] vgabios: Improve Kconfig descriptions for the vga card types.

[Peter Stuge]

Kevin O'Connor wrote:
> @@ -26,18 +27,18 @@ menu "VGA ROM"
>      config VGA_BOCHS
>          depends on !COREBOOT
>        bool "Bochs DISPI interface VGA BIOS"
>        bool "QEMU/Bochs VBE SVGA"

Maybe "VESA" ?

Either way:

Acked-by: Peter Stuge

[PATCH] vgabios: Improve Kconfig descriptions for the vga card types.

[Gerhard Wiesinger]

On 17.04.2012 03:22, Kevin O'Connor wrote:
> Signed-off-by: Kevin O'Connor
>
> vgasrc/Kconfig |   17 +++++++++--------
>   1 files changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/vgasrc/Kconfig b/vgasrc/Kconfig
> index c436aeb..6b22c39 100644
> --- a/vgasrc/Kconfig
> +++ b/vgasrc/Kconfig
> @@ -12,13 +12,14 @@ menu "VGA ROM"
>       config VGA_STANDARD_VGA
>           depends on !COREBOOT
>        bool "Standard VGA"
>        bool "QEMU/Bochs Original IBM 256K VGA"
>         help
>            Build basic VGA BIOS support for use on emulators.
>            Build basic VGA BIOS support (pre Super-VGA) for use
>            on emulators.
>
>     config VGA_CIRRUS
>         depends on !COREBOOT
>        bool "QEMU Cirrus CLGD 54xx VGA BIOS"
>        bool "QEMU/Bochs Cirrus SVGA"
>         help
>             Build support for Cirrus VGA emulation found on QEMU
>             and Bochs emulators.  This is for emulators; it is not
>
> @@ -26,18 +27,18 @@ menu "VGA ROM"
>       config VGA_BOCHS
>           depends on !COREBOOT
>        bool "Bochs DISPI interface VGA BIOS"
>        bool "QEMU/Bochs VBE SVGA"
>         help
>            Build support for Bochs DISPI interface found on QEMU
>            and Bochs emulators.
>            Build support for Bochs DISPI interface (a custom VBE
>            protocol) found on QEMU and Bochs emulators.
>
>     config VGA_GEODEGX2
>        bool "GeodeGX2 interface VGA BIOS"
>        bool "GeodeGX2"
>         help
>             Build support for Geode GX2 vga.
>
>     config VGA_GEODELX
>        bool "GeodeLX interface VGA BIOS"
>        bool "GeodeLX"
>         help
>             Build support for Geode LX vga.
> endchoice

Hello Kevin,

Don't think reducing to GeodeGX2 and GeodeLX is a good idea. It would 
tell e.g. nothing what that should mean. With interface VGA BIOS I know 
how I should answer this question.

Ciao
Gerhard

[PATCH] vgabios: Improve Kconfig descriptions for the vga card types.

[Kevin O'Connor]

On Tue, Apr 17, 2012 at 08:44:25AM +0200, Gerhard Wiesinger wrote:
> On 17.04.2012 03:22, Kevin O'Connor wrote:

[...]
> >      config VGA_GEODEGX2
> >        bool "GeodeGX2 interface VGA BIOS"
> >        bool "GeodeGX2"
> >        help
> >            Build support for Geode GX2 vga.
> >
> >    config VGA_GEODELX
> >        bool "GeodeLX interface VGA BIOS"
> >        bool "GeodeLX"
> >        help
> >            Build support for Geode LX vga.
> > endchoice
>
> Don't think reducing to GeodeGX2 and GeodeLX is a good idea. It
> would tell e.g. nothing what that should mean. With interface VGA
> BIOS I know how I should answer this question.

It's in a choice field titled "VGA Hardware Type":

menu "VGA ROM"
    choice
        prompt "VGA Hardware Type"

So, I think the extra text is redundant.

-Kevin