Re: [SeaBIOS] [PATCH] tpm: Move standard definitions from tcgbios.h to new file std/tcg.h
On Thu, Nov 19, 2015 at 06:33:59PM -0500, Stefan Berger wrote:
Let me know how to proceed on the menu part. Do you agree with the last code I had posted module the fact that once we leave the menu you want the machine to be reset? It is not necessary to do that, but we can do it. From a TPM perspective machine resets are only necessary when certain TPM state changes are done.
It's been a while since I last looked at that. My only real concern is minimizing the impact to the non-tpm seabios code. I'd prefer not to change the main SeaBIOS boot prompt, and adding loops (or loops via gotos) to the boot menu code seems strange to me. Outside of that, I don't have a preference on whether TPM resets the machine or not.
-Kevin
"Kevin O'Connor" kevin@koconnor.net wrote on 11/19/2015 07:07:27 PM:
From: "Kevin O'Connor" kevin@koconnor.net
On Thu, Nov 19, 2015 at 06:33:59PM -0500, Stefan Berger wrote:
Let me know how to proceed on the menu part. Do you agree with the
last
code I had posted module the fact that once we leave the menu you want
the
machine to be reset? It is not necessary to do that, but we can do it.
From a TPM perspective machine resets are only necessary when certain
TPM
state changes are done.
It's been a while since I last looked at that. My only real concern is minimizing the impact to the non-tpm seabios code. I'd prefer not to change the main SeaBIOS boot prompt, and adding loops (or loops via
Though adding an additional boot *menu item* is ok?
gotos) to the boot menu code seems strange to me. Outside of that, I
Once the user selects the TPM submenu and then leaves it, what should happen? If we reset the machine, we wouldn't need to add a loop because there is no way to go back to the main menu. Otherwise getting back into the previous menu seem 'normal'.
Stefan
don't have a preference on whether TPM resets the machine or not.
-Kevin
-
Kevin O'Connor -
Stefan Berger