Re: [SeaBIOS] SeaBIOS build problem

[Ian Campbell]

On Mon, 2012-02-20 at 09:22 +0000, Roger Pau Monné wrote:
> Hello,
>
> When compiling SeaBIOS with busybox and uclibc 0.9.33, I've hit the
> following error:
>
> Build Kconfig config file
>   Compiling whole program out/ccode.16.s
>   Compiling to assembler out/asm-offsets.s
>   Generating offset file out/asm-offsets.h
> gen-offsets.sh: applet not found

I guess this means your shell comes from busybox?
> When looking into gen-offsets.sh [0] I've realized there's a strange
> shebang in the script ":", is this normal? Replacing ":" with
> "#!/bin/sh" solves the problem, but I don't understand why the ":"
> shebang works for some (on Debian stable it works ok) and what it
> means.

I've no idea either -- I've copied the seabios ML.

Ian.
> Thanks, Roger.
>
> [0] http://code.coreboot.org/p/seabios/source/tree/rel-1.6.3.1/tools/gen-offsets...

SeaBIOS build problem

[Roger Pau Monné]

2012/2/20 Ian Campbell :
> On Mon, 2012-02-20 at 09:22 +0000, Roger Pau Monné wrote:
> > Hello,
> >
> > When compiling SeaBIOS with busybox and uclibc 0.9.33, I've hit the
> > following error:
> >
> > Build Kconfig config file
> >   Compiling whole program out/ccode.16.s
> >   Compiling to assembler out/asm-offsets.s
> >   Generating offset file out/asm-offsets.h
> > gen-offsets.sh: applet not found
>
> I guess this means your shell comes from busybox?

Yes, the shell I'm using is ash [0], this is the default shell for busybox.

[0] http://www.in-ulm.de/~mascheck/various/ash/
> > When looking into gen-offsets.sh [0] I've realized there's a strange
> > shebang in the script ":", is this normal? Replacing ":" with
> > "#!/bin/sh" solves the problem, but I don't understand why the ":"
> > shebang works for some (on Debian stable it works ok) and what it
> > means.
>
> I've no idea either -- I've copied the seabios ML.

I can submit a patch replacing ":" with "#!/bin/sh", but I didn't do
it because I have no idea what ":" means in a shebang.
> Ian.
> > Thanks, Roger.
> >
> > [0] http://code.coreboot.org/p/seabios/source/tree/rel-1.6.3.1/tools/gen-offsets...

SeaBIOS build problem

[Kevin O'Connor]

On Mon, Feb 20, 2012 at 09:48:48AM +0000, Ian Campbell wrote:
> On Mon, 2012-02-20 at 09:22 +0000, Roger Pau Monné wrote:
> > When looking into gen-offsets.sh [0] I've realized there's a strange
> > shebang in the script ":", is this normal? Replacing ":" with
> > "#!/bin/sh" solves the problem, but I don't understand why the ":"
> > shebang works for some (on Debian stable it works ok) and what it
> > means.
>
> I've no idea either -- I've copied the seabios ML.

It's an old-style way of indicating the file is a shell script.  I
wasn't aware this creeped in there - it should be converted to the
more standard style.

-Kevin

commit 0fd9953a538b22e6087f9d4f25749e3622e40e87
Author: Kevin O'Connor 
Date:   Mon Feb 20 09:33:23 2012 -0500

Use "#!/bin/sh" instead of ":" in tools/gen-offsets.sh.

Signed-off-by: Kevin O'Connor

diff --git a/tools/gen-offsets.sh b/tools/gen-offsets.sh
index 99fdc53..73dede8 100755
--- a/tools/gen-offsets.sh
+++ b/tools/gen-offsets.sh
@@ -1,4 +1,4 @@
-:
+#!/bin/sh
 # Extract definitions from an assembler file.  This is based on code
 # from the Linux Kernel.
 INFILE=$1

SeaBIOS build problem

[Roger Pau Monné]

2012/2/20 Kevin O'Connor :
> On Mon, Feb 20, 2012 at 09:48:48AM +0000, Ian Campbell wrote:
> > On Mon, 2012-02-20 at 09:22 +0000, Roger Pau Monné wrote:
> > > When looking into gen-offsets.sh [0] I've realized there's a strange
> > > shebang in the script ":", is this normal? Replacing ":" with
> > > "#!/bin/sh" solves the problem, but I don't understand why the ":"
> > > shebang works for some (on Debian stable it works ok) and what it
> > > means.
> >
> > I've no idea either -- I've copied the seabios ML.
>
> It's an old-style way of indicating the file is a shell script.  I
> wasn't aware this creeped in there - it should be converted to the
> more standard style.
>
> -Kevin
>
> commit 0fd9953a538b22e6087f9d4f25749e3622e40e87
> Author: Kevin O'Connor 
> Date:   Mon Feb 20 09:33:23 2012 -0500
>
> Use "#!/bin/sh" instead of ":" in tools/gen-offsets.sh.
>
> Signed-off-by: Kevin O'Connor

Don't know if it's ok to Ack this, if not please ignore it and
consider this a Tested-by:

Acked-by: Roger Pau Monné
> diff --git a/tools/gen-offsets.sh b/tools/gen-offsets.sh
> index 99fdc53..73dede8 100755
> --- a/tools/gen-offsets.sh
> +++ b/tools/gen-offsets.sh
> @@ -1,4 +1,4 @@
> -:
> +#!/bin/sh
>  # Extract definitions from an assembler file.  This is based on code
>  # from the Linux Kernel.
>  INFILE=$1