On Sat, Aug 21, 2010 at 03:12:32PM -0400, Kevin O'Connor wrote:
On Wed, Aug 18, 2010 at 05:46:20PM +0300, Gleb Natapov
Windows XP does write to sector 0 during
installation and prints
mysterious error if write fails. Interestingly if write drops data,
but returns OK to Windows installer installation proceed without
complains and completes successfully.
+ case CMD_FORMAT:
If CMD_WRITE is implemented, I think CMD_FORMAT should just return
DISK_RET_SUCCESS (as ata does).
Can you explain why? What CMD_FORMAT is suppose to do? May be it is just
a nop for virtio disk and returning success is much better in this case.
Otherwise, looks okay to me.