master is broken

[Gerd Hoffmann]

Hi,

Switching the list handling broke pci initialization.
Commit aab42152881dc62b37f1833e79cbdb3dfa51603b seems to be the culprit.

--- log-446defb 2013-06-13 11:53:38.444435298 +0200
+++ log-aab4215 2013-06-13 11:53:11.137304303 +0200
@@ -1,8 +1,8 @@
-Start bios (version
rel-1.7.2-132-g446defb-20130613_115336-rincewind.home.kraxel.org)
+Start bios (version
rel-1.7.2-133-gaab4215-20130613_115307-rincewind.home.kraxel.org)
 No Xen hypervisor found.
 Running on KVM
 Ram Size=0x40000000 (0x0000000000000000 high)
-Relocating init from 0x000e0e18 to 0x3ffdfc00 (size 66356)
+Relocating init from 0x000e0d68 to 0x3ffdfb60 (size 66524)
 Found QEMU fw_cfg
 CPU Mhz=2797
 === PCI bus & bridge init ===
@@ -13,10 +13,8 @@ Found 6 PCI devices (max PCI bus is 00)
 PCI: check devices
 === PCI new allocation pass #2 ===
 PCI: map device bdf=00:01.2  bar 4, addr 0000c000, size 00000020 [io]
-PCI: map device bdf=00:01.1  bar 4, addr 0000c020, size 00000010 [io]
-PCI: map device bdf=00:02.0  bar 6, addr febe0000, size 00010000 [mem]
-PCI: map device bdf=00:02.0  bar 1, addr febf0000, size 00001000 [mem]
-PCI: map device bdf=00:02.0  bar 0, addr fc000000, size 02000000 [prefmem]
+PCI: map device bdf=00:02.0  bar 6, addr febef000, size 00010000 [mem]
+PCI: map device bdf=00:00.0  bar 1566990182, addr fc000000, size
c366fcfaf4fbc366 [S<FF>]
 PCI: init bdf=00:00.0 id=8086:1237
 PCI: init bdf=00:01.0 id=8086:7000
 PIIX3/PIIX4 init: elcr=00 0c
@@ -35,7 +33,7 @@ Scan for VGA option rom
[ more stuff snipped ]

cheers,
  Gerd

[Kevin O'Connor]

On Thu, Jun 13, 2013 at 11:59:15AM +0200, Gerd Hoffmann wrote:
> Hi,
>
> Switching the list handling broke pci initialization.
> Commit aab42152881dc62b37f1833e79cbdb3dfa51603b seems to be the culprit.

Thanks.  I reverted that patch while I take another look at it.  Sorry
about that.

-Kevin

[Kevin O'Connor]

On Thu, Jun 13, 2013 at 08:45:02AM -0400, Kevin O'Connor wrote:
> On Thu, Jun 13, 2013 at 11:59:15AM +0200, Gerd Hoffmann wrote:
> > Hi,
> >
> > Switching the list handling broke pci initialization.
> > Commit aab42152881dc62b37f1833e79cbdb3dfa51603b seems to be the culprit.
>
> Thanks.  I reverted that patch while I take another look at it.  Sorry
> about that.

Somehow I messed up the hlist_for_each_entry_safe macro.  I've
corrected that and re-applied the pciinit list conversion patch.

-Kevin

[Gerd Hoffmann]

On 06/14/13 02:51, Kevin O'Connor wrote:
> On Thu, Jun 13, 2013 at 08:45:02AM -0400, Kevin O'Connor wrote:
> > On Thu, Jun 13, 2013 at 11:59:15AM +0200, Gerd Hoffmann wrote:
> > > Hi,
> > >
> > > Switching the list handling broke pci initialization.
> > > Commit aab42152881dc62b37f1833e79cbdb3dfa51603b seems to be the culprit.
> >
> > Thanks.  I reverted that patch while I take another look at it.  Sorry
> > about that.
>
> Somehow I messed up the hlist_for_each_entry_safe macro.  I've
> corrected that and re-applied the pciinit list conversion patch.

Works now, thanks.

cheers,
  Gerd