Re: [SeaBIOS] [PATCH 4/4] Start using Kconfig to configure SeaBIOS settings.

[Stefan Reinauer]

* Kevin O'Connor <[e-mail]> [110127 03:38]:
> Create autoconf.h during the build.
>
> Move a couple of config settings from config.h to Kconfig.
> --- a/Makefile
> +++ b/Makefile
> @@ -119,11 +119,11 @@ $(OUT)asm-offsets.h: $(OUT)asm-offsets.s
>   $(Q)./tools/gen-offsets.sh $< $@
>
> -$(OUT)ccode.16.s: ; $(call whole-compile, $(CFLAGS16) -S, $(addprefix src/, $(SRC16)),$@)
> +$(OUT)ccode.16.s: out/autoconf.h ; $(call whole-compile, $(CFLAGS16) -S, $(addprefix src/, $(SRC16)),$@)
>
> -$(OUT)code32seg.o: ; $(call whole-compile, $(CFLAGS32SEG), $(addprefix src/, $(SRC32SEG)),$@)
> +$(OUT)code32seg.o: out/autoconf.h ; $(call whole-compile, $(CFLAGS32SEG), $(addprefix src/, $(SRC32SEG)),$@)
>
> -$(OUT)ccode32flat.o: ; $(call whole-compile, $(CFLAGS32FLAT), $(addprefix src/, $(SRC32FLAT)),$@)
> +$(OUT)ccode32flat.o: out/autoconf.h ; $(call whole-compile, $(CFLAGS32FLAT), $(addprefix src/, $(SRC32FLAT)),$@)

I think this should be $(OUT) not out/

Stefan

[PATCH 4/4] Start using Kconfig to configure SeaBIOS settings.

[Kevin O'Connor]

On Fri, Jan 28, 2011 at 03:45:09AM +0100, Stefan Reinauer wrote:
> * Kevin O'Connor <[e-mail]> [110127 03:38]:
> > Create autoconf.h during the build.
> >
> > Move a couple of config settings from config.h to Kconfig.

[...]
> > -$(OUT)ccode32flat.o: ; $(call whole-compile, $(CFLAGS32FLAT), $(addprefix src/, $(SRC32FLAT)),$@)
> > +$(OUT)ccode32flat.o: out/autoconf.h ; $(call whole-compile, $(CFLAGS32FLAT), $(addprefix src/, $(SRC32FLAT)),$@)
>
> I think this should be $(OUT) not out/

Agreed.

-Kevin