[SeaBIOS] Re: [PATCH v4] Add basic MXM 3.0 interrupt support

[Kevin O'Connor]

On Sun, Apr 14, 2024 at 05:56:31PM +0000, Riku Viitanen wrote:
> > I think it would be preferable if mxm_setup() was passed the pci
> > device for uniformity, and have mxm_setup() call romfile_xxx() itself.
>
> Do you mean, run mxm30_setup unconditionally?
> And it checks if the file exists:
> else if (mxm30_setup(pci))
>     /* nothing left to do here */

That's fine - or something like:

int ret = mxm30_setup(pci);
    if (!ret)
        return;

-Kevin