Re: [SeaBIOS] [PATCH 1/2] config: allow DEBUG_IO for !QEMU

[Kevin O'Connor]

On Mon, Jun 03, 2013 at 08:06:23AM +0200, Gerd Hoffmann wrote:
> Make DEBUG_IO depend on QEMU_HARDWARE instead of QEMU, so
> it can be enabled for seabios builds running indirectly
> (coreboot, csm) on qemu.
>
> Add runtime check for PF_QEMU to debug port console to make
> sure we don't poke on random ports on physical hardware.

[...]
> @@ -77,7 +78,7 @@ putc_debug(struct putcinfo *action, char c)
>  {
>      if (! CONFIG_DEBUG_LEVEL)
>          return;
> if (CONFIG_DEBUG_IO)
> if (CONFIG_DEBUG_IO && (PlatformRunningOn & PF_QEMU))

This should use runningOnQEMU() so it supports 16bit code and for the
optimizations it does.

Otherwise, this and patch 2 look fine to me.

-Kevin