Re: [SeaBIOS] [PATCH 1/8] Rename defines to better match a well defined naming schema

[Peter Stuge]

Hi Christian,

Christian Gmeiner wrote:
> The following nameing schema is used:
>     PART_REGISTER_BIT_DESCRIPTION

The changes in the patch set look good to me, but *please* touch up
the commit message summaries so that it is obvious what the changes
affect.

The summary of the first patch:

"Rename defines to better match a well defined naming schema"

Says that this patch changes "defines" - and nothing more specific.

What defines?

Looking *at* the diffstat for the patch it is clear that only
geodevga is changed. The exact same thing applies to all the other
patches.

I would suggest to prefix all commit message summaries with

geodevga:

//Peter