Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

[Peter Stuge]

Gerd Hoffmann wrote:
> >        pci_config_maskw(bdf, PCI_COMMAND, 0, PCI_COMMAND_MASTER);
> >        pci_config_maskw(bdf, PCI_COMMAND, 0, PCI_COMMAND_MASTER | PCI_COMMAND_IO | PCI_COMMAND_MEMORY);
>
> I think that should go in.  If we need it, we better make sure it
> is enabled instead of expecting someone else to do it.

I think this reasoning is completely broken; what you are saying is
that SeaBIOS should in principle do the complete hardware init.

It is IMO broken enough that SeaBIOS does so for QEMU - please don't
push that into SeaBIOS built for coreboot, but fix the actual
problem where it exists (in coreboot), instead of making a workaround
in SeaBIOS under the guise of "we need it so we must do it ourselves"

It sounds like NIH syndrome. :\

//Peter