[SeaBIOS] Re: [PATCH] optionroms: Use revision when finding Option ROM

[Gerd Hoffmann]

On Mon, Mar 16, 2020 at 05:48:55PM +0100, Paul Menzel wrote:
> From: Rob Barnes 
> Date: Wed, 22 Jan 2020 14:09:21 -0700
>
> Some devices have the same vendor and device ID but need different
> Option ROM files. Change the look-up to include the revision, then
> fallback to looking up without the revision.
>
> BUG=b:148125384
> TEST=Manual, boot trembyle and confirm SeaBIOS console is displayed.
> char fname[17];
> snprintf(fname, sizeof(fname), "pci%04x,%04x.rom"
>         , pci->vendor, pci->device);
> char fname[20];
> // Try to find rom file with revision included
> snprintf(fname, sizeof(fname), "pci%04x,%04x,%02x.rom"
>         , pci->vendor, pci->device, pci->revision);
> struct romfile_s *file = romfile_find(fname);
> if (!file) {
>    // Fallback to finding rom file without revision
>    snprintf(fname, sizeof(fname), "pci%04x,%04x.rom"
>         , pci->vendor, pci->device);
>    file = romfile_find(fname);
> }

Looks good too, but likewise doesn't apply.

Seems something is broken in your mail workflow.
Did you use "git send-email" which usually gets things right?

cheers,
  Gerd