Yes we were aware of that, we do not wish to change legacy SMBIOS code behavior and we are
aware of the “machine implementation” technique for both legacy and non-legacy SMBIOS
This commit was simply a bug fix.
Thanks for applying it!
On 7 May 2019, at 17:45, Kevin O'Connor
On Wed, Apr 24, 2019 at 05:04:09PM +0300, Sam Eiderman wrote:
From the above it can be seen that any SMBIOS
type which contains string
references should end with an additional zero byte.
Thanks. I committed this change.
I noticed during the commit that this change was made to the legacy
smbios tables. Just to be clear, we recommend that the "machine
implementation" (eg, coreboot, qemu, xen, etc.) pass appropriate
smbios tables to SeaBIOS (thus bypassing the legacy smbios generation
code). See the code in src/fw/biostables.c for reference.