On Tue, 15 Nov 2016 11:36:21 +0100 Gerd Hoffmann kraxel@redhat.com wrote:
On So, 2016-11-13 at 23:05 -0500, Kevin O'Connor wrote:
On Fri, Nov 11, 2016 at 04:35:15PM +0100, Igor Mammedov wrote:
since QEMU_CFG_NB_CPUS not going away anytime soon and serves the same purpose as just added "etc/boot-cpus" fw_cfg drop support for "etc/boot-cpus" while this code is not in use yet (i.e. QEMU with "etc/boot-cpus" hasn't been released) and reuse QEMU_CFG_NB_CPUS instead of it.
I'm okay with this change. I'd like to get Gerd's comments as well though as the patch is targeted for a stable branch.
Looks good to me too. I should have remembered this before as I actually added QEMU_CFG_NB_CPUS support to coreboot ...
I'm sorry for making a mess in the first place, I should have looked more into existing fw_cfg interfaces before adding a new one.
Process as usual: commit to qemu first, then seabios (master goes first, then cherry-pick into stable), then update seabios binaries in qemu.
ok, resubmitted v2 of QEMU side
cheers, Gerd