[SeaBIOS] Re: [PATCH 3/4] vga: add atiext driver

[Kevin O'Connor]

On Thu, Mar 14, 2019 at 01:27:17PM +0100, Gerd Hoffmann wrote:
> Supports qemu emulated ati cards.  They have been added in qemu 4.0.
> Acceleration support (in qemu) is pretty rough still.  A simple
> framebuffer works fine though.
>
> Available models:
> ati rage 128 pro
> ati rv100
>
> Note: The ati_regs.h file is just copyed over from qemu.

[...]
> --- /dev/null
> +++ b/vgasrc/ati_regs.h
> @@ -0,0 +1,455 @@
> +/*
> ATI VGA register definitions
> based on:
> linux/include/video/aty128.h
> Register definitions for ATI Rage128 boards
> Anthony Tong <[e-mail]>, 1999
> Brad Douglas <[e-mail]>, 2000
> and linux/include/video/radeon.h
> This work is licensed under the GNU GPL license version 2.

I'm concerned about conflicting license statements in the code
(SeaBIOS is LGPLv3).  Not sure how best to resolve that.  Are there
many constants needed?

Otherwise the series looks good to me.

Thanks,
-Kevin