[SeaBIOS] Re: [PATCH v2] csm: Fix boot priority translation

[Kevin O'Connor]

On Thu, Jun 20, 2019 at 03:12:33PM +0100, David Woodhouse wrote:
> On Thu, 2019-06-20 at 09:43 -0400, Kevin O'Connor wrote:
> > On Thu, Jun 20, 2019 at 01:07:45PM +0100, David Woodhouse wrote:
> > > For CSM, the highest priority for a boot entry is zero. SeaBIOS doesn't
> > > use zero, and the highest priority is 1.
> >
> > FYI, SeaBIOS does treat zero as the highest priority.  And a negative
> > priority means "use default priority".
> >
> > I'm fine with the change, though.
>
> I don't think find_prio ever returns zero.
> dprintf(1, "Searching bootorder for: %s\n", glob);
> int i;
> for (i = 0; i < BootorderCount; i++)
>     if (glob_prefix(glob, Bootorder[i]))
>         return i+1;
> return -1;

True, but interactive_bootmenu() sets the priority to zero if the
device is selected.  (I'm guessing find_prio() returned 1+ just to
avoid confusion with interactive_bootmenu().)

In any case, I'm fine with your change.

-Kevin