On Fri, Nov 15, 2024 at 12:40:06PM +0100, Gerd Hoffmann wrote:
This series adds an option to set the memory layout preference, both at compile time (via kconfig) and runtime (via fwcfg).
Gerd Hoffmann (4): add guest hint variable use guest hint as additional condition add guest hint default kconfig add guest hint fw_cfg override
Thanks. For what it is worth, I think it would be preferable to have a more specific variable name, such as "etc/pci-pad-64bit-mappings" and make the implementation specific to the pciinit.c code. I fear a generic name like "GuestHint" will be opaque to users and future developers, and possibly encourage complicated heuristics.
It might also be nice to support forcing the option in both directions - for example: 0 - use default heuristic, 1 - avoid 64bit padding, 2 - force 64bit padding.
I'd also avoid adding a Kconfig setting for this - we don't use Kconfig for any other defaults and I think it will be unwieldly to try to use Kconfig in that role.
Cheers, -Kevin