On 02/13/2015 02:10 PM, Kevin O'Connor wrote:
On Wed, Feb 11, 2015 at 05:32:36PM -0600, Timothy Pearson wrote:
File: pci_optrom_blacklist.txt
Syntax: <bus>,<device>,<function> Numbers or a single wildcard ('*') are allowed Each blacklisted device is placed on separate line
Examples: Blacklist device 01:04.0: 1,4,0 Blacklist all devices on bus 5: 5,*,*
TEST: Booted ASUS KFSN4-DRE with iPXE ROMs built in to CBFS; with the two add-on network devices blacklisted the add-on network ROMs were ignored while the on-board iPXE ROMs executed normally.
Thanks for submitting.
It's possible to blacklist the execution of an option rom on a particular device today by creating a dummy option rom for that device in CBFS. Given this, is this patch still needed?
As mentioned in my previous message yes, I believe the additional functionality offered by this patch is needed. At least on my coreboot-based board here the BDFs are stable and it is useful to, for example, blacklist the option ROMs on the add-on slots to avoid a potential failure to boot when the hardware is inevitably reconfigured in the future.
Putting PCI bus/dev/fn ids in CBFS isn't a great solution because (I'm told) some boards can change BDFs from one boot to another. (In general, BDFs are not stable.) That's why the existing option rom mechanism uses vendor/device ids.
BTW, the white space in your patch got corrupted during delivery.
If you are considering using the patch I will re-send.
Thanks!