Re: [SeaBIOS] [PATCH] SMBIOS: Add SMBIOS Type 6 Memory Module Information

[Laszlo Ersek]

On 11/28/18 16:54, Liran Alon wrote:
> From: Arbel Moshe
>
> Add support for obsolete SMBIOS Type 6 which describes the speed, type,
> size and error status of each system memory module.
>
> This is required by some guests to boot successfully.
>
> Such an example is Cisco NGFW appliance which has a script which
> runs every boot that parses this SMBIOS Type 6 information and if
> it doesn't exists, it just fails to boot with an error of
> "Unable to parse dmidecode. Restarting now!".
>
> Reviewed-by: Liran Alon 
> Reviewed-by: Ross Philipson 
> Signed-off-by: Arbel Moshe
>
> src/fw/smbios.c  | 46 ++++++++++++++++++++++++++++++++++++++++++++++

This file starts with the following two lines:

// smbios table generation (on emulators)
// DO NOT ADD NEW FEATURES HERE.  (See paravirt.c / biostables.c instead.)

Please consider extending the SMBIOS generator in QEMU instead.

Thanks
Laszlo