Re: [SeaBIOS] [PATCH v3 2/2] QEMU fw_cfg: Add command to write back address of file

[Laszlo Ersek]

On 02/17/17 11:06, Laszlo Ersek wrote:
> About the "condensed" form, think something like:
> uint16_t dst_file_key
> uint32_t dst_file_offset
> uint64_t pointer_value
> uint8_t pointer_size

This is likely not the best arrangement of the fields BTW, for saving
static (reserved) memory. Either use a field order that looks logical,
and add __attribute__ ((packed)), or else order the fields by decreasing
size.

Thanks
Laszlo