Hello Kevin,
On 10/22/19 12:35 AM, Kevin O'Connor wrote:
On Mon, Oct 21, 2019 at 10:33:19PM +0200, Uwe Kleine-König wrote:
I like this change in general. Note however that I could not have signed-off my patch that resulted in fc92d092ea4f704bc4d283c3911ee9894733f4ce according to the rules you introduce here.
I don't want to be nitpicky, but it is unclear if you are uncomfortable with the submission. If you are, please state that and I will revert the commit.
I'm not really uncomfortable. You are free to consider my submissions to be covered by GPLv3 or LGPLv3 and integrate them into seabios as you did. So "in spirit" I agree to the DCO.
I just think that being picky is right when talking about license stuff and being picky some files not having a copyright might be problematic. And as pointed out earlier on this list[1], this is not only about vgasrc/svgamodes.c.
We do try to make the copyrights and submission process transparent. I don't feel the license or process has been unclear.
If you think that the semantic you formalized in your change was in effect already before, then Gerd's mail to that topic[2] was at least incomplete. I asked about clarifying the semantic and didn't understand Matt's reply as to also apply to seabios but instead thought he describes the semantic for the kernel only and for seabios the semantic was only what Gerd described.
So my S-o-b was given -- while right by intend -- wrong by the letter.
The DCO was indirectly documented before via the QEMU documentation: https://www.seabios.org/Contributing states the process follows: http://wiki.qemu.org/Contribute/SubmitAPatch The SeaBIOS license is in the COPYING and COPYING.LESSER files in the git repo.
So a contributor can select himself if he wants GPL or LGPL?
Best regards Uwe
[1] https://mail.coreboot.org/hyperkitty/list/seabios@seabios.org/thread/Z6FPBB7..., My mail from Oct 14, 09:45 [2] https://mail.coreboot.org/hyperkitty/list/seabios@seabios.org/thread/Z6FPBB7..., Gerd's mail from Oct 17, 10:51