[SeaBIOS] Re: [PATCH 1/2] cbvga: reuse svga modes definitions from svgamodes.c

[Kevin O'Connor]

Hi,

On Tue, Jul 30, 2019 at 07:21:36PM +0200, Uwe Kleine-König wrote:
> @@ -91,8 +28,8 @@ struct vgamode_s *cbvga_find_mode(int mode)
>          return &CBemulinfo;
>  int i;
> for (i = 0; i < ARRAY_SIZE(cbvesa_modes); i++) {
>    struct cbvga_mode_s *cbmode_g = &cbvesa_modes[i];
> for (i = 0; i < svga_mcount; i++) {

The vgabios runs in 16bit mode, so all reads of global variables must
be wrapped in GET_GLOBAL() - for example:

for (i = 0; i < GET_GLOBAL(svga_mcount); i++) {

Otherwise, the series looks good to me.

-Kevin