Re: [SeaBIOS] [PATCH] serial console conflicts with serial debugging

[Gerd Hoffmann]

On Thu, 2017-11-02 at 11:11 -0400, Kevin O'Connor wrote:
> On Thu, Nov 02, 2017 at 10:02:52AM +0100, Gerd Hoffmann wrote:
> > Signed-off-by: Gerd Hoffmann
>
> If we defaulted "screen-and-debug" to zero on sercon, would that be
> sufficient?

Improves the situation, output more readable.  But sercon's idea of the
cursor position etc. doesn't match reality any more due to the
additional debug output, which still messes things up a bit.  I can
live with that though.

Tested patch:

--- a/src/sercon.c
+++ b/src/sercon.c
@@ -523,6 +523,10 @@ void sercon_setup(void)
         return;
     dprintf(1, "sercon: using ioport 0x%x\n", addr);
 
+    if (CONFIG_DEBUG_SERIAL)
+        if (addr == CONFIG_DEBUG_SERIAL_PORT)
+            ScreenAndDebug = 0;
+
     vgabios = GET_IVT(0x10);
     seabios = FUNC16(entry_10);
     if (vgabios.seg != seabios.seg ||