Hi,
However, SeaBIOS should be managing the space between 0xc0000-0xfffff, and SeaBIOS does not care about the padding. So I'm not sure how this patch helps.
As said in the description, I consider it desirable, as the pointless padding was at least confusing to me.
Flash chips (as real hardware) usually have power-of-two sizes. I would be confused by a 192k rom ...
If it being merely cosmetic makes the patch undesirable to you, I'll have to live with that (and hope to remember to not be confused the next time I have to look at the rather difficult to understand build logic).
When touching this logic I think we should go for a config option.
Current qemu seabios builds end up being around 128k in size. Depending on the compiler used you'll get a 128k (gcc 4.4) or a 256k rom (gcc 4.7 +). The size of the rom changing is a problem because it breaks qemu live migration.
Explicitly specifying the size would solve this. You can specify size=128k then and the build will fail if it doesn't fit. You can specify size=256k and you'll get a 256k rom even if it would fit into 128k. And we could allow size=192k too ;)
cheers, Gerd