[SeaBIOS] Re: [PATCH] virtio-scsi: initialize the ctrl and event vq

[Li Feng]

Thanks,
Feng Li

Paul Menzel  于2021年8月31日周二 下午6:57写道：
> Dear Li,
>
> Thank you for your contribution.
>
> Am 31.08.21 um 12:49 schrieb Li Feng:
> > Currently, virtio-scsi doesn't support any control or event message, this patch
> > add the basic initialization.
>
> add*s* or imperative mood: …, so add the basic initialization.
> > Some backends need this feature, like dpdk.
>
> It’d be great, if you added more details how to test it.

Thanks for your fast reply, I will send the v2 patch with a better
commit message.
> > Signed-off-by: Li Feng
> >
> > src/hw/virtio-scsi.c | 12 +++++++++++-
> >   1 file changed, 11 insertions(+), 1 deletion(-)
> >
> > diff --git a/src/hw/virtio-scsi.c b/src/hw/virtio-scsi.c
> > index 369c981..e16d4b0 100644
> > --- a/src/hw/virtio-scsi.c
> > +++ b/src/hw/virtio-scsi.c
> > @@ -203,8 +203,18 @@ init_virtio_scsi(void *data)
> >           }
> >       }
> > if (vp_find_vq(vp, 0, &vq) < 0 ) {
> >    dprintf(1, "fail to find ctrl vq for virtio-scsi %pP\n", pci);
> >    goto fail;
> > }
> > if (vp_find_vq(vp, 1, &vq) < 0 ) {
> >    dprintf(1, "fail to find event vq for virtio-scsi %pP\n", pci);
> >    goto fail;
> > }
> > if (vp_find_vq(vp, 2, &vq) < 0 ) {
> >    dprintf(1, "fail to find vq for virtio-scsi %pP\n", pci);
> >    dprintf(1, "fail to find req vq for virtio-scsi %pP\n", pci);
> >     goto fail;
> > }
>
> Kind regards,
>
> Paul