Hey Daniel,
thanks for the bugfixes! Much appreciated. They all look good to me.
On Thu, 2017-02-23 at 23:27 -0700, Daniel Verkamp wrote:
Rather than using the Identify command with CNS 01b (GET_NS_LIST), which was added in NVMe 1.1, we can just enumerate all of the possible namespace IDs.
That should also fix the code to work correctly on older Qemu versions (<2.7). Nice.
The relevant part of the NVMe spec reads:
Namespaces shall be allocated in order (starting with 1) and packed sequentially.
I see that sentence in my copy of the NVMe 1.0e spec, but for 1.2 it's gone. I'd assume this is no problem for any sane NVMe device.
Julian -- Amazon Development Center Germany GmbH Berlin - Dresden - Aachen main office: Krausenstr. 38, 10117 Berlin Geschäftsführer: Dr. Ralf Herbrich, Christian Schläger Ust-ID: DE289237879 Eingetragen am Amtsgericht Charlottenburg HRB 149173 B
Amazon Development Center Germany GmbH Berlin - Dresden - Aachen main office: Krausenstr. 38, 10117 Berlin Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger Ust-ID: DE289237879 Eingetragen am Amtsgericht Charlottenburg HRB 149173 B