Re: [SeaBIOS] [PATCH] Add pvevent device driver

[Gleb Natapov]

On Thu, Mar 14, 2013 at 10:15:02AM +0100, Paolo Bonzini wrote:
> Il 14/03/2013 09:48, Hu Tao ha scritto:
> > pvevent device is used to notify host(qemu) when guest panic
> > happens.
> >
> > ref: http://lists.nongnu.org/archive/html/qemu-devel/2013-03/msg02293.html
> > Signed-off-by: Hu Tao
> >
> > src/acpi-dsdt-isa.dsl | 30 ++++++++++++++++++++++++++++++
> >  1 file changed, 30 insertions(+)
> >
> > diff --git a/src/acpi-dsdt-isa.dsl b/src/acpi-dsdt-isa.dsl
> > index 23761db..d083245 100644
> > --- a/src/acpi-dsdt-isa.dsl
> > +++ b/src/acpi-dsdt-isa.dsl
> > @@ -99,4 +99,34 @@ Scope(_SB.PCI0.ISA) {
> >              IRQNoFlags() { 3 }
> >          })
> >      }
> > Device(PEVT) {
> >    Name(_HID, "MSFT0001")
> >    OperationRegion(PEOR, SystemIO, 0x0505, 0x01)
> >    Field(PEOR, ByteAcc, NoLock, Preserve) {
> >        PEPT,   8,
> >    }
> >    Method(_STA, 0, NotSerialized) {
> >        Store(PEPT, Local0)
> >        If (LEqual(Local0, Zero)) {
> >            Return (0x00)
> >        } Else {
> >            Return (0x0F)
> >        }
> >    }
> >    Method(RDPT, 0, NotSerialized) {
> >        Store(PEPT, Local0)
> >        Return (Local0)
> >    }
> >    Method(WRPT, 1, NotSerialized) {
> >        Store(Arg0, PEPT)
> >    }
> >    Name(_CRS, ResourceTemplate() {
> >        IO(Decode16, 0x0505, 0x0505, 0x01, 0x01)
> >    })
> > }
> >
> > }
>
> I like the idea of using methods in the DSDT to isolate from the actual
> implementation of the device.  I don't see a huge problem with the
> probing, but Gleb does so please go on with the fw_cfg part.

Using methods is very nice idea indeed.