Re: [SeaBIOS] [PATCH] tsc: use kvmclock for calibration

[Avi Kivity]

On 08/09/2012 05:12 PM, Gerd Hoffmann wrote:
> Hi,
> > > er, the documentation says 4 bytes (so stack alignment works).  I
> > > distinctly remember having a large alignment requirement so we don't
> > > cross a page or slot boundary... something's wrong here.
> >
> > case MSR_KVM_SYSTEM_TIME: {
>
> [ ... ]
> > So your tests worked by pure luck, but the bug is in kvm.  We need to
> > grab two pages here.
>
> Ok, so better use memalign(32,32) to make sure the struct doesn't cross
> a page border ...

No, we need to fix kvm, no need to complicate the guest for that.