On 03/21/13 14:01, Michael S. Tsirkin wrote:
On Thu, Mar 21, 2013 at 01:49:36PM +0100, Gerd Hoffmann wrote:
Hi,
How about we don't bother to determine this at runtime at all?
Because it will be a PITA for testers + developers to figure the correct .config switches of the day during the transition phase?
Why is it a PITA? Are you developing QEMU? Just use the makefile from roms/config.seabios Are you using QEMU binary? Just use the defaults.
SeaBIOS binaries are running on a wide range of qemu versions today. Changing that is a big deal.
Chaqnging what? Legacy QEMU will keep working if you build in ACPI tables.
Today you can clone upstream seabios, build it, and the resulting image will work on pretty much any qemu version since 0.12 or so. You don't have to pick the correct config switches for your particular qemu version, it just works. I think it should stay that way by default.
Having config options to turn off support for older qemu versions is fine, so we can strip the bios binaries bundled with qemu by leaving out code which would not be used anyway.
For starters the usual way to package seabios and qemu in distros is to have separate packages ...
Which ones? That's just crazy. Fedora packages them together:
No:
[root@fedora ~]# ll /usr/share/qemu/bios.bin lrwxrwxrwx. 1 root root 19 Feb 13 15:49 /usr/share/qemu/bios.bin -> ../seabios/bios.bin [root@fedora ~]# rpm -qf /usr/share/*/bios.bin qemu-system-x86-1.2.2-6.fc18.x86_64 seabios-bin-1.7.1-4.fc18.noarch
cheers, Gerd