On Fri, Jul 20, 2012 at 07:24:27AM -0300, Marcelo Tosatti wrote:
On Fri, Jul 20, 2012 at 07:49:03AM +0300, Gleb Natapov wrote:
On Thu, Jul 19, 2012 at 08:44:07PM -0400, Kevin O'Connor wrote:
On Tue, Jul 17, 2012 at 02:18:00PM -0300, Marcelo Tosatti wrote:
Enable bit 15 (USE_PLATFORM_CLOCK) of FADT flags field so that older Windows guests do not make use of the TSC for timestamping.
I fixed up and committed this patch. But after I committed it, I realized it reverted Gleb's "Drop FIX_RTC flag from FADT" patch (c7be281b). Gleb, if you can you confirm c7be281b is still valid I'll put it back in.
It also reverts 20fcf9b.
20fcf9b = addition of RTC_S4 (bit 7).
The patch i sent to add bit 15 does not touch that:
- /* WBINVD + PROC_C1 + SLP_BUTTON + RTC_S4 */
- fadt->flags = cpu_to_le32((1 << 0) | (1 << 2) | (1 << 5) | (1 << 7));
- /* WBINVD + PROC_C1 + SLP_BUTTON + RTC_S4 + USE_PLATFORM_CLOCK */
- fadt->flags = cpu_to_le32((1 << 0) | (1 << 2) | (1 << 5) | (1 << 7) |
(1 << 15));
Actually the patch is: - /* WBINVD + PROC_C1 + SLP_BUTTON + FIX_RTC */ - fadt->flags = cpu_to_le32((1 << 0) | (1 << 2) | (1 << 5) | (1 << 6)); + /* WBINVD + PROC_C1 + SLP_BUTTON + FIX_RTC + USE_PLATFORM_CLOCK */ + fadt->flags = cpu_to_le32((1 << 0) | (1 << 2) | (1 << 5) | (1 << 6) | + (1 << 15));
Somehow (1 << 7) became (1 << 6).
-- Gleb.