Re: [SeaBIOS] [PATCH] smm: ignore bits 16,18-31 of SMM revision ID

[Paolo Bonzini]

On 30/07/2015 17:36, Kevin O'Connor wrote:
> > >  if (smm == (void*)BUILD_SMM_INIT_ADDR) {
> > >      // relocate SMBASE to 0xa0000
> > >    if (smm->cpu.i32.smm_rev == SMM_REV_I32) {
> > >    u32 rev = smm->cpu.i32.smm_rev & SMM_REV_MASK;
> > >    if (rev == SMM_REV_I32) {
>
> I noticed that this patch from May changes the revision check to use a
> mask in the SMM init code, but doesn't change the check in the runtime
> part of the handler.  Was this intentional?

No, it wasn't!  Good catch.

Paolo