Hello Kevin,
On 10/13/19 4:07 AM, Kevin O'Connor wrote:
The commits should have a signed-off-by line though.
Not sure what is meant here. Do you miss an S-o-b by me or by Gerd?
If the former and assuming the intention is that its meaning is similar to that in the kernel: INAL, but I think if you want to have an at least small chance that this formalism has any juristic meaning you need to formalize it. Currently you ship GPLv3 and LGPLv3 in seabios.git but many source files don't have their own copyright notes that declare which should be effective[1]. Also there is no file that documents what Signed-off-by should actually mean.
Just my 0.02€ Uwe
[1] I only checked a few files (vgasrc/ramfb.c, vgasrc/svgamodes.c) by hand and assumed the other files to be in a similar situation. A quick glance using licensecheck from https://metacpan.org/release/App-Licensecheck:
seabios$ git ls-files | xargs licensecheck | sed "s/.*: //" | sort | uniq -c 2008 is > 1013 at /usr/share/perl5/String/Copyright.pm line 194. 1 BSD (2 clause) 10 GPL 4 GPL GENERATED FILE 16 GPL (v2.0) 1 GPL (v2) GENERATED FILE 102 LGPL (v3) 1 MIT/X11 (BSD like) 3 *No copyright* GENERATED FILE 1 *No copyright* GPL (v2.0) 7 *No copyright* GPL (v2 or later) (with incorrect FSF address) 3 *No copyright* LGPL (v3) 101 *No copyright* UNKNOWN 6 UNKNOWN