Re: [SeaBIOS] [PATCH v3 0/3] usb: add xhci support

[Michael S. Tsirkin]

On Mon, Nov 04, 2013 at 09:24:53AM +0200, Michael S. Tsirkin wrote:
> On Fri, Sep 13, 2013 at 01:21:08PM +0200, Gerd Hoffmann wrote:
> > Hi,
> >
> > Next version of the xhci support patch series.  Changed xhci device
> > list to use standard hlist macros.  Delete devices from list in
> > disconnect() callback, so we should not have inactive/freed devices
> > in the list.
> >
> > cheers,
> >   Gerd
>
> Looks like this breaks isapc support in qemu.
> To test: check out qemu 1.6 (latest version has other bugs)
>
> Then boos some live iso:
>
> ./i386-softmmu/qemu-system-i386 -M isapc  -drive
> file=/home/mst/images/systemrescuecd-x86-2.8.0.iso,if=none,id=foo,media=cdrom,snapshot=off,format=raw
> -L /scm/seabios/out/ -bios /scm/seabios/out/bios.bin -device
> ide-cd,drive=foo -sdl -enable-kvm
>
> Before this change, guest boots fine. after this change:
>
> KVM internal error. Suberror: 1
> emulation failure
> EAX=000f0000 EBX=f8101091 ECX=00000fd0 EDX=00000000
> ESI=000f0fc5 EDI=07feff34 EBP=07fdfb30 ESP=00006d78
> EIP=07ffffff EFL=00010006 [-----P-] CPL=0 II=0 A20=1 SMM=0 HLT=0
> ES =0010 00000000 ffffffff 00c09300 DPL=0 DS   [-WA]
> CS =0008 00000000 ffffffff 00c09b00 DPL=0 CS32 [-RA]
> SS =0010 00000000 ffffffff 00c09300 DPL=0 DS   [-WA]
> DS =0010 00000000 ffffffff 00c09300 DPL=0 DS   [-WA]
> FS =0010 00000000 ffffffff 00c09300 DPL=0 DS   [-WA]
> GS =0010 00000000 ffffffff 00c09300 DPL=0 DS   [-WA]
> LDT=0000 00000000 0000ffff 00008200 DPL=0 LDT
> TR =0000 00000000 0000ffff 00008b00 DPL=0 TSS32-busy
> GDT=     000f6448 00000037
> IDT=     000f6486 00000000
> CR0=60000011 CR2=00000000 CR3=00000000 CR4=00000000
> DR0=00000000 DR1=00000000 DR2=00000000 DR3=00000000 
> DR6=ffff0ff0 DR7=00000400
> EFER=0000000000000000
> Code=00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 <00> 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00
>
> bisect result:
> e144bb7af49ca8756b7222a75811f3b85b0bc1f5 is the first bad commit
> commit e144bb7af49ca8756b7222a75811f3b85b0bc1f5
> Author: Gerd Hoffmann 
> Date:   Mon Jun 3 16:30:18 2013 +0200
> usb: add xhci support
>
> $subject says all.  Support for usb3 streams is not implemented yet,
> otherwise it is fully functional.  Tested all usb devices supported
> by qemu (keyboard, storage, usb hubs), except for usb attached scsi
> in usb3 mode (which needs streams).
>
> Tested on qemu only, tagged with QEMU_HARDWARE because of that.
> Testing with physical hardware to be done.
>
> Signed-off-by: Gerd Hoffmann <[e-mail]>

FYI just disabling USB at build time works.
>