On Sun, Dec 15, 2019 at 09:26:17PM -0600, Matt DeVillier wrote:
On Sun, Dec 15, 2019 at 6:26 PM Kevin O'Connor kevin@koconnor.net wrote:
On Sat, Dec 14, 2019 at 11:26:17AM -0600, Matt DeVillier wrote:
Some USB keyboards report 9 or 10-byte max packet sizes, instead of the 8-byte max specified by the USB HID spec. Handle this by increasing the size of the keyevent struct to 10 bytes, and using the key array size of the usbkeyinfo struct as loop bounds rather than that of the keyevent struct (since the former will always be smaller, and within spec).
Test: built/boot on Google Pixel Slate, observe keyboard functional
Thanks. I think it would be good if the relationship between the test and the struct sizes was more clear. What about the below (totally untested)?
-Kevin
your version produces a working keyboard on the Pixel Slate (when used in conjunction with my other patch), but unsure how to test the mouse TBH.
Thanks. I committed this change.
-Kevin