[SeaBIOS] Re: [PATCH v3 1/3] virtio-blk: add feature VIRTIO_BLK_F_SIZE_MAX and VIRTIO_BLK_F_SEG_MAX

[Gerd Hoffmann]

Hi,
>    if (features & max_segment_size)
>        vdrive->drive.max_segment_size =
>            vp_read(&vp->device, struct virtio_blk_config, size_max);
>    else
>        vdrive->drive.max_segment_size = 0;

Not needed, there is a memset(0) for the complete vdrive struct.
>    dprintf(3, "virtio-blk %pP size_max=%u.\n", pci,
>            vdrive->drive.max_segment_size);

Can you just add that to the existing dprintf instead of adding a new
line to the log?

thanks,
  Gerd