Re: [SeaBIOS] [PATCH] seabios: restore piix pm config registers after resume

[Michael S. Tsirkin]

On Mon, Jan 13, 2014 at 11:45:40AM -0500, Kevin O'Connor wrote:
> On Mon, Jan 13, 2014 at 06:36:56PM +0200, Michael S. Tsirkin wrote:
> > On Mon, Jan 13, 2014 at 11:31:20AM -0500, Kevin O'Connor wrote:
> > > +void
> > > +pci_resume(void)
> > > +{
> > > if (!CONFIG_QEMU)
> > >    return;
> > > if (PiixPMBDF >= 0)
> >
> > so this does nothing unless piix4_pm_setup run but
> > if it did why do we need to resume anything?
>
> PiixPMBDF is set during the SeaBIOS init phase.  The proposed
> pci_resume() function is called during the resume phase.  The goal of
> the proposed patch is to store the BDF during init so that it's
> available during resume without requiring a bus scan.
>
> -Kevin

Confused. I thought pci_init_device is the one
calling piix4_pm_setup.

What am I missing?