Re: [SeaBIOS] [PATCH 1/2] vgabios: Add config option for assembler fixups

[Peter Stuge]

Kevin O'Connor wrote:
> +++ b/vgasrc/vgaentry.S
> @@ -64,6 +64,7 @@ x86emu_fault:
>          // This macro implements a call while avoiding instructions
>          // that old versions of x86emu have problems with.
>          .macro VGA_CALLL cfunc
> +#if CONFIG_VGA_FIXUP_ASM
>          // Make sure leal instruction works.

Isn't the logic backwards here?

Very nice work on this patchset! :)

//Peter