Re: [SeaBIOS] [PATCH 0/5] SeaVGABIOS improvments for coreboot's framebuffer v3

[Kevin O'Connor]

On Mon, May 29, 2017 at 07:25:09PM +0200, Patrick Rudolph wrote:
> This series add several fixes to coreboot's framebuffer implementation 
> and it main purpose is to fix Microsoft's Windows as supported OS.
>
> Tests showed that it also fixes ISOLINUX and gfxboot.
>
> The series fixes the following issues:
> Windows shows no image in text-mode
> Windows NTLDR/bootmgr shows no image in VESA mode
> Windows shows no image in VESA mode
> ISOLINUX requires VESA mode 640x480
> GFXBOOT requires 32bpp VESA modes
>
> I was able to boot Windows with the following configurations:
> using VgaSave driver in text-mode with a
> fixed display resolution of 640x480 at 4Bpp.
> using VgaSave driver in VESA mode and
> set a display resolution up to 1600x1200 at 24Bpp.
> using VgaSave driver in Windows's "Safe Mode" in VESA mode and
> set a display resolution up to 1600x1200 at 24Bpp.
>
> Most likely other VESA compatible bootloaders and operating systems
> will be fixed, too.
>
> Changes since v2:
> Disable VESA modes in cbvga_init
> No Intel or Windows specific patches
> Update commit message of "Assume VGA compatible GPU in text-mode"
> Tested and dokumented more bootloaders

Thanks.  I committed patches 1, 3, 4, 5.

I'm not confident on patch 2 - I can't see why cbvga should behave
like stdvga when a user could just compile a stdvga vgabios instead of
cbvga.  I fixed up patch 5 to apply without patch 2.

-Kevin