[SeaBIOS] Re: [PATCH 1/2] cbvga: reuse svga modes definitions from svgamodes.c

[Gerd Hoffmann]

Hi,
>  // Validate modes
> for (i = 0; i < ARRAY_SIZE(cbvesa_modes); i++) {
>    struct cbvga_mode_s *cbmode_g = &cbvesa_modes[i];
> for (i = 0; i < svga_mcount; i++) {
>    struct generic_svga_mode *cbmode_g = &svga_modes[i];
>    /* Skip VBE modes that doesn't fit into coreboot's framebuffer */
>    if ((GET_GLOBAL(cbmode_g->info.height) > ylines)
>        || (GET_GLOBAL(cbmode_g->info.width) > xlines)

Note that svga_modes has more modes than cbvesa_modes, specifically some
where memmodel != MM_DIRECT.  These must be skipped too.

Otherwise looks fine.  Didn't test it yet though.

cheers,
  Gerd